From patchwork Wed Jan 25 19:50:46 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Markus Schneider-Pargmann X-Patchwork-Id: 48273 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp456042wrn; Wed, 25 Jan 2023 11:51:58 -0800 (PST) X-Google-Smtp-Source: AMrXdXuIj3aCkj99bNcNh1I3jbhDrDkmAh4sh3R06jiXTdw1UaQN0R62DS8Rjcm9E95G8JmWn/Zf X-Received: by 2002:a17:90a:cb88:b0:225:e9d9:63b2 with SMTP id a8-20020a17090acb8800b00225e9d963b2mr36492397pju.42.1674676318364; Wed, 25 Jan 2023 11:51:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674676318; cv=none; d=google.com; s=arc-20160816; b=THZ6qwURLsGtd09sVQUOes3eUNEJVj6Ghs60sfjNFEuP2Y+PXMiltIPvD9lti1m/Qm mSJ+AuVT4j0I+JovxGRL+Wl3Fd6Vdl66mx3mmTY2CxJuYgjSh/mZ1pysYeTht4A5SzNj wlCYm5KE9PqvlJ3tWb+wC/h7rmPMkl9t4ZluijSRqmP7O9h7zdLnybo2rLCaVKHGLucf 7WGhdMX0mlpwnyFeva1be19FfGwRJsHiesqGeR/lPYNEmlbXiQUwgYQvSrFA+b+WJb74 RwVNmhXmF8DMqG5cMw724d4fDOZuL1grkr9aWRQQJfmcVuAR+qTL1jht27PGRi+qx4sW smpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=EadAaSBIPgk+IhFGEGl7ST9vXs3rcnt68GgP+MjrSEY=; b=jlxuMnybCkMJp9wik1zH+8rPoBigBMNT7hbXv4sZ5Riuqwo2l8cPYJOvOSWG2fcdiA ayxmpkJlUbJgHkcNkFR2MEoo/EPQp34uupvNGuh/31Hq1dCMdMt5SyWpC9jhRTV963oB CCxWSviHMZxQN2CAXZFXvci56yZiSewY/MPteMrTM5lZGvr8FYK4aGnxwUchgLArefqb 7wgWBZ+rc3/5jeZUXQHmBrjpjzZoLDIDucZSCOqBep0k37r2+n1wQT8zJD6Pdv578xF0 KasG7uld9++RwPxDu4BfBLQKYe6jN/vKXR/YovLTqfwPmzsjnINE4SNA/dwlFGKY2sCX yrEg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@baylibre-com.20210112.gappssmtp.com header.s=20210112 header.b=Rk5M+PVe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j10-20020a17090ae60a00b00219648ff3a5si2679126pjy.171.2023.01.25.11.51.45; Wed, 25 Jan 2023 11:51:58 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20210112.gappssmtp.com header.s=20210112 header.b=Rk5M+PVe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235791AbjAYTvX (ORCPT + 99 others); Wed, 25 Jan 2023 14:51:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48474 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235590AbjAYTvL (ORCPT ); Wed, 25 Jan 2023 14:51:11 -0500 Received: from mail-ej1-x62a.google.com (mail-ej1-x62a.google.com [IPv6:2a00:1450:4864:20::62a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8899D457F6 for ; Wed, 25 Jan 2023 11:51:10 -0800 (PST) Received: by mail-ej1-x62a.google.com with SMTP id mp20so50561539ejc.7 for ; Wed, 25 Jan 2023 11:51:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=EadAaSBIPgk+IhFGEGl7ST9vXs3rcnt68GgP+MjrSEY=; b=Rk5M+PVeGH11E491B1aoDw/oKxxuhtw/OFCxkwW809SrHbXB/tOzU5FRR2xZM+QV/w 0MyCeN4A1JXtDVRtJdh2HDOtEiENmjiSxuSoWftPsy4X3sj4e7XRDNcTGdqpT5ePIvvL 97GZaqLNIlboRnu7swQMKDnryGNscRfU92ehuz7/tVVNPqlAQc5dNKceeGhd0qiM1BPa FFs+UIo7mF4YMnC5Dhx6ELs688A5LNM31fjLxipr7CdvNc3zxMtYjUjgtxMfoYyhhPv7 Nyz9yjQhPQHCcH5F3VL8sFBWBHW1hZSk6VgtzoSOhqI9SJwfO11reWw0nuOl4RrqmAWt /Ktg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EadAaSBIPgk+IhFGEGl7ST9vXs3rcnt68GgP+MjrSEY=; b=YgLbkwXP3FOF55/USfaMiuYFHX+ykZXhGcDBbYGTF6nheYzDRfkG6unhGuPxsWruU8 dNIyXmycKfI4N7I6M6K3rmsPZruWHYwq1OZ4iHeTBWuUJXy5gCDcXiKYXe2QgpA5FF9M fdKWJvmYbB3qZnZc5SA1jwz8ue2OaOZJ3iZuwoXcU/f7IZ4jDxf1jeYAza03PSCZSJhI uBc0Z7hc/P8dPj6FbM21wDOaUYH6o37giiAomxKqzA8BD/UINWP2sc8JwRuXN4mP7Dyg yO2Zsr4XcXltyCBulSpHhF2qPFJMBuWsJFcR9NXaxgQEvrrzZLSm5Xy/TtpqukSMKY/F ZqxA== X-Gm-Message-State: AFqh2kpFr+Lh5FEHLyxokV3WJMEUkrv2Ex9VeJEizkbEuy3T/ud+tpWZ /ONl9Fu3IQWqdf3e4ZzWrsO2Jw== X-Received: by 2002:a17:906:ce23:b0:85a:4230:6743 with SMTP id sd3-20020a170906ce2300b0085a42306743mr33795342ejb.23.1674676268965; Wed, 25 Jan 2023 11:51:08 -0800 (PST) Received: from blmsp.fritz.box ([2001:4091:a247:815f:ef74:e427:628a:752c]) by smtp.gmail.com with ESMTPSA id s15-20020a170906454f00b00872c0bccab2sm2778830ejq.35.2023.01.25.11.51.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Jan 2023 11:51:08 -0800 (PST) From: Markus Schneider-Pargmann To: Marc Kleine-Budde , Chandrasekar Ramakrishnan , Wolfgang Grandegger Cc: Vincent MAILHOL , linux-can@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Markus Schneider-Pargmann Subject: [PATCH v2 05/18] can: m_can: Remove double interrupt enable Date: Wed, 25 Jan 2023 20:50:46 +0100 Message-Id: <20230125195059.630377-6-msp@baylibre.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230125195059.630377-1-msp@baylibre.com> References: <20230125195059.630377-1-msp@baylibre.com> MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1756025395126525039?= X-GMAIL-MSGID: =?utf-8?q?1756025395126525039?= Interrupts are enabled a few lines further down as well. Remove this second call to enable all interrupts. Signed-off-by: Markus Schneider-Pargmann --- drivers/net/can/m_can/m_can.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/can/m_can/m_can.c b/drivers/net/can/m_can/m_can.c index 2df39dfa309b..a668a5836cf8 100644 --- a/drivers/net/can/m_can/m_can.c +++ b/drivers/net/can/m_can/m_can.c @@ -1364,7 +1364,6 @@ static int m_can_chip_config(struct net_device *dev) m_can_write(cdev, M_CAN_TEST, test); /* Enable interrupts */ - m_can_write(cdev, M_CAN_IR, IR_ALL_INT); if (!(cdev->can.ctrlmode & CAN_CTRLMODE_BERR_REPORTING)) if (cdev->version == 30) m_can_write(cdev, M_CAN_IE, IR_ALL_INT &