From patchwork Wed Jan 25 19:50:44 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Markus Schneider-Pargmann X-Patchwork-Id: 48275 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp456082wrn; Wed, 25 Jan 2023 11:52:05 -0800 (PST) X-Google-Smtp-Source: AMrXdXsxZk3KFJopPFGDutKcGNoE6QwtBcz7qP+Etv2R/a6gWcLcRcGnMl8tZ1xIveYVyhwEljWU X-Received: by 2002:a05:6a20:438a:b0:b8:6583:b654 with SMTP id i10-20020a056a20438a00b000b86583b654mr38322214pzl.28.1674676324991; Wed, 25 Jan 2023 11:52:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674676324; cv=none; d=google.com; s=arc-20160816; b=dqedTmYEsK1/BCOVc/9XL7BZIhRrVdvhXAnDioNbL4nO+A+5dw0UE5M94gbIX1dBxX m1zhVa8KNmrB0MImZolhr7jtr4b9TCy2Nr0uHkLNMqkxKUuIIGN90WJMP+zacBd7inUX ASaM2s9bojarADDHxGbjpGTeQ5wE2YtZYW3+RCrC0qxo8arw03sTo3W+x8U9bXpORpQ/ wr4EX4vCNuWrzI9G9OJ6C8Oiv1TrFZE5zh8O1NLzBDU8XA9uEAnyEpxDMNysKUj1C5ds afs6wmPwzj8nQZ8B+EqxaTRv8nvwupD0iCLXP4pQ+Pbz5DEzz1hwlzkDbYFRc10PVjqe fYhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=KMj657mIBfjdrk+ldR8wMbHCeTfGxrOBp5iVvF9MTxo=; b=iidxiAoI/jq0buwya7M9FVK17Iy7kv9oSfsCnvX7LwiiJVZObCn2UzveJ2x05mZcno BtvIgDAmcpys/Xk4ea4KC5zjzmL2z2wT6IA8lc3D4bRxPEpeoGpstV/uY02OqncVcqVZ 7aMsW9dx/T+ndZUF1mlAl2SwxYUAPjDGiX6xx4vtEiZgsE9PG5HAh/w/3VuvxeLCgPRE 3yRNPXIkMCK6B8+nAE9dNP9qrEoeZ7andopIpRQEbppGbyPhnP3nQzcxnI4VnA+FQ7Nf fQ+cJpYW3WG4JbxS6cyUCcFnFm7otN55pfsO+D+dmI1TmumWLvTop5FB1LSN2BkMeBGl PYLA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@baylibre-com.20210112.gappssmtp.com header.s=20210112 header.b=EFj5BZjA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n10-20020a63b44a000000b004da9617dfddsi1187666pgu.210.2023.01.25.11.51.50; Wed, 25 Jan 2023 11:52:04 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20210112.gappssmtp.com header.s=20210112 header.b=EFj5BZjA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235812AbjAYTvZ (ORCPT + 99 others); Wed, 25 Jan 2023 14:51:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48428 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235541AbjAYTvK (ORCPT ); Wed, 25 Jan 2023 14:51:10 -0500 Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [IPv6:2a00:1450:4864:20::633]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CA66A5924A for ; Wed, 25 Jan 2023 11:51:08 -0800 (PST) Received: by mail-ej1-x633.google.com with SMTP id ud5so50647307ejc.4 for ; Wed, 25 Jan 2023 11:51:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=KMj657mIBfjdrk+ldR8wMbHCeTfGxrOBp5iVvF9MTxo=; b=EFj5BZjAFL8VzzzsMv8HLmG2IMjSc/WtgRSZNYk8gLngSYkDAB7eJ0/CCLwCKDaI8l uL+WH4aSlWtfVc22Wv6c8qjPoM+sYBY6mLCHZ7gdQcFQi5JeTiDfy4gtv54pZ7l6soPz gQqOL6bmeJip0Aj839wyJTatzTopDCW6oma33LKx2tWRNP7+NE6T1zYTt7WOKyxx0B8S qzEBX/o0L1jrYmx/lWwxUqgK3kfSiaFXGSFeUUUZxiIwHRvITJLCcZCjVM1HI8mSuqbW nEvIPqZQkpRs4Wm6SrBwyTohOrAoAXEcxldQwfcvvWBAV+gwQNILpSIq7q1/rASXR+v2 MGPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KMj657mIBfjdrk+ldR8wMbHCeTfGxrOBp5iVvF9MTxo=; b=fpSK4wydGBLJIV7FQZOq8thLJ/wtk5Rf9vNm8hbcpm7XGcjBHzqHTtSNoKFtTxV4nq Ut32JejFC1HzVTZ1iJwIYirvYgMsgWWFBRMqQ2L1fS03BX9aTS5Qn8naHg8nk83izom8 2bBQ5hHcKkmvzecpK5jII5DQJCGSymy91etAs+dTq38NsD3M+QTd6zy8ETMofl/SSZq2 cQmFCVfoUBlNgGNGUuWAniUpNhWjx14veZcObA/5tSIwqfUEQj/bI18e4YjqXtkILObE qjGuXY+p0BALCNh6lrURaL4y3BRmtVuuiW6t516h0+qj/2r4jTq31Mjh4qKIXh/Ro+Qc gxNQ== X-Gm-Message-State: AFqh2kq5g7i1nbdugRjQXAVuhJFLe17rnvhO+1eMFNHSs9bxGufrCV0B adlV67w0Eg3JVI/W7YRJQLTPUQ== X-Received: by 2002:a17:906:644f:b0:877:6549:bb6 with SMTP id l15-20020a170906644f00b0087765490bb6mr27947745ejn.58.1674676267325; Wed, 25 Jan 2023 11:51:07 -0800 (PST) Received: from blmsp.fritz.box ([2001:4091:a247:815f:ef74:e427:628a:752c]) by smtp.gmail.com with ESMTPSA id s15-20020a170906454f00b00872c0bccab2sm2778830ejq.35.2023.01.25.11.51.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Jan 2023 11:51:06 -0800 (PST) From: Markus Schneider-Pargmann To: Marc Kleine-Budde , Chandrasekar Ramakrishnan , Wolfgang Grandegger Cc: Vincent MAILHOL , linux-can@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Markus Schneider-Pargmann Subject: [PATCH v2 03/18] can: m_can: Remove repeated check for is_peripheral Date: Wed, 25 Jan 2023 20:50:44 +0100 Message-Id: <20230125195059.630377-4-msp@baylibre.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230125195059.630377-1-msp@baylibre.com> References: <20230125195059.630377-1-msp@baylibre.com> MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1756025402164025057?= X-GMAIL-MSGID: =?utf-8?q?1756025402164025057?= Merge both if-blocks to fix this. Signed-off-by: Markus Schneider-Pargmann --- drivers/net/can/m_can/m_can.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/can/m_can/m_can.c b/drivers/net/can/m_can/m_can.c index 8ccf20f093f8..33abe938c30b 100644 --- a/drivers/net/can/m_can/m_can.c +++ b/drivers/net/can/m_can/m_can.c @@ -1592,10 +1592,8 @@ static int m_can_close(struct net_device *dev) cdev->tx_skb = NULL; destroy_workqueue(cdev->tx_wq); cdev->tx_wq = NULL; - } - - if (cdev->is_peripheral) can_rx_offload_disable(&cdev->offload); + } close_candev(dev);