From patchwork Wed Jan 25 18:54:00 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Song Liu X-Patchwork-Id: 48265 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp434144wrn; Wed, 25 Jan 2023 10:59:41 -0800 (PST) X-Google-Smtp-Source: AMrXdXvXzpmJfmrrFZUStsPq0bX6Dxk9N86K2xaqK26I8z8qOOPL8DzRjpqX0gfvTl6wr8MieEQz X-Received: by 2002:a17:907:3ea9:b0:7ff:727f:65cb with SMTP id hs41-20020a1709073ea900b007ff727f65cbmr42108930ejc.19.1674673181582; Wed, 25 Jan 2023 10:59:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674673181; cv=none; d=google.com; s=arc-20160816; b=mlVwNnqih9DFEHI6+NTLGAtoyjF917tt4PIEdq8SPj7R3Udld1+B4KZmZENCKGOi3E gR/afA9o4+XsqRv0azrt0ftyCRtraeMOKbSPHQ4eC/Z9u6ZlMR4oracqCh5ON74gJzwm JccY7kWHiIx2DvSvptLnoYf4NH8b6LJPaL1FHf4V2rD+Mo2fbHOGHqUtcgxI/Ay1dgQT oZvOk/ng3sOI/04r6/fyoZAVo4FEh5EFBR2N7oliZeNiOpibHMlgzAPM9ZmMMRnHnGVc q9Ow5EB7gcI6+G72szfHz4Nner+P/vW+KEOIVkaLtoJwcGDUtT4zlG/OHQYr2JtmY7pf xjcQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=dKDOr+3yXgOgq+iOQfVx+ANrs3jwKUhz1wj9fN6olD4=; b=A9t5M5RVumlXRArwjmuNhbrzQT/c99Q7LiD0HzH2pIY2pgZUS3LYb8oPrs4lEeFR6d X6WKXtbXfXb0jIlzcETzPxW5VtvcrqzUr5bWhzdzRp5E1D+XoHYTYO6pc5NbE4hp1vI5 XxXLWM9l7kxEsZ+udVhH48T+7pPdP96gndOJFxKzVNJ3ObCxD1B++XsOVy2yAUDiGxo2 UbD8P8JG3G7JbSXUdURdvRiqvUBjYT3wys6mZ+uhX31Nh7pitwRYY8unf1mmM1AqjTze sM7gzoGN7K1fKknAb94l6yDp7xfynRbU0Lfx8UVUtI9n/F/egyTtOo3Uw+Zqljkajzto NUvA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id gj22-20020a170907741600b0087760e3018bsi6227451ejc.967.2023.01.25.10.59.18; Wed, 25 Jan 2023 10:59:41 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235712AbjAYSzD convert rfc822-to-8bit (ORCPT + 99 others); Wed, 25 Jan 2023 13:55:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46794 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235697AbjAYSzA (ORCPT ); Wed, 25 Jan 2023 13:55:00 -0500 Received: from mx0b-00082601.pphosted.com (mx0b-00082601.pphosted.com [67.231.153.30]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 00186C15A for ; Wed, 25 Jan 2023 10:54:59 -0800 (PST) Received: from pps.filterd (m0109331.ppops.net [127.0.0.1]) by mx0a-00082601.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 30PGPjQU019302 for ; Wed, 25 Jan 2023 10:54:59 -0800 Received: from mail.thefacebook.com ([163.114.132.120]) by mx0a-00082601.pphosted.com (PPS) with ESMTPS id 3najv1qt5m-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Wed, 25 Jan 2023 10:54:59 -0800 Received: from twshared16996.15.frc2.facebook.com (2620:10d:c085:208::11) by mail.thefacebook.com (2620:10d:c085:21d::4) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.17; Wed, 25 Jan 2023 10:54:57 -0800 Received: by devbig932.frc1.facebook.com (Postfix, from userid 4523) id 65B4C1469A25A; Wed, 25 Jan 2023 10:54:48 -0800 (PST) From: Song Liu To: , , CC: , Song Liu , Josh Poimboeuf , Petr Mladek Subject: [PATCH v11 1/2] x86/module: remove unused code in __apply_relocate_add Date: Wed, 25 Jan 2023 10:54:00 -0800 Message-ID: <20230125185401.279042-1-song@kernel.org> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 X-FB-Internal: Safe X-Proofpoint-GUID: fbMq_g4eyq7aPdPwM8aejIn-BH-m8SQz X-Proofpoint-ORIG-GUID: fbMq_g4eyq7aPdPwM8aejIn-BH-m8SQz X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.122.1 definitions=2023-01-25_12,2023-01-25_01,2022-06-22_01 X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1756022105917505316?= X-GMAIL-MSGID: =?utf-8?q?1756022105917505316?= This "#if 0" block has been untouched for many years. Remove it to clean up the code. Suggested-by: Josh Poimboeuf Signed-off-by: Song Liu Reviewed-by: Petr Mladek Acked-by: Josh Poimboeuf Reviewed-by: Joe Lawrence --- arch/x86/kernel/module.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/arch/x86/kernel/module.c b/arch/x86/kernel/module.c index 705fb2a41d7d..1dee3ad82da2 100644 --- a/arch/x86/kernel/module.c +++ b/arch/x86/kernel/module.c @@ -188,10 +188,6 @@ static int __apply_relocate_add(Elf64_Shdr *sechdrs, goto invalid_relocation; val -= (u64)loc; write(loc, &val, 4); -#if 0 - if ((s64)val != *(s32 *)loc) - goto overflow; -#endif break; case R_X86_64_PC64: if (*(u64 *)loc != 0)