From patchwork Wed Jan 25 16:18:32 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steven Rostedt X-Patchwork-Id: 48209 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp363233wrn; Wed, 25 Jan 2023 08:26:26 -0800 (PST) X-Google-Smtp-Source: AMrXdXvOtCKgjpN10h7/p4artQpG0BVYHgyOWjHz6gN9Lq89pS7VvRrLJ++r2xB3bVaEZonjQV00 X-Received: by 2002:a17:907:7f12:b0:7c1:9eb:845b with SMTP id qf18-20020a1709077f1200b007c109eb845bmr59092929ejc.16.1674663986361; Wed, 25 Jan 2023 08:26:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674663986; cv=none; d=google.com; s=arc-20160816; b=NQ9GCBeqdgoftXxpPjaOa/I4l39jcic2VRvndyq066y6WM79ZFg+P+CveOIYtSvj+D QIO0YOVGynWuhxziXa8NYOarBiij9d1d/T7MbXEnl3YW1Y4BcauC0XeRhd0xR61mPhNo faFczEjbGoPJkDLnRbI8fzPLkllBSLMH3iT/5n3aBuv7VrcTHGiaaCZwKhvapeYpzLy/ o8eBnolN3+djjWOeCBoEYKps8kMvEsqPZst5OnYCOruQaI/blGoZkPkfJBdCLo7+HfGt /YBYQifdiZ8sIapG0kDkbU3icSyQUTZDmVbdcCDKXGWsdcWR3xc8vakw0Up8xN1o6YTv Dzfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:subject:cc:to:from:date :user-agent:message-id; bh=kniFR/mNV9rDYLkxbpvk9v8MQDL4sRex9cgdx6CtBEQ=; b=nDK5t7yxW6oy69dr4VCyAyObu64lcEKUqgWkxUYp6tAGYy9k95E/pePl8YNvJ2SVTq 8GDS9/n13RMT7a9YScn4t10ULsZ0+N7BuPyDaxDI42ojbKFWaQvE5yEkV76//06yVuyi hCND4sx/W3lBtOAKuqwCqRbEspa6KWSWenGBm/thoQwq4RkVCxuCiZCjN1hUFnvLm2OC 7PxpCFV+W0Dt9nE5ymV59p3OWcV705NKbndZ0IwTpfjStfycJZBXmonkjLJD00eYV9T1 6hX5HG+lWBklCG0dm5wmIaDZNY9PzbdEi11DYpidpEn27f4uXX5tdBhbcyEQp12FqU/v sicw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id up28-20020a170907cc9c00b00877e0202816si6549652ejc.122.2023.01.25.08.26.02; Wed, 25 Jan 2023 08:26:26 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235961AbjAYQUn (ORCPT + 99 others); Wed, 25 Jan 2023 11:20:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52338 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235762AbjAYQUQ (ORCPT ); Wed, 25 Jan 2023 11:20:16 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D79C016AD7 for ; Wed, 25 Jan 2023 08:20:14 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 7E0CAB81ACE for ; Wed, 25 Jan 2023 16:20:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3F51AC433AE; Wed, 25 Jan 2023 16:20:12 +0000 (UTC) Received: from rostedt by gandalf.local.home with local (Exim 4.96) (envelope-from ) id 1pKiVP-004MuB-1M; Wed, 25 Jan 2023 11:20:11 -0500 Message-ID: <20230125162011.241146323@goodmis.org> User-Agent: quilt/0.66 Date: Wed, 25 Jan 2023 11:18:32 -0500 From: Steven Rostedt To: linux-kernel@vger.kernel.org Cc: Masami Hiramatsu , Andrew Morton , Randy Dunlap Subject: [for-linus][PATCH 08/11] tracing/filter: fix kernel-doc warnings References: <20230125161824.332648375@goodmis.org> MIME-Version: 1.0 X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1756012464363929141?= X-GMAIL-MSGID: =?utf-8?q?1756012464363929141?= From: Randy Dunlap Use the 'struct' keyword for a struct's kernel-doc notation and use the correct function parameter name to eliminate kernel-doc warnings: kernel/trace/trace_events_filter.c:136: warning: cannot understand function prototype: 'struct prog_entry ' kerne/trace/trace_events_filter.c:155: warning: Excess function parameter 'when_to_branch' description in 'update_preds' Also correct some trivial punctuation problems. Link: https://lkml.kernel.org/r/20230108021238.16398-1-rdunlap@infradead.org Signed-off-by: Randy Dunlap Signed-off-by: Steven Rostedt (Google) --- kernel/trace/trace_events_filter.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/kernel/trace/trace_events_filter.c b/kernel/trace/trace_events_filter.c index 96acc2b71ac7..e095c3b3a50d 100644 --- a/kernel/trace/trace_events_filter.c +++ b/kernel/trace/trace_events_filter.c @@ -128,7 +128,7 @@ static bool is_not(const char *str) } /** - * prog_entry - a singe entry in the filter program + * struct prog_entry - a singe entry in the filter program * @target: Index to jump to on a branch (actually one minus the index) * @when_to_branch: The value of the result of the predicate to do a branch * @pred: The predicate to execute. @@ -140,16 +140,16 @@ struct prog_entry { }; /** - * update_preds- assign a program entry a label target + * update_preds - assign a program entry a label target * @prog: The program array * @N: The index of the current entry in @prog - * @when_to_branch: What to assign a program entry for its branch condition + * @invert: What to assign a program entry for its branch condition * * The program entry at @N has a target that points to the index of a program * entry that can have its target and when_to_branch fields updated. * Update the current program entry denoted by index @N target field to be * that of the updated entry. This will denote the entry to update if - * we are processing an "||" after an "&&" + * we are processing an "||" after an "&&". */ static void update_preds(struct prog_entry *prog, int N, int invert) {