From patchwork Tue Apr 4 16:26:49 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Cormier X-Patchwork-Id: 79233 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp10600vqo; Tue, 4 Apr 2023 09:33:27 -0700 (PDT) X-Google-Smtp-Source: AKy350aXVB+4wPHa9VaUbkE8FVU/NH9D9Gz5MeLgdPMvmPU1yK3x7w54CrMMyunkM/2r/I3RtJvs X-Received: by 2002:a17:906:c2c6:b0:931:95a1:a05a with SMTP id ch6-20020a170906c2c600b0093195a1a05amr118769ejb.62.1680626007315; Tue, 04 Apr 2023 09:33:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680626007; cv=none; d=google.com; s=arc-20160816; b=g+ELQAbn1R7pkYKl94G7c+OWtQA4ZNBhVS1wOBfUZlAwA8fetOe8f67z7u9ztICfBg bJHkrSQgKGxlsHukQ8NFHVvDRWlN2gQMgetdaKWoVJY4ADizZVhHj7Ft7PxG9KER76q8 CVKfua/BOiZHvZ3k9DBAhC8uY5hroGx4n0J8yCHVU2w4ADwEf3H//ldCzNOuuHmmayCH zby4gWSPC5cu90SxY4Xf9/4oqshBadOFsfl8U1ru0HFOs5VkhyNpcZAv6Y3Q8DvlgguG ABrh0b5zMT0w4Vr79YxjTiKAdNGiW93lU0YAp69YxkX80LdVFsLM0O4YQAhbmsPXdzDJ FVYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:message-id :content-transfer-encoding:mime-version:subject:date:from :dkim-signature; bh=JhwrIjGdHvbP7iRYz+GF4I68rmmYmSv00IVMxjU1xN8=; b=DIq0dHLWCuK2QjxL4KZC2NFt+S8d5q7ip7j5vRnK+fPU4jjhqNVsRnVJFolNP5WBKG s30w6/um2wkRsBGJwQdIVpFb0c/9Iwg3+utkIcK6xkSPfhLptw1wnbA3fbFjPqQuxMEs oeJM2qGBbcxebiGlrMZZbQUvyMW9hcQuIy+guUnCpySs5CxZ1paLwaU7tenPWAYvA85g kZ4G9Ro+Geu26tCkhMqQwSLhWLfX/lSIt/cwA6Z6URAUW/DjIqEyrGDFnzcp0D/Zz2W7 LYsRSSqpA6G1XbJsnPPCIrGNS15ziyLyA7QEh/oCd0MuC6aXCDgCYdDXF2B7JhmiwA+0 2zDg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@criticallink.com header.s=google header.b=ZtCNBHqK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=criticallink.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a15-20020a1709063a4f00b00932f1463036si298202ejf.283.2023.04.04.09.33.03; Tue, 04 Apr 2023 09:33:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@criticallink.com header.s=google header.b=ZtCNBHqK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=criticallink.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235705AbjDDQ12 (ORCPT + 99 others); Tue, 4 Apr 2023 12:27:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59468 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235521AbjDDQ10 (ORCPT ); Tue, 4 Apr 2023 12:27:26 -0400 Received: from mail-qt1-x834.google.com (mail-qt1-x834.google.com [IPv6:2607:f8b0:4864:20::834]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7E3F049FE for ; Tue, 4 Apr 2023 09:27:19 -0700 (PDT) Received: by mail-qt1-x834.google.com with SMTP id r5so32092089qtp.4 for ; Tue, 04 Apr 2023 09:27:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=criticallink.com; s=google; t=1680625638; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=JhwrIjGdHvbP7iRYz+GF4I68rmmYmSv00IVMxjU1xN8=; b=ZtCNBHqKs8v2GxHBkp3iZsN1/Aj4WowcQaeTkud3ULyCdCXRN3419nTF4lYEw7JCVm lINN0tC7Q3eUE2If0tAq2MSpjL3+GB+oggPts/3PIm9kmHzBQEU9c7kqq3FhS+KRW7Pj g2zyaBRKwGVb22cEq8jh1O0D4XyxUuP42v+0HT5FeQ5Gi/67Rx5mNT0rEesrbN1OoTtw 4LWx2qQ8AJ+0p7cbYKm+9+AhMpibKe3nsn4MBkTLdnmS88PGkjgLw7rSDd51LadmyAW6 8J+ZXzFFxtlb4xt8nqoqw1+dV6pjLDjwGxbjGFJCDQLBjEOH+X3KeHS+rJbfRog0UUSX si+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680625638; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JhwrIjGdHvbP7iRYz+GF4I68rmmYmSv00IVMxjU1xN8=; b=X9WYnUvLXc9ioYhRTz0++CxneF+9GfxWPs/7GhdcaQAQZlIsOayW4RrMfqAh9nc2fV s51zDPQfOJIUpuwQ8+ZiT0SEygbxs3Vq6KkUTRgk98bB0U1TCIp3LKF/fKi8EFoVBSjh iyJMR2TtAa2RsxVRBKEuiNEns0+AgvibiJxLT758XUFYYf8gnpC6FXKVKNHxWlShXjed 58suN6q2CRkSky0tL3u0/j+mRHR/1XSHBQ+CdQjlknbrlJN5p3r6Ikx6VD9r/jVvQ8p1 51POiJgY8ZjpYrJ16zbKuRW2IlYxYJxBE5pjDvixMK1T1LJygGiaW3JXogvBs+ZcgOXM 1yAA== X-Gm-Message-State: AAQBX9daD/dDZWAPPOuy89JsvoU+Q4yPScpAvlaaA743sVXpiL+ftHJt bULKiladcdXQXWFTca6iUkkVCQ== X-Received: by 2002:ac8:57c3:0:b0:3e3:86d0:4ef8 with SMTP id w3-20020ac857c3000000b003e386d04ef8mr37879614qta.28.1680625638589; Tue, 04 Apr 2023 09:27:18 -0700 (PDT) Received: from [127.0.1.1] (static-72-90-70-109.syrcny.fios.verizon.net. [72.90.70.109]) by smtp.gmail.com with ESMTPSA id m124-20020a375882000000b0073b8745fd39sm3699594qkb.110.2023.04.04.09.27.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Apr 2023 09:27:12 -0700 (PDT) From: Jonathan Cormier Date: Tue, 04 Apr 2023 12:26:49 -0400 Subject: [PATCH v4 2/3] drm/bridge: tfp410: Fix logic to configured polled HPD MIME-Version: 1.0 Message-Id: <20230125-tfp410_i2c-v4-2-f983bcef2df8@criticallink.com> References: <20230125-tfp410_i2c-v4-0-f983bcef2df8@criticallink.com> In-Reply-To: <20230125-tfp410_i2c-v4-0-f983bcef2df8@criticallink.com> To: Andrzej Hajda , Neil Armstrong , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Michael Williamson , Bob Duke , Jonathan Cormier X-Mailer: b4 0.12.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1161; i=jcormier@criticallink.com; h=from:subject:message-id; bh=thTBke4adSbjQB+Az7ku6gTKJI14U3xmvadZhGFOYMw=; b=owEBbQKS/ZANAwAKAdzX/S4LNuuqAcsmYgBkLE/YIu6HYilZxFWf+fAQXGrPc3NZJOHfU8IajFHX +WG0356JAjMEAAEKAB0WIQT/MozqCeZtYxNnVN/c1/0uCzbrqgUCZCxP2AAKCRDc1/0uCzbrqtx8D/ 9eYQrGQHYfDwF38dKrsTbYYGWQkO9RbvLizz2zK6sPjERuElcIyHb1tc87UgrdMz6oVwFvAf9gPSol mWEUPGff0hIoNlzeZtDvh+c33wxgQXejInX2eBcPryiU6jOsiQBbutNh9EKRBGa4vDDrxq/UfUiItn dHTY0jqxh+gSfWV7bWg0wMankS65kJtnm/wcNit00TMdbrYzjhmNnV9aLsZs2cXRG8InRC7w3db/Hc pwi7YQ2/AHR6YKnqvhOM7KTqWb9v2orkiFN6q9zZhaeEwWWgl0tBOR/OfGbdPfkE2uxbVdrAvWyc5Q aqd02xIaWKKqxIF2DJx4akESDUex5zzNb0w3wL5+PPenTYcbaHs1tMfvsO7Cgt+Bm5GDstY3BYtT+j ij8oaqxmJkK8++3tHCexC/uayQi7sExzN/5P7shgKGbIoi23AkiKjNw7tZ65lA6Vrh+nSNPMMbWVZb 34datHiI6xJ+spdB0tCALG/SD1s5ImkUXEozuXbh3d2pdZAo/0SOXfr4rYZxP0b1pWG1mUScY+5vcU Jm8dWe7KOOxB5DHu0GyzWskm69pu+ZPwUNDdCiYpgU2tBvTtvu4UIy0dwGcOenxLksEnFvjyET1yNV tfsUEG65wcUY0k1RqNwXJ7yJd6lOEoS9OBb14yEkjxebzUiOGI0Hgo275XOA== X-Developer-Key: i=jcormier@criticallink.com; a=openpgp; fpr=FF328CEA09E66D63136754DFDCD7FD2E0B36EBAA X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1762264096210596474?= X-GMAIL-MSGID: =?utf-8?q?1762264096210596474?= From: Michael Williamson The logic to configure polling (vs async/irq notification) of hot-plug events was not correct. If the connected bridge requires polling, then inform the upstream bridge we also require polling. Fixes: 5cafa0f1853b ("drm/bridge: tfp410: Replace manual connector handling with bridge") Signed-off-by: Michael Williamson Reviewed-by: Neil Armstrong Signed-off-by: Jonathan Cormier --- drivers/gpu/drm/bridge/ti-tfp410.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/ti-tfp410.c b/drivers/gpu/drm/bridge/ti-tfp410.c index bb3f8d0ff207..41007d05d584 100644 --- a/drivers/gpu/drm/bridge/ti-tfp410.c +++ b/drivers/gpu/drm/bridge/ti-tfp410.c @@ -155,7 +155,7 @@ static int tfp410_attach(struct drm_bridge *bridge, return -ENODEV; } - if (dvi->next_bridge->ops & DRM_BRIDGE_OP_DETECT) + if (dvi->next_bridge->ops & DRM_BRIDGE_OP_HPD) dvi->connector.polled = DRM_CONNECTOR_POLL_HPD; else dvi->connector.polled = DRM_CONNECTOR_POLL_CONNECT | DRM_CONNECTOR_POLL_DISCONNECT;