[v3,2/2] dt-bindings: display: simple-framebuffer: Document physical width and height properties

Message ID 20230124224142.7133-3-rayyan@ansari.sh
State New
Headers
Series SimpleDRM: allow configuring physical width and height |

Commit Message

Rayyan Ansari Jan. 24, 2023, 10:41 p.m. UTC
  Document the optional width-mm and height-mm simple-framebuffer
properties.

Signed-off-by: Rayyan Ansari <rayyan@ansari.sh>
---
 .../devicetree/bindings/display/simple-framebuffer.yaml     | 6 ++++++
 1 file changed, 6 insertions(+)
  

Comments

Krzysztof Kozlowski Jan. 25, 2023, 7:29 a.m. UTC | #1
On 24/01/2023 23:41, Rayyan Ansari wrote:
> Document the optional width-mm and height-mm simple-framebuffer
> properties.

As pointed in previous discussion - you should have panel node and take
the properties from it. The physical dimensions are not properties of
framebuffer device. These are properties of panel.

Best regards,
Krzysztof
  

Patch

diff --git a/Documentation/devicetree/bindings/display/simple-framebuffer.yaml b/Documentation/devicetree/bindings/display/simple-framebuffer.yaml
index dd64f70b5014..4ae33a4d2da9 100644
--- a/Documentation/devicetree/bindings/display/simple-framebuffer.yaml
+++ b/Documentation/devicetree/bindings/display/simple-framebuffer.yaml
@@ -106,6 +106,12 @@  properties:
       - x2r10g10b10
       - x8r8g8b8
 
+  width-mm:
+    description: Physical width of the display in millimetres
+
+  height-mm:
+    description: Physical height of the display in millimetres
+
   display:
     $ref: /schemas/types.yaml#/definitions/phandle
     description: Primary display hardware node