From patchwork Tue Jan 24 21:01:05 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Kaiser X-Patchwork-Id: 47892 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp2374116wrn; Tue, 24 Jan 2023 13:08:37 -0800 (PST) X-Google-Smtp-Source: AMrXdXshMI3WY81qA1OFWjwJdoac2bUVvaNM0+ico3szpG1v5hrWEYT6fYciouj+2P8q1nEsMbNZ X-Received: by 2002:a17:906:6d0b:b0:871:818e:6e9 with SMTP id m11-20020a1709066d0b00b00871818e06e9mr32559362ejr.64.1674594517466; Tue, 24 Jan 2023 13:08:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674594517; cv=none; d=google.com; s=arc-20160816; b=d7c7+aCDWhlAx9hs4+KKj325EoHiFIe6F52roTRguotj216y6eu9ZEBCWPyZhjG//E PZn8UoN+9nZgbTXHkDFMmYokOzvZPWgnt9BYiJHLhi3FuzHePKfcUmqAL8dIqiY7CNLL IFxKInD4Nnsmul7IlsTkX0dBLENMNn0BTlogOQiWCNkrkTfHqKzQqQikPN9ae94chbrP BBWhMFJRowRjxPyowtopC94tz2uIUlJUB6Ro2AQ15K++muglhA7nbeNJ6TsYwkRIFyFm M2voiDzrSydOXZPbxN8Iao+zNYvtQpzr5rjdUOWQ0BxfiHCdLWwzHX6rvKCQ3I4T/xRl JDTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=3WE8PWwKgGTMs19lNlFrAIt1Ie+mz8VD8oImQDD2cyk=; b=OWGSo2REikBEALxf4ySwtM82GcrY61hlJtMdBa88pSy6eLxixMB5EIYsrD/iwf5QRb beJ8xjP6Gb0LsEthIm+rbP3lJqOKhbwik5np8qNWmEzzggS0BS0Mv3siB1qj3hZhu+5O 39CTZq2NlGioYwbwgIvgoQL5drUcaaFQo34b7t0pqbkemhiYutM7G01JGVoL6v7YrSSh JKRrMZeAZnLJ4cnApa/yQcFneElcjzM+3DkhxnPX9ohAawWF82frnbAI4doHKWaWqhYx KzFAqIZ1EgmNGywr6hMnbjOgze3rqC9NUPP9ujvesJHNfcgRnHak2xb6GRkcWwg/qC+s mzng== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id gi33-20020a1709070ca100b0087752be1dcasi3335368ejc.914.2023.01.24.13.08.10; Tue, 24 Jan 2023 13:08:37 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234565AbjAXVBe (ORCPT + 99 others); Tue, 24 Jan 2023 16:01:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33580 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229747AbjAXVBd (ORCPT ); Tue, 24 Jan 2023 16:01:33 -0500 Received: from viti.kaiser.cx (viti.kaiser.cx [IPv6:2a01:238:43fe:e600:cd0c:bd4a:7a3:8e9f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C6C5041B6B for ; Tue, 24 Jan 2023 13:01:31 -0800 (PST) Received: from dslb-188-096-139-204.188.096.pools.vodafone-ip.de ([188.96.139.204] helo=martin-debian-2.paytec.ch) by viti.kaiser.cx with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1pKQQ1-0001xR-1C; Tue, 24 Jan 2023 22:01:25 +0100 From: Martin Kaiser To: Greg Kroah-Hartman Cc: Larry Finger , Phillip Potter , Michael Straube , Pavel Skripkin , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Martin Kaiser Subject: [PATCH 1/4] staging: r8188eu: usb_read_port_complete needs no regs parameter Date: Tue, 24 Jan 2023 22:01:05 +0100 Message-Id: <20230124210108.62170-2-martin@kaiser.cx> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230124210108.62170-1-martin@kaiser.cx> References: <20230124210108.62170-1-martin@kaiser.cx> MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1755939620305111983?= X-GMAIL-MSGID: =?utf-8?q?1755939620305111983?= Remove the regs parameter from usb_read_port_complete, it is not used. Without the regs parameter, there's no need for the define that makes usb_read_port_complete usable as urb callback function. Signed-off-by: Martin Kaiser --- drivers/staging/r8188eu/hal/usb_ops_linux.c | 2 +- drivers/staging/r8188eu/include/usb_ops_linux.h | 2 -- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/r8188eu/hal/usb_ops_linux.c b/drivers/staging/r8188eu/hal/usb_ops_linux.c index e122c8ca929c..0f789d5250db 100644 --- a/drivers/staging/r8188eu/hal/usb_ops_linux.c +++ b/drivers/staging/r8188eu/hal/usb_ops_linux.c @@ -344,7 +344,7 @@ void rtl8188eu_recv_tasklet(unsigned long priv) } } -static void usb_read_port_complete(struct urb *purb, struct pt_regs *regs) +static void usb_read_port_complete(struct urb *purb) { struct recv_buf *precvbuf = (struct recv_buf *)purb->context; struct adapter *adapt = (struct adapter *)precvbuf->adapter; diff --git a/drivers/staging/r8188eu/include/usb_ops_linux.h b/drivers/staging/r8188eu/include/usb_ops_linux.h index e406a1fccda7..0a8fefbd4c2e 100644 --- a/drivers/staging/r8188eu/include/usb_ops_linux.h +++ b/drivers/staging/r8188eu/include/usb_ops_linux.h @@ -19,8 +19,6 @@ usb_bulkout_zero_complete(purb) #define usb_write_mem_complete(purb, regs) \ usb_write_mem_complete(purb) -#define usb_read_port_complete(purb, regs) \ - usb_read_port_complete(purb) #define usb_read_interrupt_complete(purb, regs) \ usb_read_interrupt_complete(purb)