From patchwork Tue Jan 24 17:01:03 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Howells X-Patchwork-Id: 47785 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp2269303wrn; Tue, 24 Jan 2023 09:12:03 -0800 (PST) X-Google-Smtp-Source: AK7set+EMYnekvcHbtdlcCyxPW45pHYJUui2rBvOsxXdnjLQGPw4efIPPy2LQQC6E9xS07kTqGN0 X-Received: by 2002:a17:90b:4c8d:b0:22c:43:714f with SMTP id my13-20020a17090b4c8d00b0022c0043714fmr532445pjb.7.1674580323231; Tue, 24 Jan 2023 09:12:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674580323; cv=none; d=google.com; s=arc-20160816; b=jlVAQ2nCoM0FtMPohHpFceIk2plnMfGy980ez/nWej1kjePZu1NubOwvp34QsDYdRo xHAC90gYIT2IVQdYuZm3ApafUEoZezCSeeMpMmWaUFEViYaccjQ/gchteJy2tIcwOONf H3mXKLC8wMwHwhjpOTqhlaxwiYpoNLcl53PmfV/2NWYK1m54/auOppQDQGnYL1xrgI20 A/VqEEhkVDW28AQG3XRFKasagw9tEikaDdt/qTKb/tl50mL0nnu75uLDyJNMokx8f1NQ Hfhb0MsXE0H6DTXvl9rGT+mzhnrj66VzE+XoewOk6RmjW/V5MqTzUAB6Tckq+Nc7W4ua CTBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=0nUSebggWm9hllLA5YvTDCn+df0UDsKPYU6rFIiSb24=; b=tFu/vUP9V3S3kijiwfl6ljLcoUyrmN4HiXhwwjkd8Yyvwxchre0c3wplpz2HOwGMK/ ShofWvPUD5WXFHlM2INZfHHo/tXov7XnEN7C+7zaGVlpLF9Rw9O4TzE+s75Xs0b2pZ/d wMIcN6jOzCUThwcG6wv6d2aEoWE6Ym0dR/ADA8vujEoJTY/AiuaiM0OIp8kCu+BBNkaW uPueVOFRQUqh5rOB32org+3E6msOs2Tbh7C9gEhykMG4/tQ0h0TE837jGiCSjEKyxBSb 96AtRFTUbQ6WaKBsGK78g41jx1DuYiA976K25r1MdvjvKDPV97OER4iD1nKOuuiZqhLZ d+vQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=RW20oKLr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o11-20020a17090ac70b00b00228cb3af4aasi15577628pjt.99.2023.01.24.09.11.51; Tue, 24 Jan 2023 09:12:03 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=RW20oKLr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234667AbjAXRC6 (ORCPT + 99 others); Tue, 24 Jan 2023 12:02:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34880 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234653AbjAXRCf (ORCPT ); Tue, 24 Jan 2023 12:02:35 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 871F948623 for ; Tue, 24 Jan 2023 09:01:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674579702; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0nUSebggWm9hllLA5YvTDCn+df0UDsKPYU6rFIiSb24=; b=RW20oKLrtrPoUKjjy5xiTD80oWKcsqLq8RKH4snzwlTJ9u8benLGUP33txPWD5ztYZfPK7 McSA7e3NzlllhdFgo4yjDv19J3O+11lMqysYSUI37xjU1T/8DadsaKx262UqLRZR61GCCP epaXSiH746ocDJFENxeG+F42Vl46qVk= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-658-f6AYk3koMpGXfVMWN98DXQ-1; Tue, 24 Jan 2023 12:01:39 -0500 X-MC-Unique: f6AYk3koMpGXfVMWN98DXQ-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id AE9B43C18342; Tue, 24 Jan 2023 17:01:38 +0000 (UTC) Received: from warthog.procyon.org.uk.com (unknown [10.33.36.97]) by smtp.corp.redhat.com (Postfix) with ESMTP id DF7FBC15BA0; Tue, 24 Jan 2023 17:01:25 +0000 (UTC) From: David Howells To: Al Viro , Christoph Hellwig Cc: David Howells , Matthew Wilcox , Jens Axboe , Jan Kara , Jeff Layton , David Hildenbrand , Jason Gunthorpe , Logan Gunthorpe , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v9 3/8] iomap: Don't get an reference on ZERO_PAGE for direct I/O block zeroing Date: Tue, 24 Jan 2023 17:01:03 +0000 Message-Id: <20230124170108.1070389-4-dhowells@redhat.com> In-Reply-To: <20230124170108.1070389-1-dhowells@redhat.com> References: <20230124170108.1070389-1-dhowells@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1755924737038684970?= X-GMAIL-MSGID: =?utf-8?q?1755924737038684970?= ZERO_PAGE can't go away, no need to hold an extra reference. Signed-off-by: David Howells Reviewed-by: David Hildenbrand Reviewed-by: John Hubbard --- fs/iomap/direct-io.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/iomap/direct-io.c b/fs/iomap/direct-io.c index 9804714b1751..47db4ead1e74 100644 --- a/fs/iomap/direct-io.c +++ b/fs/iomap/direct-io.c @@ -202,7 +202,7 @@ static void iomap_dio_zero(const struct iomap_iter *iter, struct iomap_dio *dio, bio->bi_private = dio; bio->bi_end_io = iomap_dio_bio_end_io; - get_page(page); + bio_set_flag(bio, BIO_NO_PAGE_REF); __bio_add_page(bio, page, len, 0); iomap_dio_submit_bio(iter, dio, bio, pos); }