From patchwork Tue Jan 24 02:38:28 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eric Van Hensbergen X-Patchwork-Id: 47500 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp1931358wrn; Mon, 23 Jan 2023 18:42:29 -0800 (PST) X-Google-Smtp-Source: AMrXdXub3XRCdhTYxcFwqvubdUSxsDYCSjtuZrd35X2ZT0uwbvCg2zBP9Qv1IhKp0yJlnR328abO X-Received: by 2002:a17:902:cf0c:b0:192:835d:c861 with SMTP id i12-20020a170902cf0c00b00192835dc861mr30991780plg.68.1674528149253; Mon, 23 Jan 2023 18:42:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674528149; cv=none; d=google.com; s=arc-20160816; b=b24hK7cG6zkvBu2DlHupMQ8PNs3m75O1llOH1Gbf6Cc7DdA7fr5XWchO8u6vqJltc/ 1/oHi6CFIqGqtzSI8JixQj/kzKNNy8cd4MdMhSX7iQZIZPTT+8O+KpQQT7AFoI250YYC xD5RGNBkQ2FA70ksnKv9MSte7gOkHiN+50Nn/fVRULJL7R8wa4ioSkr0zbtkjmEMUMtH oCdDIDwn4kqEodvKEVtKBwIuCmy/DQyZ4Qv9iP5nyobz6pAA/0yt4BelNv0ZnNTG4LqF jfkw7YZA4vpDw1zDWVyK2wlFgRaNKeHSBNoTUohz3liOia0AtQySbrWaacrD+Ja7vdVI ZO0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=wVUapmqnjZ7wsAx0m6Gx0Mc85WnVc0CijwHDY53WOQs=; b=w8+kFzL9pCJowKgEuz/3ntKyOlw78kpJi7Lbn28D9xnslKbKtMs0x+CsK6RXH4aiS+ uiUmP0tS7mEzdEVRqCBUU5KgrGrX7A4C3ckTdFHH3gFByE4Dng+hBgDzXxoeuTd6O31y YXF9NBNuUlIqFTL8YofwwuzCrE88xuYcdWfm7mdEvVUpMJwcvi9NSOgUUREf3iXoTI6v 4eDVpFEr763T7P2TonEJblFODK+XcerSkk8/5s1scUjfvojznEz9DnlIwsGZleBM5xQ0 IonSdNB45q6jtR0sGZ/LKKQzKlAcGx+xYPlOU/J26voZpI7bTL4MX7qZYdNrhNPazNGT DG9A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=RHCcAWAr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m1-20020a170902bb8100b00195e52c77b2si1047391pls.411.2023.01.23.18.42.17; Mon, 23 Jan 2023 18:42:29 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=RHCcAWAr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232517AbjAXCj3 (ORCPT + 99 others); Mon, 23 Jan 2023 21:39:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53732 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232149AbjAXCjP (ORCPT ); Mon, 23 Jan 2023 21:39:15 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 00A9C36683; Mon, 23 Jan 2023 18:39:13 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 85729611B5; Tue, 24 Jan 2023 02:39:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1AA6BC433EF; Tue, 24 Jan 2023 02:39:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1674527952; bh=9zTXmROnUui0sVsVPrKS01wGDaTFTG/Ge1FznKcEYuY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=RHCcAWAr5tinfwi81brnT/kVfOqaudynDJJnfBELaVugND2FC6lX6X4ySN3PZxjsk dZREJIbmtjdjxLB3241CMudQGAW/U/SeyN+sKYcEgP9DBpbI/C+rMGGq3vQwFlMoEd r2pMNBoNQDgdtwpTCLfU9KpcIjnhgPss+9f6aqGMz8XmYRMH+r7ZuTWtL7Kk4Otkik T0u5DdPZ2uG4Vhgtoex26JHlZ9NfGgYYrw6x0wQU3bzSN3B7I5jNd0HpgPbHeowomj IpNSB9ClkH31rdUVDCWZ3X5flQbCse19URASNv0IxsiA5ORGYf9TO5Fyu4mbCyIWzX 3qYQSPRqsS+Ig== From: Eric Van Hensbergen To: v9fs-developer@lists.sourceforge.net, asmadeus@codewreck.org, rminnich@gmail.com, lucho@ionkov.net Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux_oss@crudebyte.com, Eric Van Hensbergen Subject: [PATCH v3 05/11] allow disable of xattr support on mount Date: Tue, 24 Jan 2023 02:38:28 +0000 Message-Id: <20230124023834.106339-6-ericvh@kernel.org> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20230124023834.106339-1-ericvh@kernel.org> References: <20221218232217.1713283-1-evanhensbergen@icloud.com> <20230124023834.106339-1-ericvh@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1752596123728258714?= X-GMAIL-MSGID: =?utf-8?q?1755870028633055352?= xattr creates a lot of additional messages for 9p in the current implementation. This allows users to conditionalize xattr support on 9p mount if they are on a connection with bad latency. Using this flag is also useful when debugging other aspects of 9p as it reduces the noise in the trace files. Signed-off-by: Eric Van Hensbergen --- Documentation/filesystems/9p.rst | 2 ++ fs/9p/v9fs.c | 9 ++++++++- fs/9p/v9fs.h | 3 ++- fs/9p/vfs_super.c | 3 ++- 4 files changed, 14 insertions(+), 3 deletions(-) diff --git a/Documentation/filesystems/9p.rst b/Documentation/filesystems/9p.rst index 7b5964bc8865..0e800b8f73cc 100644 --- a/Documentation/filesystems/9p.rst +++ b/Documentation/filesystems/9p.rst @@ -137,6 +137,8 @@ Options This can be used to share devices/named pipes/sockets between hosts. This functionality will be expanded in later versions. + noxattr do not offer xattr functions on this mount. + access there are four access modes. user if a user tries to access a file on v9fs diff --git a/fs/9p/v9fs.c b/fs/9p/v9fs.c index a46bf9121f11..f8e952c013f9 100644 --- a/fs/9p/v9fs.c +++ b/fs/9p/v9fs.c @@ -38,7 +38,7 @@ enum { /* String options */ Opt_uname, Opt_remotename, Opt_cache, Opt_cachetag, /* Options that take no arguments */ - Opt_nodevmap, + Opt_nodevmap, Opt_noxattr, /* Access options */ Opt_access, Opt_posixacl, /* Lock timeout option */ @@ -55,6 +55,7 @@ static const match_table_t tokens = { {Opt_uname, "uname=%s"}, {Opt_remotename, "aname=%s"}, {Opt_nodevmap, "nodevmap"}, + {Opt_noxattr, "noxattr"}, {Opt_cache, "cache=%s"}, {Opt_cachetag, "cachetag=%s"}, {Opt_access, "access=%s"}, @@ -149,6 +150,9 @@ int v9fs_show_options(struct seq_file *m, struct dentry *root) if (v9ses->flags & V9FS_POSIX_ACL) seq_puts(m, ",posixacl"); + if (v9ses->flags & V9FS_NO_XATTR) + seq_puts(m, ",noxattr"); + return p9_show_client_options(m, v9ses->clnt); } @@ -269,6 +273,9 @@ static int v9fs_parse_options(struct v9fs_session_info *v9ses, char *opts) case Opt_nodevmap: v9ses->nodev = 1; break; + case Opt_noxattr: + v9ses->flags |= V9FS_NO_XATTR; + break; case Opt_cachetag: #ifdef CONFIG_9P_FSCACHE kfree(v9ses->cachetag); diff --git a/fs/9p/v9fs.h b/fs/9p/v9fs.h index 5813967ecdf0..a08cf6618c86 100644 --- a/fs/9p/v9fs.h +++ b/fs/9p/v9fs.h @@ -36,7 +36,8 @@ enum p9_session_flags { V9FS_ACCESS_SINGLE = 0x04, V9FS_ACCESS_USER = 0x08, V9FS_ACCESS_CLIENT = 0x10, - V9FS_POSIX_ACL = 0x20 + V9FS_POSIX_ACL = 0x20, + V9FS_NO_XATTR = 0x40 }; /* possible values of ->cache */ diff --git a/fs/9p/vfs_super.c b/fs/9p/vfs_super.c index 65d96fa94ba2..5fc6a945bfff 100644 --- a/fs/9p/vfs_super.c +++ b/fs/9p/vfs_super.c @@ -64,7 +64,8 @@ v9fs_fill_super(struct super_block *sb, struct v9fs_session_info *v9ses, sb->s_magic = V9FS_MAGIC; if (v9fs_proto_dotl(v9ses)) { sb->s_op = &v9fs_super_ops_dotl; - sb->s_xattr = v9fs_xattr_handlers; + if (!(v9ses->flags & V9FS_NO_XATTR)) + sb->s_xattr = v9fs_xattr_handlers; } else { sb->s_op = &v9fs_super_ops; sb->s_time_max = U32_MAX;