From patchwork Tue Jan 24 02:38:34 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eric Van Hensbergen X-Patchwork-Id: 47501 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp1931627wrn; Mon, 23 Jan 2023 18:43:21 -0800 (PST) X-Google-Smtp-Source: AMrXdXu2vf45uMSLQ/6Y0EMGftnQsfAw5AI+U3bnUi9mTPqu9TLB6mVf/xiWDzjZ7+usEMZKECUi X-Received: by 2002:a05:6a20:c891:b0:b6:7b24:9d47 with SMTP id hb17-20020a056a20c89100b000b67b249d47mr26877740pzb.19.1674528200854; Mon, 23 Jan 2023 18:43:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674528200; cv=none; d=google.com; s=arc-20160816; b=OzSHn8BV19wCjRFD7wF1Nroly7us/eHgV0U3RgZJmdQFnxb77IUHN3xjDMBHNWZP6Y 7rcoVyRreV7J5CI0pkYy0h8xoyt6rEA9e1fPcMQ4TKaWDYTDMvcsRJ4Vag6284/57Ncq bZS+yEErGkXEcP0riv4z8tyilv5XxBbXejguu3QoNbmptXP3ARNmGPzgZZtshIqVZ/YA AieXZPiNozgl8nxFU+S/1Kxm0QNMW6WVJBow/9sa7PoAm0oj8pQCys8sOa+ysb+rQfLF lSX3G83Ad5j/imRrPy1i+TsLvCfRzAQf48CHxddWZXGsir/iBy6NT6kdttWJsbY9tEEX NWmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=4ca/fSLz84+8zt25NEHBciinMYKl2LpEMEovBvxwZ9Y=; b=BLxUvxzCUDkYlrT/vXQWHJajrqkwyOy3N8vrBUs0o8FG4zqqaOIp9qAzy+h2otXi9j RGkDlSWSbs4IFI9j8yWbywrF0qpTgrcf6IBF8648Af70qyJj8kNHhPhNr+x94ZtCoroQ ymdmyT2pLdprmE4Ta7Hr6JnOMPKKI8hJWREWwSRPSPKRW+OZZZjI/YJ1P5vOO4ftIvxz zOlxHkV1qVPsfthtV/9J4RtEIjEmQdkp08u441ygFb2ksfbQJdhRUs5fk5Qnb3LYTOHA iCTBQuc8tEW5LDjBEdmEAOE+Ns0hQESfLURTuRIox4HeHzLu+rMd10i3N3i/3P4hMdhF 75tA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=jCqPJMhz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p18-20020a1709028a9200b0019269c72094si1039719plo.504.2023.01.23.18.43.08; Mon, 23 Jan 2023 18:43:20 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=jCqPJMhz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232653AbjAXCkU (ORCPT + 99 others); Mon, 23 Jan 2023 21:40:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54082 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232620AbjAXCjr (ORCPT ); Mon, 23 Jan 2023 21:39:47 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1E7DF30EB9; Mon, 23 Jan 2023 18:39:22 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id B6EA8B80EBB; Tue, 24 Jan 2023 02:39:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A2C0BC4339B; Tue, 24 Jan 2023 02:39:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1674527959; bh=fE7TnKGk+7sECniXW1Co7rrNpfck1npdV3aCIbmWvVY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=jCqPJMhz+6FbBO604fTHk1Jefz1JgQav5j2OQSC3HHeTH0ntkts7NTG+v7/9iOw/d VH8t4YwRoediSlsf7CsTGHnBSl0p3K2USE5t6imqn3MIo8ibGniAgzUMqnOuhIQf0f EKzmS70uGtCYaHtwFjryFoDS57RDKMy0gv1g3GtK4dn8mEwQKiVWWyz2NeRy3Oyk6M itrKbYiUeb98SDn72IUnYOeZA+4jJSEX08dRL1fNu5W+yAiHR7GPHhudfc1RXuIZJ/ e81hZ7FKkHYqIvypgC0aM4zrD7JMxv3ijn2XHbpIaB0GqHPIMv5zxZJ8n0IDjTEjMF iZ0SK9zvS4xqw== From: Eric Van Hensbergen To: v9fs-developer@lists.sourceforge.net, asmadeus@codewreck.org, rminnich@gmail.com, lucho@ionkov.net Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux_oss@crudebyte.com, Eric Van Hensbergen Subject: [PATCH v3 11/11] Fix revalidate Date: Tue, 24 Jan 2023 02:38:34 +0000 Message-Id: <20230124023834.106339-12-ericvh@kernel.org> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20230124023834.106339-1-ericvh@kernel.org> References: <20221218232217.1713283-1-evanhensbergen@icloud.com> <20230124023834.106339-1-ericvh@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1755870083071981261?= X-GMAIL-MSGID: =?utf-8?q?1755870083071981261?= Unclear if this case ever happens, but if no inode in dentry, then the dentry is definitely invalid. Seemed to be the opposite in the existing code. Signed-off-by: Eric Van Hensbergen --- fs/9p/vfs_dentry.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/9p/vfs_dentry.c b/fs/9p/vfs_dentry.c index 65fa2df5e49b..b0c3f8e8ea00 100644 --- a/fs/9p/vfs_dentry.c +++ b/fs/9p/vfs_dentry.c @@ -68,7 +68,7 @@ static int v9fs_lookup_revalidate(struct dentry *dentry, unsigned int flags) inode = d_inode(dentry); if (!inode) - goto out_valid; + return 0; v9inode = V9FS_I(inode); if (v9inode->cache_validity & V9FS_INO_INVALID_ATTR) { @@ -91,7 +91,6 @@ static int v9fs_lookup_revalidate(struct dentry *dentry, unsigned int flags) if (retval < 0) return retval; } -out_valid: return 1; }