From patchwork Mon Jan 23 20:53:38 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Kaiser X-Patchwork-Id: 47394 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp1811286wrn; Mon, 23 Jan 2023 12:57:02 -0800 (PST) X-Google-Smtp-Source: AMrXdXuxBV/iSJbRG275BY08LZw600akJywGg0bqxy0/pOb9h1IgodWyjSABNMmrT0SjFAuPQjip X-Received: by 2002:a17:903:2441:b0:194:4483:bff6 with SMTP id l1-20020a170903244100b001944483bff6mr38503203pls.68.1674507421859; Mon, 23 Jan 2023 12:57:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674507421; cv=none; d=google.com; s=arc-20160816; b=tPHM3eYJAQuwGEFSdyRWQPksJYMPdr2U4Sq49Hytm+3iZuMRWPV3175w1EziP07eir 65wXUAm9aMlk3d8Sgu8/r9z8BCCQUBQb8rfGe0KaVx8lUud1iV2xtVyuol7bK2Buz7sQ FTCciZbWCLtRz3g01xELnH3MAA42z9hLKvxJPAx6JWJMSXwt7E0rw28TUBcQuErrpdnx WkmdEPuX+KAPJUq5pMgDUKCKsVfP7DiaALwDkJomzYqJnHCjsDDn2ZfOZf3jrbv+V0Wd 0zTsxl/3oEzy/LdjEOSykp/0o84ygGg07S86Ti9swSngQ7Zc997M67w+lYKYtZwBamxj QW3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=id3Zx91zpyqs/o8JYs3wETC2mf5DX3qmuXDj3b4uauE=; b=q9f8p5Ul6mFZXovzrKuO+DHBfJAAyecjRQUs0LvUOnvpsm1rkwmzrnxdmSmwyNSXaV BGb3yWXhz1oCQ/WzF377mPRwDk6cUR6IquJtJzVSTCPd4z/LX3q047gc0ey3Ncxy+tI4 JRjV2u18dwGvgvam/Gy2Rr8xksTp49aoTETI7PoHaDNu3alp3HL17Mraq1uZSF8Mo3Ye 9RQ2vHP8DU7GZ9AKY0GlinD9eERGnSEizSkWEZ1tEIi/zU3MCNH4l/zk+QK6hYeP8j2U jN8oWzgFfk7oEaD0wqwvMqrNdWaMXD7I8BnrsvPn9rP1+Fbjq1eS9DSgdlUhfgp4NyxD 78zw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h10-20020a170902704a00b00194c5d92df3si386991plt.50.2023.01.23.12.56.49; Mon, 23 Jan 2023 12:57:01 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232255AbjAWUzI (ORCPT + 99 others); Mon, 23 Jan 2023 15:55:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52360 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232284AbjAWUy2 (ORCPT ); Mon, 23 Jan 2023 15:54:28 -0500 Received: from viti.kaiser.cx (viti.kaiser.cx [IPv6:2a01:238:43fe:e600:cd0c:bd4a:7a3:8e9f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2E12838648 for ; Mon, 23 Jan 2023 12:54:14 -0800 (PST) Received: from ipservice-092-217-089-134.092.217.pools.vodafone-ip.de ([92.217.89.134] helo=martin-debian-2.paytec.ch) by viti.kaiser.cx with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1pK3pS-0000Lk-3s; Mon, 23 Jan 2023 21:54:10 +0100 From: Martin Kaiser To: Greg Kroah-Hartman Cc: Larry Finger , Phillip Potter , Michael Straube , Pavel Skripkin , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Martin Kaiser Subject: [PATCH 19/23] staging: r8188eu: fix rtw_xmitframe_enqueue error handling Date: Mon, 23 Jan 2023 21:53:38 +0100 Message-Id: <20230123205342.229589-20-martin@kaiser.cx> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230123205342.229589-1-martin@kaiser.cx> References: <20230123205342.229589-1-martin@kaiser.cx> MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1755848294585596631?= X-GMAIL-MSGID: =?utf-8?q?1755848294585596631?= In function rtw_xmitframe_enqueue, we can simply relay the error code from rtw_xmit_classifier. Signed-off-by: Martin Kaiser --- drivers/staging/r8188eu/core/rtw_xmit.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/staging/r8188eu/core/rtw_xmit.c b/drivers/staging/r8188eu/core/rtw_xmit.c index ef6d3a9bffea..4f9defdbe257 100644 --- a/drivers/staging/r8188eu/core/rtw_xmit.c +++ b/drivers/staging/r8188eu/core/rtw_xmit.c @@ -1347,12 +1347,7 @@ void rtw_free_xmitframe_queue(struct xmit_priv *pxmitpriv, struct __queue *pfram s32 rtw_xmitframe_enqueue(struct adapter *padapter, struct xmit_frame *pxmitframe) { - if (rtw_xmit_classifier(padapter, pxmitframe) == _FAIL) { -/* pxmitframe->pkt = NULL; */ - return _FAIL; - } - - return _SUCCESS; + return rtw_xmit_classifier(padapter, pxmitframe); } struct xmit_frame *rtw_dequeue_xframe(struct xmit_priv *pxmitpriv, struct hw_xmit *phwxmit_i)