From patchwork Mon Jan 23 20:53:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Kaiser X-Patchwork-Id: 47388 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp1811192wrn; Mon, 23 Jan 2023 12:56:42 -0800 (PST) X-Google-Smtp-Source: AMrXdXuXNczUBzMjN52XhQ+wBa5NZIeWfr6VHwbmw7Ek0wzdc812Acqc39E5OenEuesORSM8+VXf X-Received: by 2002:a62:ea0e:0:b0:577:d10d:6eab with SMTP id t14-20020a62ea0e000000b00577d10d6eabmr26964949pfh.21.1674507401908; Mon, 23 Jan 2023 12:56:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674507401; cv=none; d=google.com; s=arc-20160816; b=iv7r51rgrcdNhFAjCiDoBhGxw4aNFmrpkXPu2MUgf88Ci7uTeBRAvrQgvqZUZm/Xy6 t0XN1bw5y+gALk5dl2dxFNKGpar7PEFONqLjg/In/5s2bz/tf5LsNGpLklp1Wm+4sq1g 3mWZuQURVVD26auCn3LSgFZQX2dfpRljgZsAWMfklNxswJAlt40WnLjj7gIO7+vgdsEF fiSv0w1oCyTPL+Cc2yZL2IzOflAUBheVlUg+EtC5QQ1o+kKSSG8d4q1VcjKRg/PkYKk2 VzPyZVC8ildODo8H0kSNsBneHogpu8kR/4CgVgWnf6rAg/fX88pPHyl7lc+btd1bDHPR pRlg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=x6mRKQmWAKQfD5kKOdygoZ+n5giR/h/TABoJAkvwiSI=; b=pqgmYm9JrGzR0dKcq+Q/cpCJvJuaIPD47e2o3uxj4H9qitmLxjI3VVOtU2eCO3qSm0 ogO6fRLMmboJfEGV76ykGVb7vu/8H7+iBSPMMDkLKllTHoH0ObWOZqN9sQoJoC442rYW 8ZRX7lBnrsEhpdih5FBY0sxPfaBiaNYTkTJBkpmXf6Aa5wGzzxuZzhMyjClG8XAI90kX MhGIbtUX4bLxiUtZx0CNK7zSF7SS48rnboRZuuGDDrZG0HllqBeWE5xwWtTvRPzi6uSH ex4osDGKJZv19PNW7RSO+OWRv+uKMUbaXXd7dQ4f0GeSd15FvaCLyLzO1djqTSwOx/Qe wnEw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k8-20020aa79d08000000b00580ccf54452si54057pfp.295.2023.01.23.12.56.30; Mon, 23 Jan 2023 12:56:41 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232049AbjAWUyb (ORCPT + 99 others); Mon, 23 Jan 2023 15:54:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51444 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232016AbjAWUyO (ORCPT ); Mon, 23 Jan 2023 15:54:14 -0500 Received: from viti.kaiser.cx (viti.kaiser.cx [IPv6:2a01:238:43fe:e600:cd0c:bd4a:7a3:8e9f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A121732E64 for ; Mon, 23 Jan 2023 12:54:10 -0800 (PST) Received: from ipservice-092-217-089-134.092.217.pools.vodafone-ip.de ([92.217.89.134] helo=martin-debian-2.paytec.ch) by viti.kaiser.cx with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1pK3pM-0000Lk-P5; Mon, 23 Jan 2023 21:54:04 +0100 From: Martin Kaiser To: Greg Kroah-Hartman Cc: Larry Finger , Phillip Potter , Michael Straube , Pavel Skripkin , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Martin Kaiser Subject: [PATCH 12/23] staging: r8188eu: remove redundant parameter Date: Mon, 23 Jan 2023 21:53:31 +0100 Message-Id: <20230123205342.229589-13-martin@kaiser.cx> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230123205342.229589-1-martin@kaiser.cx> References: <20230123205342.229589-1-martin@kaiser.cx> MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1755848273692571852?= X-GMAIL-MSGID: =?utf-8?q?1755848273692571852?= The rtl8188eu_xmitframe_complete function takes two parameters: adapter and xmit_priv. xmit_priv is part of struct adapter, this parameter can be removed. Signed-off-by: Martin Kaiser --- drivers/staging/r8188eu/hal/rtl8188eu_xmit.c | 3 ++- drivers/staging/r8188eu/hal/usb_ops_linux.c | 3 +-- drivers/staging/r8188eu/include/rtl8188e_xmit.h | 3 +-- 3 files changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/staging/r8188eu/hal/rtl8188eu_xmit.c b/drivers/staging/r8188eu/hal/rtl8188eu_xmit.c index e097fa14dc6e..e067cc271686 100644 --- a/drivers/staging/r8188eu/hal/rtl8188eu_xmit.c +++ b/drivers/staging/r8188eu/hal/rtl8188eu_xmit.c @@ -365,8 +365,9 @@ static u32 xmitframe_need_length(struct xmit_frame *pxmitframe) return len; } -bool rtl8188eu_xmitframe_complete(struct adapter *adapt, struct xmit_priv *pxmitpriv) +bool rtl8188eu_xmitframe_complete(struct adapter *adapt) { + struct xmit_priv *pxmitpriv = &adapt->xmitpriv; struct dvobj_priv *pdvobjpriv = adapter_to_dvobj(adapt); struct xmit_frame *pxmitframe = NULL; struct xmit_frame *pfirstframe = NULL; diff --git a/drivers/staging/r8188eu/hal/usb_ops_linux.c b/drivers/staging/r8188eu/hal/usb_ops_linux.c index 9f008e61a6f2..e122c8ca929c 100644 --- a/drivers/staging/r8188eu/hal/usb_ops_linux.c +++ b/drivers/staging/r8188eu/hal/usb_ops_linux.c @@ -463,7 +463,6 @@ u32 rtw_read_port(struct adapter *adapter, u8 *rmem) void rtl8188eu_xmit_tasklet(unsigned long priv) { struct adapter *adapt = (struct adapter *)priv; - struct xmit_priv *pxmitpriv = &adapt->xmitpriv; if (check_fwstate(&adapt->mlmepriv, _FW_UNDER_SURVEY)) return; @@ -471,5 +470,5 @@ void rtl8188eu_xmit_tasklet(unsigned long priv) do { if (adapt->bDriverStopped || adapt->bSurpriseRemoved || adapt->bWritePortCancel) break; - } while (rtl8188eu_xmitframe_complete(adapt, pxmitpriv)); + } while (rtl8188eu_xmitframe_complete(adapt)); } diff --git a/drivers/staging/r8188eu/include/rtl8188e_xmit.h b/drivers/staging/r8188eu/include/rtl8188e_xmit.h index e6d343ffc148..a023dd792da7 100644 --- a/drivers/staging/r8188eu/include/rtl8188e_xmit.h +++ b/drivers/staging/r8188eu/include/rtl8188e_xmit.h @@ -125,7 +125,6 @@ s32 rtl8188eu_hal_xmit(struct adapter *padapter, struct xmit_frame *frame); s32 rtl8188eu_mgnt_xmit(struct adapter *padapter, struct xmit_frame *frame); s32 rtl8188eu_xmit_buf_handler(struct adapter *padapter); void rtl8188eu_xmit_tasklet(unsigned long priv); -bool rtl8188eu_xmitframe_complete(struct adapter *padapter, - struct xmit_priv *pxmitpriv); +bool rtl8188eu_xmitframe_complete(struct adapter *padapter); #endif /* __RTL8188E_XMIT_H__ */