From patchwork Mon Jan 23 20:53:28 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Kaiser X-Patchwork-Id: 47392 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp1811217wrn; Mon, 23 Jan 2023 12:56:47 -0800 (PST) X-Google-Smtp-Source: AMrXdXvYxUG61eODvbD9IkJG1Rtx0pb+ltzzNgkxh/kV/ULnUatMpvNALytl3Qx7vh0lZJ77rAsB X-Received: by 2002:a50:fe95:0:b0:46c:aa8b:da5c with SMTP id d21-20020a50fe95000000b0046caa8bda5cmr25766265edt.33.1674507407301; Mon, 23 Jan 2023 12:56:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674507407; cv=none; d=google.com; s=arc-20160816; b=AKsrPlL/8Jp3c11km0uVDdgKtcqgJAfvnLAGWo+/QmaDpadGXPzPswoN32VkY4xpH2 yE+Xv3A+WgChn3x0hEfRBI6zmbzXrfRtAl7PZCb8G0iYq4w5YCZ29vgFIW3z5qrRjgjl q7M/u8WoWmZeW9RnXhTeiGoH5DeQbcgqOwuI/nVXYPwaHk5nJzJUYuY5KyT8sqQVy3oe ZkjpPICo4Jxzy2wbeAlaPlxcxTwYncIrir3XkPTYY9MRAfs1ofywuBtHP5GbEfkCS8O2 9gYxIexvSB0dtNCALFjt5t3RvBTaXkSZ5Bjey0Sw39UYdTrZaqyJMUGN8E2Sna7C67Zr sYkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=Nnw4kwTQpoH4M+oZ/jucfxzK9rPJmM8XkaO0HiD3qpc=; b=fUoxyQ6AKdi7gm6BkRPaS9A1PmCwcoaW3R0fPk7G+enwL05+Ot5kuE4giW1ku2CwmZ vzVOZlq2eJZ6VN0bPDU5FSARn4/QR1CSwAp4/TOWYFkxbp4oTpZJszn+qYS0htikiAB5 a7zQIhEaQQuYkog/Q/99fSQ35P2T0b93fTxoot6XoQ6tlj369iYAPLDBaAA+LyfNopXw MKBSnRdj1ajtviD0yNBq7C6ScTI3SJs4G2hMamuWs+pbm8uZL2z7+pSTlgG0E0Eo9CfI S56nuTXCiyXwM2nexrjjFcFZ/9EkHLuwiLYf2fQxlwzstTundJk5P4h5uMj4iBV1aIE/ UxaA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v28-20020aa7cd5c000000b00469bac8510csi406794edw.583.2023.01.23.12.56.23; Mon, 23 Jan 2023 12:56:47 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232207AbjAWUy0 (ORCPT + 99 others); Mon, 23 Jan 2023 15:54:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51094 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231803AbjAWUyI (ORCPT ); Mon, 23 Jan 2023 15:54:08 -0500 Received: from viti.kaiser.cx (viti.kaiser.cx [IPv6:2a01:238:43fe:e600:cd0c:bd4a:7a3:8e9f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 857BE23D9F for ; Mon, 23 Jan 2023 12:54:07 -0800 (PST) Received: from ipservice-092-217-089-134.092.217.pools.vodafone-ip.de ([92.217.89.134] helo=martin-debian-2.paytec.ch) by viti.kaiser.cx with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1pK3pK-0000Lk-C5; Mon, 23 Jan 2023 21:54:02 +0100 From: Martin Kaiser To: Greg Kroah-Hartman Cc: Larry Finger , Phillip Potter , Michael Straube , Pavel Skripkin , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Martin Kaiser Subject: [PATCH 09/23] staging: r8188eu: remove dead assignment Date: Mon, 23 Jan 2023 21:53:28 +0100 Message-Id: <20230123205342.229589-10-martin@kaiser.cx> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230123205342.229589-1-martin@kaiser.cx> References: <20230123205342.229589-1-martin@kaiser.cx> MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1755848278851341404?= X-GMAIL-MSGID: =?utf-8?q?1755848278851341404?= There's no point in moving xmitframe_plist to the next list element. xmitframe_plist is not used any more after this assignment. Signed-off-by: Martin Kaiser --- drivers/staging/r8188eu/core/rtw_xmit.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/staging/r8188eu/core/rtw_xmit.c b/drivers/staging/r8188eu/core/rtw_xmit.c index aefd32b98d08..943e7a56f7ce 100644 --- a/drivers/staging/r8188eu/core/rtw_xmit.c +++ b/drivers/staging/r8188eu/core/rtw_xmit.c @@ -1365,11 +1365,7 @@ static struct xmit_frame *dequeue_one_xmitframe(struct tx_servq *ptxservq, struc if (xmitframe_phead != xmitframe_plist) { pxmitframe = container_of(xmitframe_plist, struct xmit_frame, list); - - xmitframe_plist = xmitframe_plist->next; - list_del_init(&pxmitframe->list); - ptxservq->qcnt--; } return pxmitframe;