Message ID | 20230123011223.23804-1-duoming@zju.edu.cn |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp1370862wrn; Sun, 22 Jan 2023 17:17:11 -0800 (PST) X-Google-Smtp-Source: AMrXdXu8fpxZe35BPOqLFI7VDZbYhiEkfd7lOL0Rok3u2pXovjvrhnEnvqfZ5OWfCOof90jViD6L X-Received: by 2002:a17:907:d110:b0:7ae:8194:7e06 with SMTP id uy16-20020a170907d11000b007ae81947e06mr26966246ejc.56.1674436631565; Sun, 22 Jan 2023 17:17:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674436631; cv=none; d=google.com; s=arc-20160816; b=wxaayFdKyGzD/NRS0nPmDhUfWJio8zXjS69YwCGHIyov1ay+mvFsU3AgGZxArLAeok PqLS8nru8o+4zg7yVShpVGr92hMFKqQT9Rnt+ZN3x6kx1ce8KRJ1Nlocg0/58oqY6ifJ gO0npN/lyniIHCYUxLafFFddjla/6itMYCIozuju63Zu2XdC7Mqu59MTcBopC+GeZnyB 3xtE5DTNRNvmyD9+AKNDw50LvptFaQIbvmsPSPeOIZ5QRMD0g7/46QtD5iD0dy+WnLgZ o2DOlTv8KKGH8S8Ys4b8X929sxEWDGikqUrhZwRySkp30IYCpvE6pMI8/38vqOate75A tw4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from; bh=YTzl86xcJdTeeY6xXGQcN0BWsp0GDHVUoQXRpz6NB0s=; b=v2NoGBfOEGRoSKpTDSyq4gMEuPlCDu/l6yBctnIwAY45lKo11LKj1xBsNEm/AYEBoR iNp/cuX/SJSucrf9fcawnTvjg1Dv9emKH7SuBPIZSAh6ooHu5ZWnm1j59svD98w+I+7i eaNMxqvyc8xme13IZyyl/b2Bi7Li5MHuNqCb4/RA6vNTKUIkt/98OwVLq8Dcky1kIwo1 5p8WBVDHegFZ/LQvf421mKZZZDnTDTFkUp9qWO373YIKX/a55NtaV/a0OVmR7lz/lFam HstVD76lmpFgMjSDS6CmWm0hVbg/oyvoj0WeI/r+NRfABZ+QsRBFm+lYnf9OkyGsYnN/ 4VWw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id qa8-20020a170907868800b00858e2e65237si41471700ejc.8.2023.01.22.17.16.48; Sun, 22 Jan 2023 17:17:11 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230138AbjAWBM6 (ORCPT <rfc822;forouhar.linux@gmail.com> + 99 others); Sun, 22 Jan 2023 20:12:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36286 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229817AbjAWBMz (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Sun, 22 Jan 2023 20:12:55 -0500 Received: from azure-sdnproxy.icoremail.net (azure-sdnproxy.icoremail.net [20.232.28.96]) by lindbergh.monkeyblade.net (Postfix) with SMTP id F2F70EB7C; Sun, 22 Jan 2023 17:12:50 -0800 (PST) Received: from ubuntu.localdomain (unknown [112.254.167.99]) by mail-app4 (Coremail) with SMTP id cS_KCgB3nN_63s1jv4NmCg--.22122S2; Mon, 23 Jan 2023 09:12:37 +0800 (CST) From: Duoming Zhou <duoming@zju.edu.cn> To: linux-media@vger.kernel.org Cc: linux-kernel@vger.kernel.org, maximlevitsky@gmail.com, sean@mess.org, mchehab@kernel.org, Duoming Zhou <duoming@zju.edu.cn> Subject: [PATCH] media: rc: Fix use-after-free bugs caused by ene_tx_irqsim() Date: Mon, 23 Jan 2023 09:12:23 +0800 Message-Id: <20230123011223.23804-1-duoming@zju.edu.cn> X-Mailer: git-send-email 2.17.1 X-CM-TRANSID: cS_KCgB3nN_63s1jv4NmCg--.22122S2 X-Coremail-Antispam: 1UD129KBjvJXoW7WFyrJF17Kw1rAw4xuF17Jrb_yoW8JFW8pr W8GFWSkFyUGw12gFnrXw4ku3W5Xws3Ja4UW342g3y0vwn5GFy3JF90qa4jvay8AF95AFZF vr45Xw43CFsxuFJanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUka14x267AKxVWUJVW8JwAFc2x0x2IEx4CE42xK8VAvwI8IcIk0 rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK02 1l84ACjcxK6xIIjxv20xvE14v26w1j6s0DM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26r4U JVWxJr1l84ACjcxK6I8E87Iv67AKxVW0oVCq3wA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_Gc CE3s1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4xG64xvF2IEw4CE5I8CrVC2j2WlYx0E 2Ix0cI8IcVAFwI0_Jr0_Jr4lYx0Ex4A2jsIE14v26r1j6r4UMcvjeVCFs4IE7xkEbVWUJV W8JwACjcxG0xvY0x0EwIxGrwACjI8F5VA0II8E6IAqYI8I648v4I1lc2xSY4AK67AK6w4l 42xK82IYc2Ij64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4xG67AKxVWUJV WUGwC20s026x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r126r1DMIIYrxkI7VAK I48JMIIF0xvE2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6xkF7I0E14v26r1j6r 4UMIIF0xvE42xK8VAvwI8IcIk0rVWUJVWUCwCI42IY6I8E87Iv67AKxVWUJVW8JwCI42IY 6I8E87Iv6xkF7I0E14v26r1j6r4UYxBIdaVFxhVjvjDU0xZFpf9x0JUg4SOUUUUU= X-CM-SenderInfo: qssqjiasttq6lmxovvfxof0/1tbiAgIDAVZdtdUtdwAqsZ X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1755774064865500250?= X-GMAIL-MSGID: =?utf-8?q?1755774064865500250?= |
Series |
media: rc: Fix use-after-free bugs caused by ene_tx_irqsim()
|
|
Commit Message
Duoming Zhou
Jan. 23, 2023, 1:12 a.m. UTC
When the ene device is detaching, function ene_remove() will
be called. But there is no function to cancel tx_sim_timer
in ene_remove(), the timer handler ene_tx_irqsim() could race
with ene_remove(). As a result, the UAF bugs could happen,
the process is shown below.
(cleanup routine) | (timer routine)
| mod_timer(&dev->tx_sim_timer, ..)
ene_remove() | (wait a time)
kfree(dev) //FREE |
| ene_tx_irqsim()
| dev->hw_lock //USE
| ene_tx_sample(dev) //USE
Fix by adding del_timer_sync(&dev->tx_sim_timer) in ene_remove(),
The tx_sim_timer could stop before ene device is deallocated.
This problem is found by static analysis.
Fixes: 9ea53b74df9c ("V4L/DVB: STAGING: remove lirc_ene0100 driver")
Signed-off-by: Duoming Zhou <duoming@zju.edu.cn>
---
drivers/media/rc/ene_ir.c | 1 +
1 file changed, 1 insertion(+)
Comments
On Mon, Jan 23, 2023 at 09:12:23AM +0800, Duoming Zhou wrote: > When the ene device is detaching, function ene_remove() will > be called. But there is no function to cancel tx_sim_timer > in ene_remove(), the timer handler ene_tx_irqsim() could race > with ene_remove(). As a result, the UAF bugs could happen, > the process is shown below. > > (cleanup routine) | (timer routine) > | mod_timer(&dev->tx_sim_timer, ..) > ene_remove() | (wait a time) > kfree(dev) //FREE | > | ene_tx_irqsim() > | dev->hw_lock //USE > | ene_tx_sample(dev) //USE > > Fix by adding del_timer_sync(&dev->tx_sim_timer) in ene_remove(), > The tx_sim_timer could stop before ene device is deallocated. > > This problem is found by static analysis. > > Fixes: 9ea53b74df9c ("V4L/DVB: STAGING: remove lirc_ene0100 driver") > Signed-off-by: Duoming Zhou <duoming@zju.edu.cn> > --- > drivers/media/rc/ene_ir.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/media/rc/ene_ir.c b/drivers/media/rc/ene_ir.c > index e09270916fb..716b72a048f 100644 > --- a/drivers/media/rc/ene_ir.c > +++ b/drivers/media/rc/ene_ir.c > @@ -1114,6 +1114,7 @@ static void ene_remove(struct pnp_dev *pnp_dev) > free_irq(dev->irq, dev); > release_region(dev->hw_io, ENE_IO_SIZE); > rc_unregister_device(dev->rdev); > + del_timer_sync(&dev->tx_sim_timer); Great catch! The timer can call ene_tx_sample() which can write to the io ports, so the ordering still is not quite right. I think the rc_unregister_device() and del_timer_sync() should be call first in ene_remove(). Sean
Hello, On Mon, 23 Jan 2023 09:10:01, Sean Young wrote: > On Mon, Jan 23, 2023 at 09:12:23AM +0800, Duoming Zhou wrote: > > When the ene device is detaching, function ene_remove() will > > be called. But there is no function to cancel tx_sim_timer > > in ene_remove(), the timer handler ene_tx_irqsim() could race > > with ene_remove(). As a result, the UAF bugs could happen, > > the process is shown below. > > > > (cleanup routine) | (timer routine) > > | mod_timer(&dev->tx_sim_timer, ..) > > ene_remove() | (wait a time) > > kfree(dev) //FREE | > > | ene_tx_irqsim() > > | dev->hw_lock //USE > > | ene_tx_sample(dev) //USE > > > > Fix by adding del_timer_sync(&dev->tx_sim_timer) in ene_remove(), > > The tx_sim_timer could stop before ene device is deallocated. > > > > This problem is found by static analysis. > > > > Fixes: 9ea53b74df9c ("V4L/DVB: STAGING: remove lirc_ene0100 driver") > > Signed-off-by: Duoming Zhou <duoming@zju.edu.cn> > > --- > > drivers/media/rc/ene_ir.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/media/rc/ene_ir.c b/drivers/media/rc/ene_ir.c > > index e09270916fb..716b72a048f 100644 > > --- a/drivers/media/rc/ene_ir.c > > +++ b/drivers/media/rc/ene_ir.c > > @@ -1114,6 +1114,7 @@ static void ene_remove(struct pnp_dev *pnp_dev) > > free_irq(dev->irq, dev); > > release_region(dev->hw_io, ENE_IO_SIZE); > > rc_unregister_device(dev->rdev); > > + del_timer_sync(&dev->tx_sim_timer); > > Great catch! > > The timer can call ene_tx_sample() which can write to the io ports, so the > ordering still is not quite right. I think the rc_unregister_device() and > del_timer_sync() should be call first in ene_remove(). Thank you for your time and suggestions! I will put rc_unregister_device() and del_timer_sync() before release_region() in order that the tx_sim_timer could finish before io ports are released. Best regards, Duoming Zhou
diff --git a/drivers/media/rc/ene_ir.c b/drivers/media/rc/ene_ir.c index e09270916fb..716b72a048f 100644 --- a/drivers/media/rc/ene_ir.c +++ b/drivers/media/rc/ene_ir.c @@ -1114,6 +1114,7 @@ static void ene_remove(struct pnp_dev *pnp_dev) free_irq(dev->irq, dev); release_region(dev->hw_io, ENE_IO_SIZE); rc_unregister_device(dev->rdev); + del_timer_sync(&dev->tx_sim_timer); kfree(dev); }