From patchwork Tue Jan 24 08:31:21 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Neil Armstrong X-Patchwork-Id: 47585 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp2034266wrn; Tue, 24 Jan 2023 00:34:21 -0800 (PST) X-Google-Smtp-Source: AMrXdXsunZHIxXzQtCZHVJKzu4z5Bq2cN9fZUHVP68z5yILXvmj5KrzQhFRUmx99BPj5jjZ2fawW X-Received: by 2002:a17:902:ea10:b0:195:e5a0:9acb with SMTP id s16-20020a170902ea1000b00195e5a09acbmr20488508plg.6.1674549261144; Tue, 24 Jan 2023 00:34:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674549261; cv=none; d=google.com; s=arc-20160816; b=GZyXKWojT0kFrYTobFFBd4CYN9DRsx2SKpLk5Un2YIZijhKsw5JrMaaVy3dYhG6w2G Hxc8X5q9me+v3D4zKUZCgI9v6FYuGCVjZhLXNO+j28W2qfqYtgOYn4M0YDNTOzBx3TaE 0cxiFeQbX3PS9IrGNyMmgQjpFFKv5N5+gEdljDLy6+t6BrjH0VO7bR/xRcPr58ycUZ5C +bA++EicU2QYbKLlhqbIGbJm9noavFCM7R5/HQIumhPEss+6/6M3LE4Ba2ri2b4IF9wR p0AcM88fcPfydqmMF1cD2mDpXrr3EFhTEBepempTJHrOVIsHjS3rOsB1had8KVUTcec0 AU7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:message-id:content-transfer-encoding :mime-version:subject:date:from:dkim-signature; bh=f9Z9xi4UTxKaj+2qIiteZ1vsHGIiq2RmA3CHBGm/Ijc=; b=YoIlUdsNJ+5RqYLyUXmmIxA2YM+Xc+yLcmaefs+dX+QxvXFZsceFJBTrUYb4/FtWQD /CpHuIkmonR5Sxw+DCfApR2Ccc5FEy2+BGq9qndMg2rXhxpMw/6YQVZ7rLcTDLwLIzu8 vCCjk8vKpu+yHTrWavYGDreDtdXqDL8L5vqnAewaPa9dErfPZUt4+3LxyiGMaV1jfkja jSrCPlzWpMl9g1IzN5NCSM+180s6HjMgkkzYqjLLKVmo9Q5VHdpRQSK4Ns2z2RlsavgD xQDa25TCjEEdamVBvxLWPqSuhX0A1YmAqOpbfoQFIz5snqur/DnvGT6JqnOIUoBH9vfS midg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=cXk9zSCJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o12-20020a170902d4cc00b001899477302bsi2098243plg.588.2023.01.24.00.34.08; Tue, 24 Jan 2023 00:34:21 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=cXk9zSCJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232964AbjAXIba (ORCPT + 99 others); Tue, 24 Jan 2023 03:31:30 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52786 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232656AbjAXIb3 (ORCPT ); Tue, 24 Jan 2023 03:31:29 -0500 Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7D4B82688 for ; Tue, 24 Jan 2023 00:31:27 -0800 (PST) Received: by mail-wr1-x42d.google.com with SMTP id r9so13081416wrw.4 for ; Tue, 24 Jan 2023 00:31:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=f9Z9xi4UTxKaj+2qIiteZ1vsHGIiq2RmA3CHBGm/Ijc=; b=cXk9zSCJehPS/3cLtcWSeyGTZPpC4fQPdptDYqWVuC0YeJRVKpmH/1Hplwr4KlYLh2 8ptX7fsA935CbY7CoQvFwI5Wu6ZJRCZzqkV5YG3aLStRFASzQLAR7+WlwcaM6Zc9c68U eFvXpfVvIxFVNXGNI/p9Ceadqi0Vyl/pJvd5pzFhLJljoBOkt0S0o6r8UngOaKcg07G4 PAHbuvQUnBaX0zJUXTdRSw1hkmFb26Us0qNARCiebVeku8qeGjjd7rirkNxq2Q81q7aK QWLjwCD4INLpjWKGG4KH1Qt00MpDOq+hNUyIu5hXRpxMN6gW7g7XrVposCLSh8amd47N Mw1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=f9Z9xi4UTxKaj+2qIiteZ1vsHGIiq2RmA3CHBGm/Ijc=; b=HIspXGi4Lerco+KIcSHjcHIQVGVdWY7dz+ODH1bhTQtME8fcvcj6hOjS05bChKoe1z zG8XexaP+zNCtJnmYjbp3MqbTSLqnj7GGUcFpopNa/weHZg56dfIfI4Bp0ryRxEHJI3B os+GOrjNcU2Tj5POQWoGDjCKiBaxh5rpV/ZfIxeRfPXvF1CC9tVne8zdMWSn1k75PtUc tDcxEnqYF4efAhbycjzSp7+Fw6nKgNXM5trgLZM6+h5551JMsGfRN7/DWLtktCYncmXK bwU0Zqe4obDuVxJ3yjT+Yn0phIwLLJwkRw5Ikt5WvW3GI//R2VUaG2m39DT31Tmg68VD WhDw== X-Gm-Message-State: AFqh2kpnhF7oqKcfIx2AZ9W6wo39I01vwdQMqmrnxf7hdxmTCUePetRA 1ZCC2CsW6ctS7Xwx9YQrXUMC1w== X-Received: by 2002:a5d:6b07:0:b0:236:695b:82d4 with SMTP id v7-20020a5d6b07000000b00236695b82d4mr21887459wrw.30.1674549086005; Tue, 24 Jan 2023 00:31:26 -0800 (PST) Received: from arrakeen.starnux.net ([2a01:e0a:982:cbb0:52eb:f6ff:feb3:451a]) by smtp.gmail.com with ESMTPSA id o2-20020a5d6842000000b002be5401ef5fsm1312291wrw.39.2023.01.24.00.31.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Jan 2023 00:31:25 -0800 (PST) From: Neil Armstrong Date: Tue, 24 Jan 2023 09:31:21 +0100 Subject: [PATCH v2] usb: dwc3: qcom: enable vbus override when in OTG dr-mode MIME-Version: 1.0 Message-Id: <20230123-topic-sm8550-upstream-dwc3-qcom-otg-v2-1-2d400e598463@linaro.org> X-B4-Tracking: v=1; b=H4sIAFiXz2MC/5WOQQ6CMBBFr2K6dgwtEKor72FYDGWAJtDitKCGc HcrN3D53uK/v4lAbCmI22kTTKsN1rsE6nwSZkDXE9g2sVCZyjOpcoh+tgbCpMsyg2UOkQknaF8 mh6fxE/jYg5bVtSSUhW4bkZYaDAQNozND2nLLOCY5M3X2faQfdeLBhuj5czxZ5c/+F10lSCClK yykRiy7+2gdsr947kW97/sXSWw8WewAAAA= To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Thinh Nguyen , Greg Kroah-Hartman Cc: Bryan O'Donoghue , linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Neil Armstrong X-Mailer: b4 0.12.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1755892165712470443?= X-GMAIL-MSGID: =?utf-8?q?1755892165712470443?= With vbus override enabled when in OTG dr_mode, Host<->Peripheral switch now works on SM8550, otherwise the DWC3 seems to be stuck in Host mode only. Fixes: a4333c3a6ba9 ("usb: dwc3: Add Qualcomm DWC3 glue driver") Reviewed-by: Bryan O'Donoghue Signed-off-by: Neil Armstrong Tested-by: Konrad Dybcio --- Changes in v2: - Added Bryan's reviewed-by - Added Fixes tag - Link to v1: https://lore.kernel.org/r/20230123-topic-sm8550-upstream-dwc3-qcom-otg-v1-1-e287a418aa5f@linaro.org --- drivers/usb/dwc3/dwc3-qcom.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- base-commit: 1b929c02afd37871d5afb9d498426f83432e71c2 change-id: 20230123-topic-sm8550-upstream-dwc3-qcom-otg-81795ea148db Best regards, diff --git a/drivers/usb/dwc3/dwc3-qcom.c b/drivers/usb/dwc3/dwc3-qcom.c index b0a0351d2d8b..959fc925ca7c 100644 --- a/drivers/usb/dwc3/dwc3-qcom.c +++ b/drivers/usb/dwc3/dwc3-qcom.c @@ -901,7 +901,7 @@ static int dwc3_qcom_probe(struct platform_device *pdev) qcom->mode = usb_get_dr_mode(&qcom->dwc3->dev); /* enable vbus override for device mode */ - if (qcom->mode == USB_DR_MODE_PERIPHERAL) + if (qcom->mode != USB_DR_MODE_HOST) dwc3_qcom_vbus_override_enable(qcom, true); /* register extcon to override sw_vbus on Vbus change later */