diff mbox series

[v2,4/8] Docs/hwmon/index: Add missing SPDX License Identifier

Message ID 20230122213650.187710-5-sj@kernel.org
State New
Headers
Series Docs: Add missing SPDX license identifiers of |

Commit Message

SeongJae Park Jan. 22, 2023, 9:36 p.m. UTC 
  Add missing SPDX License Identifier for hwmon documentation index file.

Signed-off-by: SeongJae Park <sj@kernel.org>
---
 Documentation/hwmon/index.rst | 2 ++
 1 file changed, 2 insertions(+)

Comments

Guenter Roeck Jan. 24, 2023, 1:49 p.m. UTC | #1 
On Sun, Jan 22, 2023 at 09:36:46PM +0000, SeongJae Park wrote:
> Add missing SPDX License Identifier for hwmon documentation index file.
> 
> Signed-off-by: SeongJae Park <sj@kernel.org>

Is it documented somewhere that GPL 2.0 is the default in the absence
of an explicit SPDX or other license identifier ? I don't find it
in Documentation/process/license-rules.rst, though maybe I am missing
it.

Guenter

> ---
>  Documentation/hwmon/index.rst | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/hwmon/index.rst b/Documentation/hwmon/index.rst
> index c2b3c1a822dd..2186d732654f 100644
> --- a/Documentation/hwmon/index.rst
> +++ b/Documentation/hwmon/index.rst
> @@ -1,3 +1,5 @@
> +.. SPDX-License-Identifier: GPL-2.0
> +
>  ===================
>  Hardware Monitoring
>  ===================
Guenter Roeck Jan. 31, 2023, 3:44 a.m. UTC | #2 
On Sun, Jan 22, 2023 at 09:36:46PM +0000, SeongJae Park wrote:
> Add missing SPDX License Identifier for hwmon documentation index file.
> 

I do not feel comfortable accepting this change without confirmation
that changing the license from <none> to an explicit <GPL v2.0> is
legally acceptable.

Guenter

> Signed-off-by: SeongJae Park <sj@kernel.org>
> ---
>  Documentation/hwmon/index.rst | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/hwmon/index.rst b/Documentation/hwmon/index.rst
> index c2b3c1a822dd..2186d732654f 100644
> --- a/Documentation/hwmon/index.rst
> +++ b/Documentation/hwmon/index.rst
> @@ -1,3 +1,5 @@
> +.. SPDX-License-Identifier: GPL-2.0
> +
>  ===================
>  Hardware Monitoring
>  ===================
Jonathan Corbet Jan. 31, 2023, 2:44 p.m. UTC | #3 
Guenter Roeck <linux@roeck-us.net> writes:

> On Sun, Jan 22, 2023 at 09:36:46PM +0000, SeongJae Park wrote:
>> Add missing SPDX License Identifier for hwmon documentation index file.
>> 
>
> I do not feel comfortable accepting this change without confirmation
> that changing the license from <none> to an explicit <GPL v2.0> is
> legally acceptable.

As with many of these, this file was initially added by Mauro (added to
CC).  Mauro, can you confirm that GPLv2 was your intention for these
index.rst files?  That would clear the path for a lot of these patches.

Thanks,

jon
Mauro Carvalho Chehab Jan. 31, 2023, 2:48 p.m. UTC | #4 
Em Sun, 22 Jan 2023 21:36:46 +0000
SeongJae Park <sj@kernel.org> escreveu:

> Add missing SPDX License Identifier for hwmon documentation index file.
> 
> Signed-off-by: SeongJae Park <sj@kernel.org>

Reviewed-by: Mauro Carvalho Chehab <mchehab@kernel.org>
> ---
>  Documentation/hwmon/index.rst | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/hwmon/index.rst b/Documentation/hwmon/index.rst
> index c2b3c1a822dd..2186d732654f 100644
> --- a/Documentation/hwmon/index.rst
> +++ b/Documentation/hwmon/index.rst
> @@ -1,3 +1,5 @@
> +.. SPDX-License-Identifier: GPL-2.0
> +
>  ===================
>  Hardware Monitoring
>  ===================



Thanks,
Mauro
Mauro Carvalho Chehab Jan. 31, 2023, 2:51 p.m. UTC | #5 
Em Tue, 31 Jan 2023 07:44:02 -0700
Jonathan Corbet <corbet@lwn.net> escreveu:

> Guenter Roeck <linux@roeck-us.net> writes:
> 
> > On Sun, Jan 22, 2023 at 09:36:46PM +0000, SeongJae Park wrote:  
> >> Add missing SPDX License Identifier for hwmon documentation index file.
> >>   
> >
> > I do not feel comfortable accepting this change without confirmation
> > that changing the license from <none> to an explicit <GPL v2.0> is
> > legally acceptable.  
> 
> As with many of these, this file was initially added by Mauro (added to
> CC).  Mauro, can you confirm that GPLv2 was your intention for these
> index.rst files?  That would clear the path for a lot of these patches.

Yes, that's the intend. Feel free to add either:

	Reviewed-by: Mauro Carvalho Chehab <mchehab@kernel.org>

Or
	Acked-by: Mauro Carvalho Chehab <mchehab@kernel.org>

to Documentation/*/index.rst files I wrote that might have missing:

	.. SPDX-License-Identifier: GPL-2.0

on the top of it.

Thanks,
Mauro
Guenter Roeck Jan. 31, 2023, 3:02 p.m. UTC | #6 
On Sun, Jan 22, 2023 at 09:36:46PM +0000, SeongJae Park wrote:
> Add missing SPDX License Identifier for hwmon documentation index file.
> 
> Signed-off-by: SeongJae Park <sj@kernel.org>
> Reviewed-by: Mauro Carvalho Chehab <mchehab@kernel.org>

Applied to hwmon-next.

Thanks,
Guenter

> ---
>  Documentation/hwmon/index.rst | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/hwmon/index.rst b/Documentation/hwmon/index.rst
> index c2b3c1a822dd..2186d732654f 100644
> --- a/Documentation/hwmon/index.rst
> +++ b/Documentation/hwmon/index.rst
> @@ -1,3 +1,5 @@
> +.. SPDX-License-Identifier: GPL-2.0
> +
>  ===================
>  Hardware Monitoring
>  ===================
diff mbox series

Patch

diff --git a/Documentation/hwmon/index.rst b/Documentation/hwmon/index.rst
index c2b3c1a822dd..2186d732654f 100644
--- a/Documentation/hwmon/index.rst
+++ b/Documentation/hwmon/index.rst
@@ -1,3 +1,5 @@ 
+.. SPDX-License-Identifier: GPL-2.0
+
 ===================
 Hardware Monitoring
 ===================