diff mbox series

[v10,1/2] x86/module: remove unused code in __apply_relocate_add

Message ID 20230121004945.697003-1-song@kernel.org
State New
Headers
Series [v10,1/2] x86/module: remove unused code in __apply_relocate_add |

Commit Message

Song Liu Jan. 21, 2023, 12:49 a.m. UTC 
  This "#if 0" block has been untouched for many years. Remove it to clean
up the code.

Suggested-by: Josh Poimboeuf <jpoimboe@redhat.com>
Signed-off-by: Song Liu <song@kernel.org>
---
 arch/x86/kernel/module.c | 4 ----
 1 file changed, 4 deletions(-)

Comments

Petr Mladek Jan. 24, 2023, 12:24 p.m. UTC | #1 
On Fri 2023-01-20 16:49:44, Song Liu wrote:
> This "#if 0" block has been untouched for many years. Remove it to clean
> up the code.
> 
> Suggested-by: Josh Poimboeuf <jpoimboe@redhat.com>
> Signed-off-by: Song Liu <song@kernel.org>

Reviewed-by: Petr Mladek <pmladek@suse.com>

Best Regards,
Petr
diff mbox series

Patch

diff --git a/arch/x86/kernel/module.c b/arch/x86/kernel/module.c
index 705fb2a41d7d..1dee3ad82da2 100644
--- a/arch/x86/kernel/module.c
+++ b/arch/x86/kernel/module.c
@@ -188,10 +188,6 @@  static int __apply_relocate_add(Elf64_Shdr *sechdrs,
 				goto invalid_relocation;
 			val -= (u64)loc;
 			write(loc, &val, 4);
-#if 0
-			if ((s64)val != *(s32 *)loc)
-				goto overflow;
-#endif
 			break;
 		case R_X86_64_PC64:
 			if (*(u64 *)loc != 0)