From patchwork Fri Jan 20 12:34:52 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adrian Hunter X-Patchwork-Id: 46319 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp172854wrn; Fri, 20 Jan 2023 04:36:48 -0800 (PST) X-Google-Smtp-Source: AMrXdXtWlb5Si5Tgks9UiEmxifDD4B9k8mfi5O5RGeiYmDCV26nhvplIMKET682dF6kgq5CicUQr X-Received: by 2002:a17:907:8e86:b0:84d:43c3:a897 with SMTP id tx6-20020a1709078e8600b0084d43c3a897mr31062412ejc.2.1674218208348; Fri, 20 Jan 2023 04:36:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674218208; cv=none; d=google.com; s=arc-20160816; b=RRE/e9GIe6rCpmw//AMuguTWyNmcfdjkvbd5NXnT9hp/U5vHv6uKJ7oSjxoGXlXuYp 1ia0txxVNy1w7KwgxcFNyr+pMu+CuWFS9lLmoaCwpC7iRd8hf225kLTqf7lDbhHN/UyI sbCJqj+6bXAMwkSky2eY29CcGXMscioLfG9hDpEUQ5Xl6RY/7PNPd9qxAdSPusuuAk6E kW1vSQ74L/7ET5BH9PePI9vE1h2hRHpYO0v9pbTqdclsMcGBZRL7B/PZu/5KUbU+9Qtc kvanzN3S/lJ7BDY9awduAQwn+tRTWu7F7NuQccGK1fdQthARebOdUFytuUjojNrFwdZl dGgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:organization :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=scGKwxYiKt0BIryouxDCHOJhYkbLlOTqnA+hG8r0vC4=; b=BnnJxY4JGuG6q5yuUHUBKa/cq15uZUhsWFGUA9c/pmfCX9rDEi79A1vOR0v9syUBM7 zrg9SYARx7H3MKrZPYM0e1inms5SCw+J9sNNuINDjaD0rd8pEDWWa87MauiOzTQP72bC gBkY090B7RTePYX4djX4xVacTthFfyb1wJYSIOcvbh8zRUpzIv2nMsr84QCRUCJp91pq 0Dw7Te4mLWSXxNNPj4e0gLe5j8AO3q+r+fGLLg+RVr4JN1wF4eXMlqr3jEVcSbv5B8fS cWZknvvALXI9k8uEd9gmemrDiwJ+evaXn09mYNSZhB1YjbOMIN0lcy0cDLWb71r/RAGu EOkg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=HYSip1CF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ae13-20020a17090725cd00b0083b6e04f33esi20891787ejc.280.2023.01.20.04.36.24; Fri, 20 Jan 2023 04:36:48 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=HYSip1CF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230234AbjATMf5 (ORCPT + 99 others); Fri, 20 Jan 2023 07:35:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59066 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230192AbjATMfv (ORCPT ); Fri, 20 Jan 2023 07:35:51 -0500 Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BCF6CBF5EB; Fri, 20 Jan 2023 04:35:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1674218129; x=1705754129; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=JH3uowZm2/EOmx74lVqvydtWQ0K9xGM+P+gA7PXly5g=; b=HYSip1CFyvJ3Ob6Md91EkTc8u2dj9IfnC7PUrHcByJUwA6dd5vOAax32 1DYVFicwa/S808ZrHAIbXlNA8p9mJF0dsEdNDbQPEyJAfGcD8rF415VcK xVGmJas1ly1P4MHBaOEUQXhIe/KXxBjKQGB+1fEGxa0qaR5ywbIvbeJpt pSFLEm+tpjsykvS2hR+vLsXD41oA72LsRqnPnlbx+m4aIA11Oi8o1lYEH 9k6V+5HzaGJf+0FW3zoUluJK3CXgvURkYlc0RxKwSdR3AIWBj4oXrtHXH ZwH4Pdg60b6mf49awK8YbBZ1wizAKq7bHsaM31UsXfFqjx2RPYd2EM+rL A==; X-IronPort-AV: E=McAfee;i="6500,9779,10595"; a="387935241" X-IronPort-AV: E=Sophos;i="5.97,232,1669104000"; d="scan'208";a="387935241" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jan 2023 04:35:28 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10595"; a="692847442" X-IronPort-AV: E=Sophos;i="5.97,232,1669104000"; d="scan'208";a="692847442" Received: from ahunter6-mobl1.ger.corp.intel.com (HELO ahunter-VirtualBox.home\044ger.corp.intel.com) ([10.251.223.163]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jan 2023 04:35:26 -0800 From: Adrian Hunter To: Arnaldo Carvalho de Melo Cc: Jiri Olsa , Namhyung Kim , Ian Rogers , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Subject: [PATCH 06/10] perf symbols: Do not check ss->dynsym twice Date: Fri, 20 Jan 2023 14:34:52 +0200 Message-Id: <20230120123456.12449-7-adrian.hunter@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230120123456.12449-1-adrian.hunter@intel.com> References: <20230120123456.12449-1-adrian.hunter@intel.com> MIME-Version: 1.0 Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1755545032280355053?= X-GMAIL-MSGID: =?utf-8?q?1755545032280355053?= ss->dynsym is checked to be not NULL twice. Remove the first check because, in fact, there can be a plt with no dynsym, which is something that will be dealt with later. Signed-off-by: Adrian Hunter --- tools/perf/util/symbol-elf.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/tools/perf/util/symbol-elf.c b/tools/perf/util/symbol-elf.c index 990a2c6037bb..87b82507c205 100644 --- a/tools/perf/util/symbol-elf.c +++ b/tools/perf/util/symbol-elf.c @@ -386,9 +386,6 @@ int dso__synthesize_plt_symbols(struct dso *dso, struct symsrc *ss) Elf *elf; int nr = 0, symidx, err = -1; - if (!ss->dynsym) - return 0; - elf = ss->elf; ehdr = ss->ehdr;