[v3,2/2] selftests: add tests for prctl(SET_HIDE_SELF_EXE)
Commit Message
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
---
tools/testing/selftests/prctl/Makefile | 2 +-
tools/testing/selftests/prctl/hide-self-exe.c | 114 ++++++++++++++++++
2 files changed, 115 insertions(+), 1 deletion(-)
create mode 100644 tools/testing/selftests/prctl/hide-self-exe.c
Comments
On Fri, Jan 20, 2023 at 11:25:12AM +0100, Giuseppe Scrivano wrote:
> Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
Reviewed-by: Brian Masney <bmasney@redhat.com>
The other patch looks reasonable to me. I'm not familiar with this part
of the kernel so I'm not going to leave a R-b tag on it.
> --- /dev/null
> +++ b/tools/testing/selftests/prctl/hide-self-exe.c
> @@ -0,0 +1,114 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Tests for prctl(PR_GET_HIDE_SELF_EXE, ...) / prctl(PR_SET_HIDE_SELF_EXE, ...)
> + *
> + */
> +
> +#include <stdio.h>
> +#include <stdlib.h>
> +#include <unistd.h>
> +#include <signal.h>
> +#include <inttypes.h>
> +#include <errno.h>
> +#include <fcntl.h>
> +#include <sys/wait.h>
> +
> +#include <sys/prctl.h>
> +#include <linux/prctl.h>
Just a minor nit if you need to post a v4: Sort the includes by name.
Brian
@@ -5,7 +5,7 @@ ARCH ?= $(shell echo $(uname_M) | sed -e s/i.86/x86/ -e s/x86_64/x86/)
ifeq ($(ARCH),x86)
TEST_PROGS := disable-tsc-ctxt-sw-stress-test disable-tsc-on-off-stress-test \
- disable-tsc-test
+ disable-tsc-test hide-self-exe
all: $(TEST_PROGS)
include ../lib.mk
new file mode 100644
@@ -0,0 +1,114 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Tests for prctl(PR_GET_HIDE_SELF_EXE, ...) / prctl(PR_SET_HIDE_SELF_EXE, ...)
+ *
+ */
+
+#include <stdio.h>
+#include <stdlib.h>
+#include <unistd.h>
+#include <signal.h>
+#include <inttypes.h>
+#include <errno.h>
+#include <fcntl.h>
+#include <sys/wait.h>
+
+#include <sys/prctl.h>
+#include <linux/prctl.h>
+
+#ifndef PR_SET_HIDE_SELF_EXE
+# define PR_SET_HIDE_SELF_EXE 65
+# define PR_GET_HIDE_SELF_EXE 66
+#endif
+
+int main(void)
+{
+ int status;
+ pid_t pid;
+ int ret;
+
+ ret = open("/proc/self/exe", O_RDONLY);
+ if (ret < 0) {
+ perror("open /proc/self/exe");
+ exit(EXIT_FAILURE);
+ }
+ close(ret);
+
+ ret = prctl(PR_GET_HIDE_SELF_EXE, 0, 0, 0, 0);
+ if (ret != 0) {
+ perror("prctl(PR_GET_HIDE_SELF_EXE)");
+ exit(EXIT_FAILURE);
+ }
+
+ ret = prctl(PR_SET_HIDE_SELF_EXE, 1, 0, 0, 0);
+ if (ret != 0) {
+ perror("prctl(PR_SET_HIDE_SELF_EXE)");
+ exit(EXIT_FAILURE);
+ }
+
+ /* check it doesn't fail a second time. */
+ ret = prctl(PR_SET_HIDE_SELF_EXE, 1, 0, 0, 0);
+ if (ret != 0) {
+ perror("prctl(PR_SET_HIDE_SELF_EXE)");
+ exit(EXIT_FAILURE);
+ }
+
+ ret = prctl(PR_GET_HIDE_SELF_EXE, 0, 0, 0, 0);
+ if (ret != 1) {
+ perror("prctl(PR_GET_HIDE_SELF_EXE)");
+ exit(EXIT_FAILURE);
+ }
+
+ ret = open("/proc/self/exe", O_RDONLY);
+ if (ret >= 0 || errno != ENOENT) {
+ perror("open /proc/self/exe succeeded");
+ exit(EXIT_FAILURE);
+ }
+
+ pid = fork();
+ if (pid < 0) {
+ perror("fork");
+ exit(EXIT_FAILURE);
+ }
+ if (pid == 0) {
+ /* It cannot be unset after a fork(). */
+ ret = prctl(PR_SET_HIDE_SELF_EXE, 0, 0, 0, 0);
+ if (ret == 0) {
+ perror("prctl(PR_SET_HIDE_SELF_EXE)");
+ exit(EXIT_FAILURE);
+ }
+
+ /* The getter still return the correct value. */
+ ret = prctl(PR_GET_HIDE_SELF_EXE, 0, 0, 0, 0);
+ if (ret != 1) {
+ perror("prctl(PR_GET_HIDE_SELF_EXE)");
+ exit(EXIT_FAILURE);
+ }
+
+ /* It must be unreachable after fork(). */
+ ret = open("/proc/self/exe", O_RDONLY);
+ if (ret >= 0 || errno != ENOENT)
+ exit(EXIT_FAILURE);
+ close(ret);
+
+ /* It can be set again. */
+ ret = prctl(PR_SET_HIDE_SELF_EXE, 1, 0, 0, 0);
+ if (ret != 0) {
+ perror("prctl(PR_SET_HIDE_SELF_EXE)");
+ exit(EXIT_FAILURE);
+ }
+
+ /* HIDE_SELF_EXE is cleared after execve. */
+ ret = system("cat /proc/self/exe > /dev/null");
+ exit(ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE);
+ }
+ if (waitpid(pid, &status, 0) != pid) {
+ perror("waitpid");
+ exit(EXIT_FAILURE);
+ }
+ if (status != 0) {
+ perror("child failed");
+ exit(EXIT_FAILURE);
+ }
+ exit(EXIT_SUCCESS);
+}