From patchwork Fri Jan 20 02:05:36 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rob Herring X-Patchwork-Id: 46091 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp655231wrn; Thu, 19 Jan 2023 18:16:14 -0800 (PST) X-Google-Smtp-Source: AMrXdXue1YJmR3Ag2S14bSsRhL936VD26kMKm0+mt1PyRMCaHg6+WYTWLYYdMviWWBFSJA8pF8Ai X-Received: by 2002:a17:907:6e2a:b0:871:e9a0:eba7 with SMTP id sd42-20020a1709076e2a00b00871e9a0eba7mr17808552ejc.57.1674180974399; Thu, 19 Jan 2023 18:16:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674180974; cv=none; d=google.com; s=arc-20160816; b=mmx9nvjO5JEDGeKCSVzTc/9V5gdf7L7TF7LHl8ObF43Ne60lLkWZpupj4+JP4VPArr OKPOKVC4ospwSUUaVcHF8qugCn3NcBNqXjxNmo3t+Ky639gIBtQ83+eT0HQYOftQZbme paTqJnmQjY0jA8U60OA+rpwp+B8k8MCva7WuiOTggM8HJU/yk4sFg7xpx806I510c1pS U8lG4v/DMXXBbaarxDx+fbp29D/6elmTQtJJh9G770Ns6l4hn1z0/9t2Aw1cbna74/G6 7SshgYts4Z2h8eWIqAtiy8kAGOgnc1mpaspjxPcEPMiOiQRT+OX+xDjLtVkOnfYj6pTJ DpxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=ahhjesBQPoRdOxI0FPgtGG53bpvUK7B+pZWktlNNyHw=; b=yJn+VFG4h8txKrOz/mHs3fcUTue4363zpa4t6tk7fK8Y/6NnxCNdJF0brD0jkeE3om Z60IMN9k8CJciefGeSXGLFI0iE5m7NZP9JV+qgJe0jciMS4W+j1laLnHEiwkNmK9WBCm DlXXccXzU4jXZpLKSfYWYX3QhQvt2Q2sSDCQyRuEqd/kdLSC25jY3bQ0aF6qoeAaDpWF cdnFTJXX1UqeFZdJMGJ8/RbWZr6CyZS7mO5ycC15Wb39dgmBfniGcbuqYywzqCrFEz5o Lp/vZGbaKrO/39lg6qw2jLRhOGTaijNYRWuCzNC3n9Sitc5pa0+0uYWEPADp0TluidRG pCzA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ji22-20020a170907981600b008733a7cc602si10617254ejc.19.2023.01.19.18.15.50; Thu, 19 Jan 2023 18:16:14 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229854AbjATCFv (ORCPT + 99 others); Thu, 19 Jan 2023 21:05:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60288 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229489AbjATCFu (ORCPT ); Thu, 19 Jan 2023 21:05:50 -0500 Received: from mail-oa1-f53.google.com (mail-oa1-f53.google.com [209.85.160.53]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 414DBA5780; Thu, 19 Jan 2023 18:05:49 -0800 (PST) Received: by mail-oa1-f53.google.com with SMTP id 586e51a60fabf-15f83e0fc63so4728595fac.11; Thu, 19 Jan 2023 18:05:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ahhjesBQPoRdOxI0FPgtGG53bpvUK7B+pZWktlNNyHw=; b=DpAyh35U0WNEKT3DcELoBmWIRAZrNOI6r2J7FpvZ6us+uU+Nh2Uy5LjHwl7mD5q+VX LD8oB0VSPKqvPi21BmHkAAroBaogIXEz6AgvueEOcxmv3q04/htjJ/zmUDWZF1iOccTt OQPy6N1Dtt6k4Lqd3fL04Qr0WNzbWednpuIRvektvmYsJZSo5/RM44cun+8zITjKa6X2 UilVP6g/lbjENEjqxIF0Y06dtTPd1XDMaUlCpwHqviYvkqvCaUxUz53ugnzuqT0eoUYc MBb71m//EuOdMvOWTjFjNiOoeixrv21FQuVkKhi19YN1/oNZj/4ZnCIN4/fV1AmVeq6x 8DWQ== X-Gm-Message-State: AFqh2kogduizTXkL5Qlya0EEhFweeisZUv3FzlFGEZgDzdxwU5ZMz63q V2tRXxzFPJZe3O5eg8pPyA== X-Received: by 2002:a05:6870:54d4:b0:15f:2ffe:8d54 with SMTP id g20-20020a05687054d400b0015f2ffe8d54mr7546883oan.47.1674180348439; Thu, 19 Jan 2023 18:05:48 -0800 (PST) Received: from robh_at_kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id z13-20020a05687042cd00b0015f83e16a10sm4073504oah.44.2023.01.19.18.05.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Jan 2023 18:05:47 -0800 (PST) Received: (nullmailer pid 3230582 invoked by uid 1000); Fri, 20 Jan 2023 02:05:47 -0000 From: Rob Herring To: Sean Wang , Linus Walleij , Krzysztof Kozlowski , Matthias Brugger Cc: linux-mediatek@lists.infradead.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] dt-bindings: pinctrl: mediatek: Fix child node name patterns Date: Thu, 19 Jan 2023 20:05:36 -0600 Message-Id: <20230120020536.3229300-1-robh@kernel.org> X-Mailer: git-send-email 2.39.0 MIME-Version: 1.0 X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00, FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1755505989353474296?= X-GMAIL-MSGID: =?utf-8?q?1755505989353474296?= The child node name patterns in Mediatek pinctrl bindings don't match reality. I don't know where '-[0-9]+$' came from, but I don't see any nodes with a matching pattern. Also, patterns such as 'pins' or 'mux' are ambiguous because any prefix or suffix is allowed. If that's desired, it should be explicit. Signed-off-by: Rob Herring --- .../bindings/pinctrl/mediatek,mt65xx-pinctrl.yaml | 12 ++++++------ .../bindings/pinctrl/mediatek,mt7622-pinctrl.yaml | 8 ++++---- .../bindings/pinctrl/mediatek,mt8183-pinctrl.yaml | 8 ++++---- 3 files changed, 14 insertions(+), 14 deletions(-) diff --git a/Documentation/devicetree/bindings/pinctrl/mediatek,mt65xx-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/mediatek,mt65xx-pinctrl.yaml index 1b44335b1e94..a55c8e4ff26e 100644 --- a/Documentation/devicetree/bindings/pinctrl/mediatek,mt65xx-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/mediatek,mt65xx-pinctrl.yaml @@ -70,11 +70,11 @@ allOf: - $ref: "pinctrl.yaml#" patternProperties: - '-[0-9]+$': + 'pins$': type: object additionalProperties: false patternProperties: - 'pins': + '(^pins|pins?$)': type: object additionalProperties: false description: | @@ -158,7 +158,7 @@ examples: , ; - i2c0_pins_a: i2c0-0 { + i2c0_pins_a: i2c0-pins { pins1 { pinmux = , ; @@ -166,7 +166,7 @@ examples: }; }; - i2c1_pins_a: i2c1-0 { + i2c1_pins_a: i2c1-pins { pins { pinmux = , ; @@ -174,7 +174,7 @@ examples: }; }; - i2c2_pins_a: i2c2-0 { + i2c2_pins_a: i2c2-pins { pins1 { pinmux = ; bias-pull-down; @@ -186,7 +186,7 @@ examples: }; }; - i2c3_pins_a: i2c3-0 { + i2c3_pins_a: i2c3-pins { pins1 { pinmux = , ; diff --git a/Documentation/devicetree/bindings/pinctrl/mediatek,mt7622-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/mediatek,mt7622-pinctrl.yaml index c9ea0cad489b..ac93eb8f01a6 100644 --- a/Documentation/devicetree/bindings/pinctrl/mediatek,mt7622-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/mediatek,mt7622-pinctrl.yaml @@ -61,11 +61,11 @@ then: - "#interrupt-cells" patternProperties: - '-[0-9]+$': + '-pins(-[a-z]+)?$': type: object additionalProperties: false patternProperties: - 'mux': + '^mux(-|$)': type: object additionalProperties: false description: | @@ -244,7 +244,7 @@ patternProperties: groups: enum: [wf0_2g, wf0_5g] - 'conf': + '^conf(-|$)': type: object additionalProperties: false description: | @@ -348,7 +348,7 @@ examples: gpio-controller; #gpio-cells = <2>; - pinctrl_eth_default: eth-0 { + pinctrl_eth_default: eth-pins { mux-mdio { groups = "mdc_mdio"; function = "eth"; diff --git a/Documentation/devicetree/bindings/pinctrl/mediatek,mt8183-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/mediatek,mt8183-pinctrl.yaml index 0d2484056a0f..c30cd0d010dd 100644 --- a/Documentation/devicetree/bindings/pinctrl/mediatek,mt8183-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/mediatek,mt8183-pinctrl.yaml @@ -67,11 +67,11 @@ required: - gpio-ranges patternProperties: - '-[0-9]+$': + '-pins(-[a-z]+)?$': type: object additionalProperties: false patternProperties: - 'pins': + '^pins': type: object additionalProperties: false description: | @@ -210,7 +210,7 @@ examples: interrupts = ; #interrupt-cells = <2>; - i2c0_pins_a: i2c-0 { + i2c0_pins_a: i2c0-pins { pins1 { pinmux = , ; @@ -219,7 +219,7 @@ examples: }; }; - i2c1_pins_a: i2c-1 { + i2c1_pins_a: i2c1-pins { pins { pinmux = , ;