diff mbox series

dt-bindings: soc: socionext,uniphier-soc-glue: Make child node names fixed names

Message ID 20230120020339.3223112-1-robh@kernel.org
State New
Headers
Series dt-bindings: soc: socionext,uniphier-soc-glue: Make child node names fixed names |

Commit Message

Rob Herring Jan. 20, 2023, 2:03 a.m. UTC 
  The child nodes 'pinctrl', 'usb-hub', and 'clock-controller' in the
socionext,uniphier-soc-glue binding are not patterns, but the full node
name, so move them to 'properties'. As patterns, they were missing start
and end anchors so any prefix or suffix was allowed.

Fixes: 0611adff8b3a ("dt-bindings: soc: socionext: Add UniPhier SoC-glue logic")
Signed-off-by: Rob Herring <robh@kernel.org>
---
 .../bindings/soc/socionext/socionext,uniphier-soc-glue.yaml      | 1 -
 1 file changed, 1 deletion(-)

Comments

Kunihiko Hayashi Jan. 20, 2023, 4:54 a.m. UTC | #1 
Hi Rob,

On 2023/01/20 11:03, Rob Herring wrote:
> The child nodes 'pinctrl', 'usb-hub', and 'clock-controller' in the
> socionext,uniphier-soc-glue binding are not patterns, but the full node
> name, so move them to 'properties'. As patterns, they were missing start
> and end anchors so any prefix or suffix was allowed.
> 
> Fixes: 0611adff8b3a ("dt-bindings: soc: socionext: Add UniPhier SoC-glue
> logic")
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
>   .../bindings/soc/socionext/socionext,uniphier-soc-glue.yaml      | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git
> a/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-soc-g
> lue.yaml
> b/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-soc-g
> lue.yaml
> index 4b6852db4747..7845dcfca986 100644
> ---
> a/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-soc-g
> lue.yaml
> +++
> b/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-soc-g
> lue.yaml
> @@ -32,7 +32,6 @@ properties:
>     reg:
>       maxItems: 1
>   
> -patternProperties:
>     pinctrl:
>       $ref: /schemas/pinctrl/socionext,uniphier-pinctrl.yaml#
>   

Thanks for pointing out.
This is because I forgot to remove it when I changed the child node,
and it should be removed.

Reviewed-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>

Thank you,

---
Best Regards
Kunihiko Hayashi
Rob Herring Jan. 23, 2023, 9:24 p.m. UTC | #2 
On Thu, 19 Jan 2023 20:03:39 -0600, Rob Herring wrote:
> The child nodes 'pinctrl', 'usb-hub', and 'clock-controller' in the
> socionext,uniphier-soc-glue binding are not patterns, but the full node
> name, so move them to 'properties'. As patterns, they were missing start
> and end anchors so any prefix or suffix was allowed.
> 
> Fixes: 0611adff8b3a ("dt-bindings: soc: socionext: Add UniPhier SoC-glue logic")
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
>  .../bindings/soc/socionext/socionext,uniphier-soc-glue.yaml      | 1 -
>  1 file changed, 1 deletion(-)
> 

Applied, thanks!
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-soc-glue.yaml b/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-soc-glue.yaml
index 4b6852db4747..7845dcfca986 100644
--- a/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-soc-glue.yaml
+++ b/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-soc-glue.yaml
@@ -32,7 +32,6 @@  properties:
   reg:
     maxItems: 1
 
-patternProperties:
   pinctrl:
     $ref: /schemas/pinctrl/socionext,uniphier-pinctrl.yaml#