From patchwork Thu Jan 19 23:44:04 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gavin Shan X-Patchwork-Id: 46060 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp606349wrn; Thu, 19 Jan 2023 15:52:56 -0800 (PST) X-Google-Smtp-Source: AMrXdXsU0kUPAeVp6taI45YgXnUGT5efQ0yUFghcxUUh38ClD9JNQDKSXIN3mwJwD+HOmAapgPLv X-Received: by 2002:a05:6402:3496:b0:48e:9c36:6c39 with SMTP id v22-20020a056402349600b0048e9c366c39mr17905001edc.0.1674172376366; Thu, 19 Jan 2023 15:52:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674172376; cv=none; d=google.com; s=arc-20160816; b=ArIku6qm2wBqIfkK35xSqX/1Rtkuw0SjRPR04g282yMwJ1Oeyf1gSk9vJQ9rMYrjvH 1sMOGGUVHW7VqJl8i3Og1ZeKyzsV42njI4Ix0NLBOiuIQOTrZU2bbUXhReQXEXzK/Kpu G0nlnZbjnVElo5z9lRX8x2d4fHkf10X6FGLrjDp2F9Vu/J9ns4E7vlU3cRFBP7uojlkV RQMH0M531+jwQKaOsCWi9bKt38OoRh1HwwRHDfJmwB1kDBmDKME9SHbm29lvETtx8XsI LfA3pM+njwVuTSG7Gd17hVhAihQt4RJ4wB4ZkI02EMvV8wnfQvaSu5vSKJpo9fissqK6 E1wA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=DP8p6YjB5n3mkUbVX2jmwqTvj2K5FpHC88UY/qgrSK8=; b=OEP+eE8U00dmpsAvU0vgPLnAO7paVOfCAaHn12orepMkDmnHRJNq+oPdPC7DGVE3ii 2mP+PMDo+NKiJMLXj6lbR/FxJINqYvdqigHLKUmxNiHJflnLNeYu3h4ShsVHmNk9dQIL +fAKU00gQFznrp7fjlZEICo3Z7RdvsKRld/lr78zPNiKRRAnC1to5g6l7Mfpgt5S4r+i sC5IHOMgUjTXAPjge6bJ7HwqG579vhWBHPlNvjUI6HwXg2UsqCKvIXCTiolIqahiYh5U tFBV7ynior2/H2u3uqb8R1mZmxMfW5EM/ggNhtHqUo3f5tS56CJCuPvn1h68fneXH0YZ WWsQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="T/rqLtgd"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id eo6-20020a056402530600b00482efc40d58si17318844edb.400.2023.01.19.15.52.32; Thu, 19 Jan 2023 15:52:56 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="T/rqLtgd"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230326AbjASXqP (ORCPT + 99 others); Thu, 19 Jan 2023 18:46:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46140 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230198AbjASXqC (ORCPT ); Thu, 19 Jan 2023 18:46:02 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 62DB59F3A8 for ; Thu, 19 Jan 2023 15:45:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674171914; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DP8p6YjB5n3mkUbVX2jmwqTvj2K5FpHC88UY/qgrSK8=; b=T/rqLtgd7wlhXP3LYzRkuA4mDnm1NJbsVbkg7AQIrV8NhUsDONb+IiL3LkOmCdUGLBRvDx 08jnVp73hT6eN6AxPc1YPqHiq+e4zk7+YSuSpvLWDDlZQF3y8xEA0H8wrAlhTeo7r4+F0P 8TS1hWMp3zwz2JU7Bppc/JcfYnl3RlU= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-549-8qlFck-1Puq6zLbjF-jjIg-1; Thu, 19 Jan 2023 18:45:11 -0500 X-MC-Unique: 8qlFck-1Puq6zLbjF-jjIg-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 48C37801779; Thu, 19 Jan 2023 23:45:10 +0000 (UTC) Received: from gshan.redhat.com (vpn2-54-98.bne.redhat.com [10.64.54.98]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 405282166B2A; Thu, 19 Jan 2023 23:45:02 +0000 (UTC) From: Gavin Shan To: kvmarm@lists.linux.dev Cc: kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, pbonzini@redhat.com, corbet@lwn.net, maz@kernel.org, oliver.upton@linux.dev, will@kernel.org, gshan@redhat.com, ricarkol@google.com, eric.auger@redhat.com, yuzhe@nfschina.com, renzhengeek@gmail.com, reijiw@google.com, ardb@kernel.org, Julia.Lawall@inria.fr, yuzenghui@huawei.com, seanjc@google.com, shan.gavin@gmail.com Subject: [PATCH v2 2/3] KVM: arm64: Allow no running vcpu on restoring vgic3 LPI pending status Date: Fri, 20 Jan 2023 07:44:04 +0800 Message-Id: <20230119234405.349644-3-gshan@redhat.com> In-Reply-To: <20230119234405.349644-1-gshan@redhat.com> References: <20230119234405.349644-1-gshan@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1755496973541582731?= X-GMAIL-MSGID: =?utf-8?q?1755496973541582731?= We don't have a running VCPU context to restore vgic3 LPI pending status due to command KVM_DEV_ARM_{VGIC_GRP_CTRL, ITS_RESTORE_TABLES} on KVM device "kvm-arm-vgic-its". Use vgic_write_guest_lock() to restore vgic3 LPI pending status. Signed-off-by: Gavin Shan --- Documentation/virt/kvm/api.rst | 8 +++++--- arch/arm64/kvm/vgic/vgic-v3.c | 2 +- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/Documentation/virt/kvm/api.rst b/Documentation/virt/kvm/api.rst index 9807b05a1b57..40ada313faa3 100644 --- a/Documentation/virt/kvm/api.rst +++ b/Documentation/virt/kvm/api.rst @@ -8070,9 +8070,11 @@ considering the state as complete. VMM needs to ensure that the dirty state is final and avoid missing dirty pages from another ioctl ordered after the bitmap collection. -NOTE: One example of using the backup bitmap is saving arm64 vgic/its -tables through KVM_DEV_ARM_{VGIC_GRP_CTRL, ITS_SAVE_TABLES} command on -KVM device "kvm-arm-vgic-its" when dirty ring is enabled. +NOTE: Multiple examples of using the backup bitmap: (1) save vgic/its +tables through command KVM_DEV_ARM_{VGIC_GRP_CTRL, ITS_SAVE_TABLES} on +KVM device "kvm-arm-vgic-its". (2) restore vgic/its tables through +command KVM_DEV_ARM_{VGIC_GRP_CTRL, ITS_RESTORE_TABLES} on KVM device +"kvm-arm-vgic-its". vgic3 LPI pending status is restored. 8.30 KVM_CAP_XEN_HVM -------------------- diff --git a/arch/arm64/kvm/vgic/vgic-v3.c b/arch/arm64/kvm/vgic/vgic-v3.c index 2074521d4a8c..2e680d8a0a15 100644 --- a/arch/arm64/kvm/vgic/vgic-v3.c +++ b/arch/arm64/kvm/vgic/vgic-v3.c @@ -339,7 +339,7 @@ int vgic_v3_lpi_sync_pending_status(struct kvm *kvm, struct vgic_irq *irq) if (status) { /* clear consumed data */ val &= ~(1 << bit_nr); - ret = kvm_write_guest_lock(kvm, ptr, &val, 1); + ret = vgic_write_guest_lock(kvm, ptr, &val, 1); if (ret) return ret; }