From patchwork Thu Jan 19 13:39:00 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mikko Perttunen X-Patchwork-Id: 45764 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp340030wrn; Thu, 19 Jan 2023 05:58:01 -0800 (PST) X-Google-Smtp-Source: AMrXdXufl5KSWmdSg5wD7gwwOKlkH7IZqj/o3LKCCYZvXAAx0271fycXeDkY96ci4JtoihqGetcF X-Received: by 2002:a05:6402:1008:b0:47a:e008:8662 with SMTP id c8-20020a056402100800b0047ae0088662mr10643494edu.34.1674136681689; Thu, 19 Jan 2023 05:58:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674136681; cv=none; d=google.com; s=arc-20160816; b=mFgV7CLwuqA7mLPQJ36dRCTSET//JIBu3yCuAiDV3W80Nd1n5wBXK6YoGYwfaBnpjh h4tDNf4LfJzg/AFZzjauAqY+Cwq1js0Nt89Dp91iO81ILuBadFyp0PCrrxrYh65GRagy udy0Op3CsBdEd3R7SrtuJTzNkjB1YgFKbg5KSybIZRldLhu+G5NwNSYJyFpuYlzpsWaO tm2urusQGk4T+ylGWRC0msnRsQmdP/LPGZEXqikFlUJyPvmyaJj1Bh/433sONNTjooBf Fd7JwXIqWi69aQ1KN2eReWzE0gvZr/jmMSTCoqHsfPDwaODyL2FSTnl1cabiB6EJip21 brKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=pSBlzVNRHQd7wtZ4sR6t5nQ9V/Kgda0MekRZ/Y74+PQ=; b=vYDou2S1VmJ76YD13liybAlSA1g4Zt+/d+2cVnlUM9MDj35nWJXN2XzYxI412959Jk oIHvUbVNQ7azJY96R4Hs+eP02fJ0i62m3Jm2DGqbRNrWrRaAU3OFMKe7EjxqB1NBCjos ZS2uqkICSN50RkgKJWCLLPbYEA9e+n0xFcEMCFxV2h+8RRykZt7PxkywLfGsMruWpGWJ fJDrqj1LxKLp4NbzT1GRaarUNMjv3uQk1Uchd2f+Gsppm1Sk/5dKEP6GhbtXt3OvmHaw mEUfAEjfO3hv03Faccvpxl54PZcIvwpvL13B1Prc/2aa2ErUNj3lCI+cu+kAWn2Nuu0X NSHw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@kapsi.fi header.s=20161220 header.b=QIkW7uyH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kapsi.fi Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f11-20020a056402068b00b0048bffdbb775si19353103edy.202.2023.01.19.05.57.37; Thu, 19 Jan 2023 05:58:01 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@kapsi.fi header.s=20161220 header.b=QIkW7uyH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kapsi.fi Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231326AbjASNjU (ORCPT + 99 others); Thu, 19 Jan 2023 08:39:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45258 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230456AbjASNjM (ORCPT ); Thu, 19 Jan 2023 08:39:12 -0500 Received: from mail.kapsi.fi (mail.kapsi.fi [IPv6:2001:67c:1be8::25]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 86FE4521F9; Thu, 19 Jan 2023 05:39:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=kapsi.fi; s=20161220; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=pSBlzVNRHQd7wtZ4sR6t5nQ9V/Kgda0MekRZ/Y74+PQ=; b=QIkW7uyH6M5M7Ab9XQOeyLMYBd uTEDj9wQugKmf8eb6NMkCNjkY0SxwkQhsLlkboZ9YBml4gJE/GFdyyIk3rBkc+KT3SQjGVZPXP4L8 tGLFVRQu/ld48e02pZ38Ob0LRBtoiE5ZNYpiTo41cCGvyrxpwYzRo3FSDIbfeb5yjemf1vpN7beKT z421Jesqv4Ids0xc/golwxoFwjne/VHCaetIStClOovcDntHX1sA0p+tlQH+ZcdwwCCI0LUZbpo6i Avy9jj59IgJb0M1fhQ2ZOFfwfPQ/Gnb2eJhBr0Al66nzOQ75lGW1WKeK10nt9XPLdjrXkPmlwC2Rf rUxH/5CA==; Received: from 91-158-25-70.elisa-laajakaista.fi ([91.158.25.70] helo=toshino.localdomain) by mail.kapsi.fi with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1pIV8H-0016bd-0m; Thu, 19 Jan 2023 15:39:09 +0200 From: Mikko Perttunen To: Thierry Reding , Jonathan Hunter Cc: Mikko Perttunen , linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: [PATCH 3/4] gpu: host1x: Don't skip assigning syncpoints to channels Date: Thu, 19 Jan 2023 15:39:00 +0200 Message-Id: <20230119133901.1892413-3-cyndis@kapsi.fi> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230119133901.1892413-1-cyndis@kapsi.fi> References: <20230119133901.1892413-1-cyndis@kapsi.fi> MIME-Version: 1.0 X-SA-Exim-Connect-IP: 91.158.25.70 X-SA-Exim-Mail-From: cyndis@kapsi.fi X-SA-Exim-Scanned: No (on mail.kapsi.fi); SAEximRunCond expanded to false X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1755459545021344301?= X-GMAIL-MSGID: =?utf-8?q?1755459545021344301?= From: Mikko Perttunen The code to write the syncpoint channel assignment register incorrectly skips the write if hypervisor registers are not available. The register, however, is within the guest aperture so remove the check and assign syncpoints properly even on virtualized systems. Fixes: c3f52220f276 ("gpu: host1x: Enable Tegra186 syncpoint protection") Signed-off-by: Mikko Perttunen --- drivers/gpu/host1x/hw/syncpt_hw.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/host1x/hw/syncpt_hw.c b/drivers/gpu/host1x/hw/syncpt_hw.c index dd39d67ccec3..8cf35b2eff3d 100644 --- a/drivers/gpu/host1x/hw/syncpt_hw.c +++ b/drivers/gpu/host1x/hw/syncpt_hw.c @@ -106,9 +106,6 @@ static void syncpt_assign_to_channel(struct host1x_syncpt *sp, #if HOST1X_HW >= 6 struct host1x *host = sp->host; - if (!host->hv_regs) - return; - host1x_sync_writel(host, HOST1X_SYNC_SYNCPT_CH_APP_CH(ch ? ch->id : 0xff), HOST1X_SYNC_SYNCPT_CH_APP(sp->id));