From patchwork Wed Jan 18 17:47:35 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rakesh Sankaranarayanan X-Patchwork-Id: 45406 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp2480288wrn; Wed, 18 Jan 2023 10:01:26 -0800 (PST) X-Google-Smtp-Source: AMrXdXu5j2HILrWkFgdZrU5VQQuSk7FjBuLoEs0Cn4IZ01HMMOZ8gSvJ/cCAkqyCq8WfMJSi5/HT X-Received: by 2002:a05:6402:501a:b0:47e:bdb8:9133 with SMTP id p26-20020a056402501a00b0047ebdb89133mr10045833eda.38.1674064885986; Wed, 18 Jan 2023 10:01:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674064885; cv=none; d=google.com; s=arc-20160816; b=izu+405cDFDKqVb+vle7L9mEg3lqKhm0GYksc1EvrYOpAUUPC5GmShViwWc10Hasms q2/D+ogjbSjCcOyQS2weEtI/zUxiUuz2im0PO2/jX/w8Bbn9iGeC/G/spC4h98VMtCGN 2RwHszXSYdGhOWe1W0D3lT/s5XAYflqjb3ce4bpjLrW/NmN1xEeN3dCgXDrdHB9snENR Gp6EJ/UUG9tzwaoK8WL0i4607OaU4e42wNzOng9GACLKXBFbBwaWwgTnhpreO0etqonN BIuDOKTDCiioC5kPqkZ68VXa/YQROP/6Qk0F0/EI2WvtUIyEhWPz0i86BjYmuq+hE9px R7+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=XQFWcEIerLs+oM+LE7QT4vFC8slnkT4ZrP4HxuytEgg=; b=Fzcs6j/KZqzQVEejkjq9SGdh1iYC6vXd0A8oPoVVfWPsr5vXsaXSTrSXJg0hlRQbWw /rYcJtppwLMAwI4gfQKVj649qgHHp6yZLdUpgssqd9rdgkNd09bg9IziLRXxdv4h1BV6 dvLNdsfM6DLVcvrqrGMA9JBYEn/XnZ5JlzmA6ZMroYg7+UvQV441zBarlPriaZ/PNBeQ 2D0tqVXz6Wke+dhL9NQ/4aafwE5PuFP656Jc6RpV916Mi5e+3oraPjVaTlnxK8/i6GYN 8LQxOotwkGxCpGYPoo6ROLThXnFadNMPeykeygd8iBT1OWjHwZOqfxwiZXQd0LniiTUB 1XUA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@microchip.com header.s=mchp header.b=jbbVgpMH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=microchip.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x6-20020a05640225c600b0047eb774e2desi26065313edb.527.2023.01.18.10.01.00; Wed, 18 Jan 2023 10:01:25 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@microchip.com header.s=mchp header.b=jbbVgpMH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=microchip.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230062AbjARRsL (ORCPT + 99 others); Wed, 18 Jan 2023 12:48:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45714 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229986AbjARRru (ORCPT ); Wed, 18 Jan 2023 12:47:50 -0500 Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.153.233]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7A7D6CC37; Wed, 18 Jan 2023 09:46:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1674064011; x=1705600011; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=/y2B7Acpa6FvFH8fazzDGApEBpGDAqK/p5/R7++N3iA=; b=jbbVgpMHalHpnfj3NhmdA8JYuPh+GSx+HKNwYTTmD22kkzSMWNPCfy6m oNfQoNrkBnCKp42zr16QuUkllnqd5a3fdtij3GAJPte4UZW6sbKS3Fb4Y I4NDrlKx2SPPoTAzaQi9puu541LYiUtxf3wJaTivnXrSV12Y0I42Qb0Nw lEnjK3AmUXGQ7qWvo3QY+c2BmP6Wwt6a/y2vtOWmN1wiJxWuTEGLOlwWq 546VRGjvcmefOdQaTMOFGRcbLk8LrBoPQqglqlOJmjCLzoxrhiaZsr8S4 XLqNdzAjhOChq0P5xOxClP27H89OAOoeUCna+MPC9vvhtd39Mposws8cR Q==; X-IronPort-AV: E=Sophos;i="5.97,226,1669100400"; d="scan'208";a="197188845" Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa3.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 18 Jan 2023 10:46:49 -0700 Received: from chn-vm-ex02.mchp-main.com (10.10.85.144) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Wed, 18 Jan 2023 10:46:49 -0700 Received: from che-lt-i67786lx.microchip.com (10.10.115.15) by chn-vm-ex02.mchp-main.com (10.10.85.144) with Microsoft SMTP Server id 15.1.2507.16 via Frontend Transport; Wed, 18 Jan 2023 10:46:45 -0700 From: Rakesh Sankaranarayanan To: , CC: , , , , , , , , Subject: [PATCH v2 net] net: dsa: microchip: ksz9477: port map correction in ALU table entry register Date: Wed, 18 Jan 2023 23:17:35 +0530 Message-ID: <20230118174735.702377-1-rakesh.sankaranarayanan@microchip.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1755384262049953359?= X-GMAIL-MSGID: =?utf-8?q?1755384262049953359?= ALU table entry 2 register in KSZ9477 have bit positions reserved for forwarding port map. This field is referred in ksz9477_fdb_del() for clearing forward port map and alu table. But current fdb_del refer ALU table entry 3 register for accessing forward port map. Update ksz9477_fdb_del() to get forward port map from correct alu table entry register. With this bug, issue can be observed while deleting static MAC entries. Delete any specific MAC entry using "bridge fdb del" command. This should clear all the specified MAC entries. But it is observed that entries with self static alone are retained. Tested on LAN9370 EVB since ksz9477_fdb_del() is used common across LAN937x and KSZ series. Fixes: b987e98e50ab ("dsa: add DSA switch driver for Microchip KSZ9477") Signed-off-by: Rakesh Sankaranarayanan Reviewed-by: Vladimir Oltean --- v1->v2 - Based on the community feedback, removed patch from series and added as independent patch. - Added Reviewed-by tag. --- --- drivers/net/dsa/microchip/ksz9477.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/dsa/microchip/ksz9477.c b/drivers/net/dsa/microchip/ksz9477.c index 47b54ecf2c6f..6178a96e389f 100644 --- a/drivers/net/dsa/microchip/ksz9477.c +++ b/drivers/net/dsa/microchip/ksz9477.c @@ -540,10 +540,10 @@ int ksz9477_fdb_del(struct ksz_device *dev, int port, ksz_read32(dev, REG_SW_ALU_VAL_D, &alu_table[3]); /* clear forwarding port */ - alu_table[2] &= ~BIT(port); + alu_table[1] &= ~BIT(port); /* if there is no port to forward, clear table */ - if ((alu_table[2] & ALU_V_PORT_MAP) == 0) { + if ((alu_table[1] & ALU_V_PORT_MAP) == 0) { alu_table[0] = 0; alu_table[1] = 0; alu_table[2] = 0;