From patchwork Wed Jan 18 09:38:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 45147 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp2259881wrn; Wed, 18 Jan 2023 02:37:05 -0800 (PST) X-Google-Smtp-Source: AMrXdXvUS9S/Q0KZ5OKorBDoDnbQjBdXl5krqXcSkAp/oHtpF/b+PAPHdiaKiA4wXHmUe0GiwSdI X-Received: by 2002:a17:906:1f57:b0:872:2cc4:6886 with SMTP id d23-20020a1709061f5700b008722cc46886mr2523685ejk.30.1674038224954; Wed, 18 Jan 2023 02:37:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674038224; cv=none; d=google.com; s=arc-20160816; b=DDm3Djru3nTPa+WywOCNGSndMHwEBhucvz1X4ra4XqAhfYIqDiimb80M8+nJlJ/hmi TSuvtBvZTUCaohptF1cSGLU0fP6C8QFWuj7lag3LGNbmm6NUBqvvKazY1evBypE7aqP8 Mo+/kgr65N0klvYljwBqC02IszBC0bG36FkZK8esIzshjvfa4gVsew1SEVKy5XjUjyr6 Fqt0H2n2/IBOBv8GtrDisLkdZVnPBStR5TJnl6WFVHQvcUVtr53e9K+9w44bSTM7XbyQ 1df6z63mvgMpDHtSScGMP7uyHNEkVJ2NvYcOFBd+xmILjp0ClatISOqPi1bCs2grewKf M2Tw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=T/qp+jqr8SzlwB4U6MWrd3LXWBBVZrR7sjuxyQ0wghI=; b=X+jL3dK6fV0C1T9oaMCS5ao1ENpwmV+AtFArTBSZuy5qaykE7HEInkRP+U/y3oiKjQ hMu9Dff+t7jgJFCJx40krblRK+1qfoDBc7+NL/rRQW/avjwoOSxNT5Lktrzk4ALVJc6h D8ZpPlLCZlgxYSMcx9nWzHTSnnS/WHmMYf2Kx3vZWj28sVKLtt/8Rh2FzsioYDlp1qV6 Zeksj32Fg1aGDyPrT4wyH+tkx2N0FKE179/3T7xT2qKrw/WOQwze0NbR8I3RBSZhBFhJ w4wSbjBzSzQN/qa9aj/nVa/uzxE8dOHyp2LGTSKvPnek+/etxzRHU2uWPF2YEmXazKIE P7JA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=RQvUNhhT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id wy7-20020a170906fe0700b0078df1c345dcsi15258002ejb.535.2023.01.18.02.36.41; Wed, 18 Jan 2023 02:37:04 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=RQvUNhhT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229450AbjARKer (ORCPT + 99 others); Wed, 18 Jan 2023 05:34:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58018 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229786AbjARKck (ORCPT ); Wed, 18 Jan 2023 05:32:40 -0500 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1AFF4BFF5D; Wed, 18 Jan 2023 01:39:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1674034788; x=1705570788; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=OMiVPWb529ClNy6BN+8kKxsiDppRN30QiyN94p7GEAk=; b=RQvUNhhTe4VkwqheKCe64YaQlTv6Ttp4ShYH3DCluGJgpJTZlOP8DW8b RPPqI2uiWRWk0zHyrFdePGy1qmqiOcKoQ4t5524B7JlfDqjD6R++VoO/h 7lHaRFAWgowxMwf7E1PdzycnArRXwtN29lo2x0DAoahXB7mnRHDzz9cPc M3cED6TFDWhAX9TjnpBVXZQi94qZjz4C2X/VXCbVF8ajiQ/DAuXyhA9ya yJprOCUbYuvzafCZkIgiVAsPi06Ps7lnqdbuKsdAjVOKLcbnphN/ECGxv DZZSsAhlIwBDEiIBZt/CnE+sbGL7bDCTkDFlfiFGQXRAZf6VEsADj9wdb Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10593"; a="322631760" X-IronPort-AV: E=Sophos;i="5.97,224,1669104000"; d="scan'208";a="322631760" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jan 2023 01:37:53 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10593"; a="609580387" X-IronPort-AV: E=Sophos;i="5.97,224,1669104000"; d="scan'208";a="609580387" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga003.jf.intel.com with ESMTP; 18 Jan 2023 01:37:50 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id 4C916368; Wed, 18 Jan 2023 11:38:25 +0200 (EET) From: Andy Shevchenko To: Hans de Goede , Andy Shevchenko , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Maximilian Luz , Mark Gross Subject: [PATCH v1 1/1] platform/surface: Switch to use acpi_evaluate_dsm_typed() Date: Wed, 18 Jan 2023 11:38:23 +0200 Message-Id: <20230118093823.39679-1-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.39.0 MIME-Version: 1.0 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1755356305903866105?= X-GMAIL-MSGID: =?utf-8?q?1755356305903866105?= The acpi_evaluate_dsm_typed() provides a way to check the type of the object evaluated by _DSM call. Use it instead of open coded variant. Signed-off-by: Andy Shevchenko Reviewed-by: Maximilian Luz --- drivers/platform/surface/surface_hotplug.c | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/drivers/platform/surface/surface_hotplug.c b/drivers/platform/surface/surface_hotplug.c index f004a2495201..7b6d887dccdb 100644 --- a/drivers/platform/surface/surface_hotplug.c +++ b/drivers/platform/surface/surface_hotplug.c @@ -101,18 +101,12 @@ static void shps_dsm_notify_irq(struct platform_device *pdev, enum shps_irq_type param.type = ACPI_TYPE_INTEGER; param.integer.value = value; - result = acpi_evaluate_dsm(handle, &shps_dsm_guid, SHPS_DSM_REVISION, - shps_dsm_fn_for_irq(type), ¶m); - + result = acpi_evaluate_dsm_typed(handle, &shps_dsm_guid, SHPS_DSM_REVISION, + shps_dsm_fn_for_irq(type), ¶m, ACPI_TYPE_BUFFER); if (!result) { dev_err(&pdev->dev, "IRQ notification via DSM failed (irq=%d, gpio=%d)\n", type, value); - } else if (result->type != ACPI_TYPE_BUFFER) { - dev_err(&pdev->dev, - "IRQ notification via DSM failed: unexpected result type (irq=%d, gpio=%d)\n", - type, value); - } else if (result->buffer.length != 1 || result->buffer.pointer[0] != 0) { dev_err(&pdev->dev, "IRQ notification via DSM failed: unexpected result value (irq=%d, gpio=%d)\n", @@ -121,8 +115,7 @@ static void shps_dsm_notify_irq(struct platform_device *pdev, enum shps_irq_type mutex_unlock(&sdev->lock[type]); - if (result) - ACPI_FREE(result); + ACPI_FREE(result); } static irqreturn_t shps_handle_irq(int irq, void *data)