From patchwork Wed Jan 18 09:37:17 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kemeng Shi X-Patchwork-Id: 44918 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp2085128wrn; Tue, 17 Jan 2023 17:42:00 -0800 (PST) X-Google-Smtp-Source: AMrXdXt+KMoGawW+j7urPt0EBjlvjckK/RQDF6J386yYZipHm554V1S7Wnq/RzrBZuqGC1tdvm3N X-Received: by 2002:a17:90a:e28d:b0:229:c20:9cc5 with SMTP id d13-20020a17090ae28d00b002290c209cc5mr22287777pjz.41.1674006119957; Tue, 17 Jan 2023 17:41:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674006119; cv=none; d=google.com; s=arc-20160816; b=fKELEhjYpcHXBhUy8m8QMgs4BYCtqK3MbpM+du8D9sVZXcd8rpC2qaWeJ6fOelqE1J UUy+QAheFXKs4lblKl/oEWZEW/zUlKKXiZwDXzfaLbp5tcLjy1SEOziREgrqsePtxj+p L/zONEWloPQgwvuSxwN5zu3v0w/1w5t00LQlboHu4NDWt2nlwKuo+2iIyidaZkRGwWfK mRWhva9GCJXw20c9FGo4Sp+SNbbbDa/rB63Zlr67zey9hFuHliO5BoPTJvGGpE+3y5W5 Jv1pQttO8LSjNEXXcUxLL6nbh9WuJnIRTRBscOHHoNPXZnY+tvwdgdpYyZwjjOtXRw1j /a0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=A9qw/z8SnbUUeaFo8bCjA6BhpQYU34rkgtbDWgrH3XM=; b=jWSX6bXjBQTM0eIRvv7ofmdMbXQED+rIduBuMb9NaTkJwJML7fM2FOsjpfktTjBra9 1+D6AqsO1SlXWs8Uvpb/mW2ZOpvyDg5nnmurZTmXGoT5KuopD9LabjFW16OdM2wpEWao b+tVkFN27cXkmMEnTHvxlSwEm1Xh1SatzU5ARPsnVJPSKT4T3FSXbslyvo1xGLzqIqy9 t7dYQe8h7RBkwVy3YP5qzH2ozW+mEMeXT1Ac8UpNGRd+pX+PKicl8x4QsVUDUj3RmtS1 PH+QzQoCsQysRzJ8FuIWAWhxnsmf/QM3qL/rhQBSju3paG8nRlyfZCxKg/7NGkCuUx0T Vxpg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 195-20020a6302cc000000b004ce0ead7aabsi5758384pgc.302.2023.01.17.17.41.47; Tue, 17 Jan 2023 17:41:59 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229898AbjARBjy (ORCPT + 99 others); Tue, 17 Jan 2023 20:39:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54804 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229759AbjARBjF (ORCPT ); Tue, 17 Jan 2023 20:39:05 -0500 Received: from dggsgout12.his.huawei.com (dggsgout12.his.huawei.com [45.249.212.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1374F51C52; Tue, 17 Jan 2023 17:39:02 -0800 (PST) Received: from mail02.huawei.com (unknown [172.30.67.143]) by dggsgout12.his.huawei.com (SkyGuard) with ESMTP id 4NxT1r5QP4z4f44jn; Wed, 18 Jan 2023 09:38:56 +0800 (CST) Received: from huaweicloud.com (unknown [10.175.124.27]) by APP2 (Coremail) with SMTP id Syh0CgDnjOqxTcdjBACUBw--.30342S6; Wed, 18 Jan 2023 09:38:59 +0800 (CST) From: Kemeng Shi To: hch@lst.de, axboe@kernel.dk, dwagner@suse.de, hare@suse.de, ming.lei@redhat.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Cc: john.garry@huawei.com, jack@suse.cz Subject: [PATCH v4 05/14] blk-mq: remove unnecessary list_empty check in blk_mq_try_issue_list_directly Date: Wed, 18 Jan 2023 17:37:17 +0800 Message-Id: <20230118093726.3939160-5-shikemeng@huaweicloud.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20230118093726.3939160-1-shikemeng@huaweicloud.com> References: <20230118093726.3939160-1-shikemeng@huaweicloud.com> MIME-Version: 1.0 X-CM-TRANSID: Syh0CgDnjOqxTcdjBACUBw--.30342S6 X-Coremail-Antispam: 1UD129KBjvdXoWrKr1xWry5Kw1Utw48Ww18uFg_yoWDArX_uF y0yw1kXayDJF17Ar4j93WIyFn8K34kGr1fXFZ7KF98GryfXFs8Was5KF4rZ3y7Ca17K343 ur1rXF9Fyr10gjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbSxYFVCjjxCrM7AC8VAFwI0_Wr0E3s1l1xkIjI8I6I8E6xAIw20E Y4v20xvaj40_Wr0E3s1l1IIY67AEw4v_Jr0_Jr4l87I20VAvwVAaII0Ic2I_JFv_Gryl82 xGYIkIc2x26280x7IE14v26r126s0DM28IrcIa0xkI8VCY1x0267AKxVW5JVCq3wA2ocxC 64kIII0Yj41l84x0c7CEw4AK67xGY2AK021l84ACjcxK6xIIjxv20xvE14v26w1j6s0DM2 8EF7xvwVC0I7IYx2IY6xkF7I0E14v26r4UJVWxJr1l84ACjcxK6I8E87Iv67AKxVW0oVCq 3wA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_GcCE3s1le2I262IYc4CY6c8Ij28IcVAaY2xG8w Aqx4xG64xvF2IEw4CE5I8CrVC2j2WlYx0E2Ix0cI8IcVAFwI0_JrI_JrylYx0Ex4A2jsIE 14v26r1j6r4UMcvjeVCFs4IE7xkEbVWUJVW8JwACjcxG0xvY0x0EwIxGrwCF04k20xvY0x 0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F40E14v26r1j6r18MI8I3I0E 7480Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_Jw0_GFylIxkGc2Ij64vIr41lIxAIcV C0I7IYx2IY67AKxVWUCVW8JwCI42IY6xIIjxv20xvEc7CjxVAFwI0_Cr0_Gr1UMIIF0xvE 42xK8VAvwI8IcIk0rVWUJVWUCwCI42IY6I8E87Iv67AKxVWUJVW8JwCI42IY6I8E87Iv6x kF7I0E14v26r4j6r4UJbIYCTnIWIevJa73UjIFyTuYvjxUxD7aUUUUU X-CM-SenderInfo: 5vklyvpphqwq5kxd4v5lfo033gof0z/ X-CFilter-Loop: Reflected X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_00,DATE_IN_FUTURE_06_12, SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1755322641684677968?= X-GMAIL-MSGID: =?utf-8?q?1755322641684677968?= We only break the list walk if we get 'BLK_STS_*RESOURCE'. We also count errors for 'BLK_STS_*RESOURCE' error. If list is not empty, errors will always be non-zero. So we can remove unnecessary list_empty check. This will remove redundant list_empty check for case that error happened at sending last request in list. Reviewed-by: Christoph Hellwig Signed-off-by: Kemeng Shi --- block/blk-mq.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/block/blk-mq.c b/block/blk-mq.c index 6eb23bbe1787..7160af49c245 100644 --- a/block/blk-mq.c +++ b/block/blk-mq.c @@ -2839,8 +2839,7 @@ void blk_mq_try_issue_list_directly(struct blk_mq_hw_ctx *hctx, * the driver there was more coming, but that turned out to * be a lie. */ - if ((!list_empty(list) || errors) && - hctx->queue->mq_ops->commit_rqs && queued) + if (errors && hctx->queue->mq_ops->commit_rqs && queued) hctx->queue->mq_ops->commit_rqs(hctx); }