From patchwork Wed Jan 18 08:43:41 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?b?Q2h1bmZlbmcgWXVuICjkupHmmKXls7Ap?= X-Patchwork-Id: 45116 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp2233118wrn; Wed, 18 Jan 2023 01:28:40 -0800 (PST) X-Google-Smtp-Source: AMrXdXv1LD2GK9wnUtLTXsEcdhZ9mIn0faSoMLoPasgem9rmV7Gpgcj+RrQAvDtvWtxWyZrST4XJ X-Received: by 2002:a05:6a00:124d:b0:58d:ee7c:6cca with SMTP id u13-20020a056a00124d00b0058dee7c6ccamr365522pfi.1.1674034120311; Wed, 18 Jan 2023 01:28:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674034120; cv=none; d=google.com; s=arc-20160816; b=fj8N09R34rMVA1OvOWdY5qgOM9uBkeZaXzR4mNDAqSHnUrapEP2LjY5bVn0+I8ppu/ G52mmMFQgirYxH9utKFYvI91KLhocAhnu1BLr/jKWeEGoY+MHL58ZsFhGuhCyF6Wirlg gAGPwJBgmeQTw8utnxJlOjRdqEM7THt/dDNIOpti3/iVdLD0klgN5/ZYedOf2j86bvtN O2feAgSLic7D5EAfiqaxQuBKLBCjoxne5RJAsPGW8zvTP2V1TeWb0X1YiMjHIAOZSHaL cJ1maYVcV7cheu8ZSo2Ja1HdbcSrhSNP/AN2cMu2TxIQocC/shAD5yE0X5pJxhN4xd4h qyoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=RMsEjrNX6H23fsk7/ozyqr2EUputJ3iJ5LlAwuMnTaI=; b=WPONs9oOWt7eDyZ2WrSfqnthJeN7rCQill4pI1Y/qacj0kHJ1TjJUooE+CjMoVG3IP zUSaT7D17vuzOvN0i0jJwn9DwFVhMPxMjhhiGSKw99XW3Fk5kqx1aVwfawmFJmx6E9Ug q18m7zpImcyaCefWppTCXnjh3juOj9Y7ckRtSL96QBZkjmOOzuj4X36uZBJ53Rgo7vJT O3JiyYqrHOwr99V4yz3fnzldDzTLVwLUWHEM9TedeWp3OTp6b2qBBzdPIqeixZsmPxxe kcS9lSBWecpNjaHyS/AkuIAj1HLpFj4gM9k0PPEHTw4yQcG7bnbC2k+c8AojxffpjUkk enmg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mediatek.com header.s=dk header.b=QQjbedCW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=mediatek.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m9-20020a056a00080900b0057791522cb6si38239585pfk.275.2023.01.18.01.28.28; Wed, 18 Jan 2023 01:28:40 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@mediatek.com header.s=dk header.b=QQjbedCW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=mediatek.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229983AbjARJZe (ORCPT + 99 others); Wed, 18 Jan 2023 04:25:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45500 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230096AbjARJVP (ORCPT ); Wed, 18 Jan 2023 04:21:15 -0500 Received: from mailgw02.mediatek.com (unknown [210.61.82.184]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 835BD5D12F for ; Wed, 18 Jan 2023 00:43:54 -0800 (PST) X-UUID: 381f4760970c11ed945fc101203acc17-20230118 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Type:Content-Transfer-Encoding:MIME-Version:Message-ID:Date:Subject:CC:To:From; bh=RMsEjrNX6H23fsk7/ozyqr2EUputJ3iJ5LlAwuMnTaI=; b=QQjbedCWEVP2lYXaCh0VZn5C03pLV4345viEjd/Zx0vNR7O5aNLCrGETqZDdSuI14iWM2pJA8gRI5CMlDHDbcUwEiaxkfH1X7ZAi3YkbTPA+WiEWplta2vXcdEjr9PaREhdlHrfDfjy77LrwOYjJkk5bnErYT1mb6TppC2/27Dk=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.18,REQID:38b77898-514e-4990-8e28-1d6d965c8261,IP:0,U RL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION: release,TS:0 X-CID-META: VersionHash:3ca2d6b,CLOUDID:7841ff54-dd49-462e-a4be-2143a3ddc739,B ulkID:nil,BulkQuantity:0,Recheck:0,SF:102,TC:nil,Content:0,EDM:-3,IP:nil,U RL:11|1,File:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,OSI:0,OSA:0 X-CID-BVR: 0 X-UUID: 381f4760970c11ed945fc101203acc17-20230118 Received: from mtkmbs10n2.mediatek.inc [(172.21.101.183)] by mailgw02.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 863658094; Wed, 18 Jan 2023 16:43:45 +0800 Received: from mtkmbs11n1.mediatek.inc (172.21.101.185) by mtkmbs11n1.mediatek.inc (172.21.101.185) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.792.15; Wed, 18 Jan 2023 16:43:45 +0800 Received: from mhfsdcap04.gcn.mediatek.inc (10.17.3.154) by mtkmbs11n1.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.792.15 via Frontend Transport; Wed, 18 Jan 2023 16:43:44 +0800 From: Chunfeng Yun To: Vinod Koul CC: Chunfeng Yun , Kishon Vijay Abraham I , Matthias Brugger , Nathan Chancellor , Nick Desaulniers , Tom Rix , AngeloGioacchino Del Regno , , , , , , Eddie Hung , kernel test robot Subject: [PATCH v7 1/3] phy: mediatek: remove temporary variable @mask_ Date: Wed, 18 Jan 2023 16:43:41 +0800 Message-ID: <20230118084343.26913-1-chunfeng.yun@mediatek.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-MTK: N X-Spam-Status: No, score=-1.3 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_MSPIKE_H2,RDNS_NONE, SPF_HELO_PASS,T_SPF_TEMPERROR,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1755352001797213518?= X-GMAIL-MSGID: =?utf-8?q?1755352001797213518?= Remove the temporary @mask_, this may cause build warning when use clang compiler for powerpc, but can't reproduce it when compile for arm64. the build warning is caused by: "warning: result of comparison of constant 18446744073709551615 with expression of type (aka 'unsigned long') is always false [-Wtautological-constant-out-of-range-compare]" More information provided in below lore link. After removing @mask_, there is a "CHECK:MACRO_ARG_REUSE" when run checkpatch.pl, but due to @mask is constant, no reuse problem will happen. Link: https://lore.kernel.org/lkml/202212160357.jJuesD8n-lkp@intel.com/t/ Fixes: 84513eccd678 ("phy: mediatek: fix build warning of FIELD_PREP()") Reported-by: kernel test robot Signed-off-by: Chunfeng Yun Reviewed-by: AngeloGioacchino Del Regno --- v7: modify title suggested by Vinod, modify commit message and add link tag suggested by Nick v6: modify the title v5: no changes v4 new patch, I'm not sure it can fix build warning, due to I don't cross compile it for powerpc using clang in office. --- drivers/phy/mediatek/phy-mtk-io.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/phy/mediatek/phy-mtk-io.h b/drivers/phy/mediatek/phy-mtk-io.h index d20ad5e5be81..58f06db822cb 100644 --- a/drivers/phy/mediatek/phy-mtk-io.h +++ b/drivers/phy/mediatek/phy-mtk-io.h @@ -39,8 +39,8 @@ static inline void mtk_phy_update_bits(void __iomem *reg, u32 mask, u32 val) /* field @mask shall be constant and continuous */ #define mtk_phy_update_field(reg, mask, val) \ ({ \ - typeof(mask) mask_ = (mask); \ - mtk_phy_update_bits(reg, mask_, FIELD_PREP(mask_, val)); \ + BUILD_BUG_ON_MSG(!__builtin_constant_p(mask), "mask is not constant"); \ + mtk_phy_update_bits(reg, mask, FIELD_PREP(mask, val)); \ }) #endif