From patchwork Tue Jan 17 03:49:21 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Baoquan He X-Patchwork-Id: 44484 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp1543041wrn; Mon, 16 Jan 2023 19:52:15 -0800 (PST) X-Google-Smtp-Source: AMrXdXs2dyxa/zh8Ock0RGRmG8xciEKI9OkXpyp5b5JdeLP/6A2yVjX8uzLRmbn+rMELxAotc4Le X-Received: by 2002:a05:6402:2419:b0:49d:2a42:b8c8 with SMTP id t25-20020a056402241900b0049d2a42b8c8mr1749894eda.26.1673927535759; Mon, 16 Jan 2023 19:52:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673927535; cv=none; d=google.com; s=arc-20160816; b=ol5VrN36yjPd0fjm56IEueeZjDhBeugJZ8nAkeHiCFE2B0KGwNa8B9Ni30itFHO2wn 8P+7Et6OPtqjTXJ3RC7SeCVBKKRlB9+DZySv1R/xCLr7NGq+ZFTmEof4Pv2/qWxLfUtu 9NiNV3jJ/tC5Qx1kS1aYzDVoOknHCVEJqypPdUqevjoT77dtC3AwXjQO2nd29H7cvWPp Db1XrPHGb94PLwZ6zSHsBIWy/1Y1MGYDUA3ywZuZO8S1usQwKPmyQme5JI7yHT5d8d5H qWELmTRibsz97gGBgAeYT72lBZNn+t1qbxId19J2PvjvvQ5OGwiEhzmnFzbKP0bvFUDX oE7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Tq8BWi7KIMXK19sTfFEOHzGCHbw3j+yt4nwzlz7Cvoc=; b=kcrxIMq36UPzvqZW2dmJP/KE502WayoeSyKSB3yOwWwjDVxKxVyE+SnJIDz1XpDFop bdws8IGsZpxv10zSRJDjfQeoljCR2o/OtgymBX9Wg6A9JPtfukcA/1wk0BMQNwaJIXGQ MX1220i5in5gPEaMVlHejHzfgjYwI+WClQdS3U4Gkiig69dS29INkCmSrm1OtmEjdm5q 5QEMdNEWo+pQo6w2otShq+9h1+NWPUjx0m3RZ6eITCgriVEhggb0fuSQ6KWKUu7ySoop USIjJBDXslKC+obc8v5VhnzP6L8FYzYJ2voU/0h606zqa94zjLPkZHiasPX2SeVskyMH JnwQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=dYKtc0ph; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q8-20020a056402518800b0048c87c7ebbfsi9830987edd.256.2023.01.16.19.51.52; Mon, 16 Jan 2023 19:52:15 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=dYKtc0ph; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235399AbjAQDup (ORCPT + 99 others); Mon, 16 Jan 2023 22:50:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46694 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235501AbjAQDuf (ORCPT ); Mon, 16 Jan 2023 22:50:35 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8F12E227A6 for ; Mon, 16 Jan 2023 19:49:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673927387; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Tq8BWi7KIMXK19sTfFEOHzGCHbw3j+yt4nwzlz7Cvoc=; b=dYKtc0ph2+IQw29dI1QR2keVO8rJAia7hkB7v10J6o+Kn7H0Z5UXzROAWVWspmeGrwU3eo 6ZNJWw3CHy1h5jB6Auu+NqneVPBTo148oY/jlkTaA9BCRdnCWnMaWYhYHFjj+C+uzmXZLc sX2qQFcaJeTlqUaR4YuhfNFx7UTTrOw= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-487-upN5m9UrNDW622U8L_BpjQ-1; Mon, 16 Jan 2023 22:49:41 -0500 X-MC-Unique: upN5m9UrNDW622U8L_BpjQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id CA8EA101A52E; Tue, 17 Jan 2023 03:49:40 +0000 (UTC) Received: from fedora.redhat.com (ovpn-12-229.pek2.redhat.com [10.72.12.229]) by smtp.corp.redhat.com (Postfix) with ESMTP id D146A14171B8; Tue, 17 Jan 2023 03:49:35 +0000 (UTC) From: Baoquan He To: linux-kernel@vger.kernel.org Cc: kexec@lists.infradead.org, linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com, will@kernel.org, thunder.leizhen@huawei.com, John.p.donnelly@oracle.com, wangkefeng.wang@huawei.com, Baoquan He Subject: [PATCH 2/2] arm64/kdump: add code comments for crashkernel reservation cases Date: Tue, 17 Jan 2023 11:49:21 +0800 Message-Id: <20230117034921.185150-3-bhe@redhat.com> In-Reply-To: <20230117034921.185150-1-bhe@redhat.com> References: <20230117034921.185150-1-bhe@redhat.com> MIME-Version: 1.0 Content-type: text/plain X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1755240239820601600?= X-GMAIL-MSGID: =?utf-8?q?1755240239820601600?= This will help understand codes on crashkernel reservations on arm64. Signed-off-by: Baoquan He --- arch/arm64/mm/init.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/arch/arm64/mm/init.c b/arch/arm64/mm/init.c index 26a05af2bfa8..f88ad17cb20d 100644 --- a/arch/arm64/mm/init.c +++ b/arch/arm64/mm/init.c @@ -177,6 +177,10 @@ static void __init reserve_crashkernel(void) crash_base = memblock_phys_alloc_range(crash_size, CRASH_ALIGN, search_base, crash_max); if (!crash_base) { + /* + * For crashkernel=size[KMG]@offset[KMG], print out failure + * message if can't reserve the specified region. + */ if (fixed_base) { pr_warn("cannot reserve crashkernel region [0x%llx-0x%llx]\n", search_base, crash_max); @@ -188,6 +192,11 @@ static void __init reserve_crashkernel(void) * high memory, the minimum required low memory will be * reserved later. */ + /* + * For crashkernel=size[KMG], if the first attempt was for + * low memory, fall back to high memory, the minimum required + * low memory will be reserved later. + */ if (!high && crash_max == CRASH_ADDR_LOW_MAX) { crash_max = CRASH_ADDR_HIGH_MAX; search_base = CRASH_ADDR_LOW_MAX; @@ -195,6 +204,10 @@ static void __init reserve_crashkernel(void) goto retry; } + /* + * For crashkernel=size[KMG],high, if the first attempt was for + * high memory, fall back to low memory. + */ if (high && (crash_max == CRASH_ADDR_HIGH_MAX)) { crash_max = CRASH_ADDR_LOW_MAX; search_base = 0;