From patchwork Mon Jan 16 21:07:15 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fedor Pchelkin X-Patchwork-Id: 44320 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp1402389wrn; Mon, 16 Jan 2023 13:10:30 -0800 (PST) X-Google-Smtp-Source: AMrXdXvy5rRSDKZHo2ZmInWRXq19aBtyC0tTvvw3PG+kCDaTE++6N5+aa+wxmIPT09unISnYrGuT X-Received: by 2002:a17:907:6746:b0:84d:1c67:97d7 with SMTP id qm6-20020a170907674600b0084d1c6797d7mr431228ejc.30.1673903429886; Mon, 16 Jan 2023 13:10:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673903429; cv=none; d=google.com; s=arc-20160816; b=0kLKeBImOW3tZDfiG4uPq5s+FaJ3OA6RcL5RPR+Sz68b7tEVx4FB0rEMWfNSp76lwS AJ7ZTKAgc9O4DFNwSDtzKg1Mam4aacxNQIzO8Ptj+4+EiDcqPXwTLDeg6YTvGnRGzBlh Ibal4U4YnP/1lxMxub3CKURTijEmL6zHatF18t1PHSFpfJ37Ku2Yo90J+5Eq88B7ai17 SeCcwdpmHTgHK6idfJR7yBmAd5QwkXM1iMbSxDdqb0TwAegi73QbkDjlH1rkPDqPVf8Y zuDJAC3W95EtHZcd0+ZHd7xja8YlZdfM9kWSZ3yhU2n+vt+WXbsg6cPvXRJ27fsYA/LL BA1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature:dkim-filter; bh=rQOetvwWdAUv1lwzSus1er84FdlFidvK55jo5RaZJyE=; b=t7KIhxUBStFqpXets1TkCeXF01eycCURfLMU2KaBPuzGCsiQtH09RG1qAb4BcL0MbN q7mRTSKYOWERinxSxBt4S+KjRotQosY+OwEMctygWqQWTX6JiNt4PR3igKwL/Wm+pd5O kn6Nj2jCP0ojTwx+piN4sYk0KjcCKx7mlcOrQCrrxPG007/kHeTBYLP8ijH2zmwAZi6R TxWxJGZh1VH8vJTj8BL7wUZrTiBg1E44a2E388GhFn2uPMtDq8d8eeXWlSgwq2yIS+fk TbSsy3sWiR8VdIJCZZDUWMsaGRGOR/9Qj9qWql+UJhfPMy/3WrlwkuWTTd5wQn4BZqqX ctYg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ispras.ru header.s=default header.b=SzguAJ19; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ispras.ru Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id dm3-20020a170907948300b0086be614f647si10754367ejc.472.2023.01.16.13.10.05; Mon, 16 Jan 2023 13:10:29 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@ispras.ru header.s=default header.b=SzguAJ19; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ispras.ru Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231268AbjAPVH3 (ORCPT + 99 others); Mon, 16 Jan 2023 16:07:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55364 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231719AbjAPVH1 (ORCPT ); Mon, 16 Jan 2023 16:07:27 -0500 Received: from mail.ispras.ru (mail.ispras.ru [83.149.199.84]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 59A907EC7; Mon, 16 Jan 2023 13:07:26 -0800 (PST) Received: from fedcomp.intra.ispras.ru (unknown [46.242.14.200]) by mail.ispras.ru (Postfix) with ESMTPSA id B13FD40D403D; Mon, 16 Jan 2023 21:07:24 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 mail.ispras.ru B13FD40D403D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ispras.ru; s=default; t=1673903244; bh=rQOetvwWdAUv1lwzSus1er84FdlFidvK55jo5RaZJyE=; h=From:To:Cc:Subject:Date:From; b=SzguAJ19hNxPcJIhtAXcJPYWU/G5jdrBo9mGeZ5BOEe1S7bT1i4f++7kpLWfjz4vj oO/IEaeDpS04CdsKvqLPB6XD9geNgypaQ5azEJsnwr+/eAExcX7j+gpgYR6f5cePC1 EaNOeRLCCf8/Oi/b5zGbPBClWAfO0LToEoAY0sOE= From: Fedor Pchelkin To: stable@vger.kernel.org, Greg Kroah-Hartman Cc: Fedor Pchelkin , Jens Axboe , Christoph Hellwig , Chaitanya Kulkarni , Johannes Thumshirn , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Alexey Khoroshilov Subject: [PATCH 5.4] block: fix and cleanup bio_check_ro Date: Tue, 17 Jan 2023 00:07:15 +0300 Message-Id: <20230116210715.805574-1-pchelkin@ispras.ru> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1755214733021706053?= X-GMAIL-MSGID: =?utf-8?q?1755214963133125380?= From: Christoph Hellwig commit 57e95e4670d1126c103305bcf34a9442f49f6d6a upstream. Don't use a WARN_ONCE when printing a potentially user triggered condition. Signed-off-by: Christoph Hellwig Reviewed-by: Chaitanya Kulkarni Reviewed-by: Johannes Thumshirn Link: https://lore.kernel.org/r/20220304180105.409765-2-hch@lst.de Signed-off-by: Jens Axboe Signed-off-by: Fedor Pchelkin --- block/blk-core.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/block/blk-core.c b/block/blk-core.c index 5808baa950c3..030de4fdf9b1 100644 --- a/block/blk-core.c +++ b/block/blk-core.c @@ -793,10 +793,7 @@ static inline bool bio_check_ro(struct bio *bio, struct hd_struct *part) if (op_is_flush(bio->bi_opf) && !bio_sectors(bio)) return false; - - WARN_ONCE(1, - "generic_make_request: Trying to write " - "to read-only block-device %s (partno %d)\n", + pr_warn("Trying to write to read-only block-device %s (partno %d)\n", bio_devname(bio, b), part->partno); /* Older lvm-tools actually trigger this */ return false;