From patchwork Mon Jan 16 14:01:52 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Philippe Schenker X-Patchwork-Id: 44177 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp1229975wrn; Mon, 16 Jan 2023 06:48:33 -0800 (PST) X-Google-Smtp-Source: AMrXdXvLRkJ/yXQ0p4k176LC0ECR0ZqZzZcP3kJjXt1wEXBDin7z3XBdVpbhxfVhLAswaAl52+te X-Received: by 2002:a17:902:7787:b0:194:5d26:11cc with SMTP id o7-20020a170902778700b001945d2611ccmr31127pll.6.1673880512776; Mon, 16 Jan 2023 06:48:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673880512; cv=none; d=google.com; s=arc-20160816; b=E2cg0wBES5jvjEnk/mWSDa/EN0sBedq9TcMQNDDVNIY9LVDRECJNFqtMwmf6mjFBNU efUtgaL8iiHGg8wCVimLNcnXqu8nqVrIadN6SXBfxJVrCEWVEVEGYUyM+jqMLW/LZtCz sRIijABkdzwfFGPs4ScT94oZE00uTTZWNw6dZf6zGbpOJdrvV8kJfEoKQTk6eeUcv3ru G3Y3jt0XyoJG8y5qr18a4bA1494NgH+LIJmcCR7X77EXDnA9GzCX37taUueglmYCzmRB WtkLC++P40PsK+TH+bTO/DMViu4qOW8BtSHK0IbHs8BXiPQOQ/BNqI83hkwfj7JpldYK er4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=EZFxb5Rh42+bJPjY9+p9jOnwxidUyTiU4E1AxpPtRK0=; b=kDL493y6AHN0s9rRPShgHGWi1f59rIbvtauWMAno4N0LT6qUCuaoaRswMqfaeHe8yF R0vhMqGsUlxz0zsYTdsPotez0m09VZj2TRL0TGlaySj8ZaK5nkijADDGjA4QzfN4kNQb xUqvpP0d7QvBXHeMbAviCtkbOqRnY1HdPP5nr5smE+SOUSUgrQlWbbDt5RoYnLFk77Z/ I1jj73uZqggY124yQMTEPo1cfmIySnPKSSVqk67izRi1TUyH491VLZZkM4DeevcypoKo fxLPsPWABOxqPWzN6b6B3Fx6k+Td71nR2QQuyxLZkkgWPgdXNED3+iQTET6/Gv9jd693 e3DQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@pschenker.ch header.s=20220412 header.b=TKYlhNeX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=pschenker.ch Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e10-20020a170902cf4a00b00194767a784fsi9075154plg.396.2023.01.16.06.48.18; Mon, 16 Jan 2023 06:48:32 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@pschenker.ch header.s=20220412 header.b=TKYlhNeX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=pschenker.ch Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232487AbjAPOYw (ORCPT + 99 others); Mon, 16 Jan 2023 09:24:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57042 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232827AbjAPOXu (ORCPT ); Mon, 16 Jan 2023 09:23:50 -0500 X-Greylist: delayed 383 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Mon, 16 Jan 2023 06:08:28 PST Received: from smtp-bc0d.mail.infomaniak.ch (smtp-bc0d.mail.infomaniak.ch [IPv6:2001:1600:3:17::bc0d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A07022749E for ; Mon, 16 Jan 2023 06:08:28 -0800 (PST) Received: from smtp-3-0000.mail.infomaniak.ch (unknown [10.4.36.107]) by smtp-2-3000.mail.infomaniak.ch (Postfix) with ESMTPS id 4NwYc90nXCzMqcMb; Mon, 16 Jan 2023 15:02:01 +0100 (CET) Received: from unknown by smtp-3-0000.mail.infomaniak.ch (Postfix) with ESMTPA id 4NwYc81GLdzGsp; Mon, 16 Jan 2023 15:02:00 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=pschenker.ch; s=20220412; t=1673877721; bh=A6GZwkHnaoIZ28gxZUhGOXzEzh7g91KUo/Qw0h2sKB4=; h=From:To:Cc:Subject:Date:From; b=TKYlhNeXlGFMKUiXm+/BS6fmCAtv53XpEYN8DQwHLt46AHrZdFVcNecmDMtHtcdiU k2mGbd4GTydvxcQCJdaW7uHqgZEYoUHAU+14U1MDwjsuLMEYjAIUDx9oKLG21b552p Oq8D9JQ4Omcf/3DENcTx+z6puBxwCytsM5LzT4m0= From: Philippe Schenker To: devicetree@vger.kernel.org Cc: Philippe Schenker , Andrejs Cainikovs , Fabio Estevam , Francesco Dolcini , Krzysztof Kozlowski , Marcel Ziswiler , NXP Linux Team , Pengutronix Kernel Team , Rob Herring , Sascha Hauer , Shawn Guo , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] arm64: dts: imx8mm-verdin: Do not power down eth-phy Date: Mon, 16 Jan 2023 15:01:52 +0100 Message-Id: <20230116140153.23938-1-dev@pschenker.ch> X-Mailer: git-send-email 2.39.0 MIME-Version: 1.0 X-Infomaniak-Routing: alpha X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1755190932472980109?= X-GMAIL-MSGID: =?utf-8?q?1755190932472980109?= From: Philippe Schenker Currently if suspending using either freeze or memory state, the fec driver tries to power down the phy which leads to crash of the kernel and non-responsible kernel with the following call trace: [ 24.839889 ] Call trace: [ 24.839892 ] phy_error+0x18/0x60 [ 24.839898 ] kszphy_handle_interrupt+0x6c/0x80 [ 24.839903 ] phy_interrupt+0x20/0x2c [ 24.839909 ] irq_thread_fn+0x30/0xa0 [ 24.839919 ] irq_thread+0x178/0x2c0 [ 24.839925 ] kthread+0x154/0x160 [ 24.839932 ] ret_from_fork+0x10/0x20 Since there is currently no functionality in the phy subsystem to power down phys let's just disable the feature of powering-down the ethernet phy. Fixes: 6a57f224f734 ("arm64: dts: freescale: add initial support for verdin imx8m mini") Signed-off-by: Philippe Schenker --- arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi index 7e8b3b0fa306..4df3c9760151 100644 --- a/arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi @@ -102,6 +102,7 @@ reg_ethphy: regulator-ethphy { off-on-delay = <500000>; pinctrl-names = "default"; pinctrl-0 = <&pinctrl_reg_eth>; + regulator-always-on; regulator-boot-on; regulator-max-microvolt = <3300000>; regulator-min-microvolt = <3300000>;