From patchwork Mon Jan 16 10:04:59 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rakesh Sankaranarayanan X-Patchwork-Id: 44049 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp1112317wrn; Mon, 16 Jan 2023 02:13:05 -0800 (PST) X-Google-Smtp-Source: AMrXdXujOrJoHLHj72rR9M6/m3FnF5MFOr6jwnCIjpdCgY9TmbNBNpFzLKlwEb3JwSIva9ztd1E5 X-Received: by 2002:a05:6a20:2d0c:b0:b6:a58c:d01 with SMTP id g12-20020a056a202d0c00b000b6a58c0d01mr14106996pzl.30.1673863984684; Mon, 16 Jan 2023 02:13:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673863984; cv=none; d=google.com; s=arc-20160816; b=oVsEhVn2bmr3D+vawVKCiIyIlKsieWKw8pJsSxyhC07aGdw14wO3i+0s3SO4FBCuzT d333y8zOEFyRlyuh1xUXTDuf7B+5T6nLWchncVDvtZJDmCbOPi7CstRVab61ID/EoIzy BUsTDOBs11NhXK+cO74GwXGxtrAk+KEk5xzMHtF3Sv2zPVscAZJON0B4KC0nyTZR/LdE 4LA5h8fSB20hegwfjY4aSSyPOG/LpYBHWoOikW1w3xGRL3+7M48iC45Q9IvWLT4WnIia M65SB9WSbvPFinHf5qXKU7x7JNMLSBNtBNGoeg5zg3wMNRycsbmMOS96cW/fQSyD/Uvi wB0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=hWViJWP0MS0t9JaQ6c1hdhw0IoiQzYBzBBrucS1yyyU=; b=DCSHHA2zME8qJbNLWw1+DcaiIaCgEWBzsiFfNepX06ZxEOn0CmzILLqeufxD8NYZ45 QvPmN13cDTPk8tfbfa6rKpXKRacu1E8S24PWvpSnV9im+v1NfDrdAzkGXT+f6YxBGTMl lYPLVBW53067rYRUtMf+awniREcv6EU27A0GfJ5Wi7eIJBD27MOB+JJU0lIYxCAHMnQH EbCXJh/dPyHvvvjGJMN/kHoq55/nmcOHxxK705cdrrSyG7K1Iu7TG1vhd/1OaQGv4sVS JoTMQsMPUBIVsvNpeXx66iL+R0WRBjZ0IAxQ/fLhI1dkhqgf2N2v2laH8+Ss3E8vE4Gv i1GQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@microchip.com header.s=mchp header.b=O4I37HOi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=microchip.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h188-20020a636cc5000000b004b4e4162ccasi20070347pgc.446.2023.01.16.02.12.52; Mon, 16 Jan 2023 02:13:04 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@microchip.com header.s=mchp header.b=O4I37HOi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=microchip.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229712AbjAPKE0 (ORCPT + 99 others); Mon, 16 Jan 2023 05:04:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51244 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229590AbjAPKER (ORCPT ); Mon, 16 Jan 2023 05:04:17 -0500 Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.153.233]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 526B817CE6; Mon, 16 Jan 2023 02:04:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1673863456; x=1705399456; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=XRRLzzOXeevXebWQAE/XcwmvSXhfQ30Z0QGr+p2NfNk=; b=O4I37HOiEPC0MZ03tGo5k3YA6dsyJPndsoflo+4dhn57ozPcWDr3hG8z pAr8h3NDTZRSMpPVZrTtWe22dXJ2GVQafNFDywvTnzKdoqmBaRa7ze5gR h3IgTeRADCK6YA6/G/bzn3misiIbMGb00Kp0FLi5nLJ2j1Jo+9MgxOXwM //6d46NCOtW1NNs6rPB4lbQ9JYpi4nU2/SNn6uLzzEOicJ6TelJdxANfN XuKlo7S5EN6L+NzdJgODSYLM4EDOLNvcVGwPB4oxjwNdex9XmgK13rjZg QSoYQii57CGnRsLFS/8JKoOk+eJhYRWEDJ/BcQxBQwF/ZaFShhgg550ru g==; X-IronPort-AV: E=Sophos;i="5.97,220,1669100400"; d="scan'208";a="196807029" Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa3.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 16 Jan 2023 03:04:15 -0700 Received: from chn-vm-ex01.mchp-main.com (10.10.85.143) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Mon, 16 Jan 2023 03:04:15 -0700 Received: from che-lt-i67786lx.microchip.com (10.10.115.15) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server id 15.1.2507.16 via Frontend Transport; Mon, 16 Jan 2023 03:04:11 -0700 From: Rakesh Sankaranarayanan To: , CC: , , , , , , , , , , , Subject: [PATCH net 1/2] net: dsa: microchip: ksz9477: port map correction in ALU table entry register Date: Mon, 16 Jan 2023 15:34:59 +0530 Message-ID: <20230116100500.614444-2-rakesh.sankaranarayanan@microchip.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230116100500.614444-1-rakesh.sankaranarayanan@microchip.com> References: <20230116100500.614444-1-rakesh.sankaranarayanan@microchip.com> MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1755173601565078788?= X-GMAIL-MSGID: =?utf-8?q?1755173601565078788?= ALU table entry 2 register in KSZ9477 have bit positions reserved for forwarding port map. This field is referred in ksz9477_fdb_del() for clearing forward port map and alu table. But current fdb_del refer ALU table entry 3 register for accessing forward port map. Update ksz9477_fdb_del() to get forward port map from correct alu table entry register. With this bug, issue can be observed while deleting static MAC entries. Delete any specific MAC entry using "bridge fdb del" command. This should clear all the specified MAC entries. But it is observed that entries with self static alone are retained. Tested on LAN9370 EVB since ksz9477_fdb_del() is used common across LAN937x and KSZ series. Fixes: b987e98e50ab ("dsa: add DSA switch driver for Microchip KSZ9477") Signed-off-by: Rakesh Sankaranarayanan Reviewed-by: Vladimir Oltean --- drivers/net/dsa/microchip/ksz9477.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/dsa/microchip/ksz9477.c b/drivers/net/dsa/microchip/ksz9477.c index 47b54ecf2c6f..6178a96e389f 100644 --- a/drivers/net/dsa/microchip/ksz9477.c +++ b/drivers/net/dsa/microchip/ksz9477.c @@ -540,10 +540,10 @@ int ksz9477_fdb_del(struct ksz_device *dev, int port, ksz_read32(dev, REG_SW_ALU_VAL_D, &alu_table[3]); /* clear forwarding port */ - alu_table[2] &= ~BIT(port); + alu_table[1] &= ~BIT(port); /* if there is no port to forward, clear table */ - if ((alu_table[2] & ALU_V_PORT_MAP) == 0) { + if ((alu_table[1] & ALU_V_PORT_MAP) == 0) { alu_table[0] = 0; alu_table[1] = 0; alu_table[2] = 0;