From patchwork Sat Jan 14 01:37:24 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Rix X-Patchwork-Id: 43687 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp69620wrn; Fri, 13 Jan 2023 17:59:52 -0800 (PST) X-Google-Smtp-Source: AMrXdXtegA5sU2aM+wGYjYhJwwoqFsTBjoZgA1CvGs4591tpjUYwcKUAuJTVwxmipCchtgJ3KXbU X-Received: by 2002:a17:902:ccc4:b0:186:e434:6265 with SMTP id z4-20020a170902ccc400b00186e4346265mr97348731ple.2.1673661592066; Fri, 13 Jan 2023 17:59:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673661592; cv=none; d=google.com; s=arc-20160816; b=Rq6eJR2CI1IUq6V2Z2+maLR0puDfTch1qKV/6S4xBL03He49z9gaXmhNEnDki+bP9t 4wq5D8BF3Ly5Mtp6vTBqYnJFWXhzp/RWl/Dyt/m3ds0lroVDsnJZohAwdGrIiZSzJNw0 namFKyHH1tuKABWcnXEyZ6kLZt4g96AenBoVj+hmCDHwzj7Kz77nDoL3nX+MupdzVPzy TfvffAVoReFTr7rkhDLsAJUO0NAJOovo749L9qpQ9bx5pbSWdtjjCnVrzvGYiXM2DM1j ACoZXxKdvwHktLRt3R0X6XrY24QhPXPT0XijMLoIkhsEqYPDajsXWIyoMBtN/iYWUwCL 0SCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=VZy8c8fy0bsQa5T6EMyPtDGsQiznRhGW5hoUl+VQVKY=; b=EZ0sr/2cjh1d2ieyJ3RLatjV11LMsNaElNZOREyImUMLTfcjho7attRt4hmjsr/BEI xJ0J1IenQZsNbPQ1F1nJusa6U0XJ5Hwx29MAuh1kuF1kYn8XfEv9hI2MvcxaSd5KuAJl /lBTbzBSgxNd96KT+ZPEVY+CXYciRs+StU/T95ZjgVaHy9Znz+aSvEOD2+2NVzwMmbba 4tk3lHBIn0xaWrDBIYUPJ7Ex2OLTXcT+cwxz4YrX6P8V9cS5ZRwx+CSQ05evwRcRweyQ ybu9SHcLd0RTlHZsV32WKDEaaFrMVTRQySp/vr9lc1EAeW3HchFlWHZqGhJ3rndhr69B 3KTA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="Uh54Rr/0"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l3-20020a17090270c300b001891957c097si5154520plt.91.2023.01.13.17.59.26; Fri, 13 Jan 2023 17:59:52 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="Uh54Rr/0"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231365AbjANBiT (ORCPT + 99 others); Fri, 13 Jan 2023 20:38:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36024 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230410AbjANBiR (ORCPT ); Fri, 13 Jan 2023 20:38:17 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4C61010B7A for ; Fri, 13 Jan 2023 17:37:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673660249; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=VZy8c8fy0bsQa5T6EMyPtDGsQiznRhGW5hoUl+VQVKY=; b=Uh54Rr/081bbbmu6rOrF9VBsr2HWbxMhIOIQzAieHIc/V5P2EGSkLiA1hxPJA9lIJeQhCn LDsNmYvW2Ws8ZmjkkQ8RcxkgQFuDDozr5W5IIHeF8PhvLiZJM3WyQYHI0NNc81R6xXj8sz m75FDfSF8gOOJK8DU4G05leVeRFXKrs= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-583-2wC9_HpGO1iHBUEEgdvzwg-1; Fri, 13 Jan 2023 20:37:28 -0500 X-MC-Unique: 2wC9_HpGO1iHBUEEgdvzwg-1 Received: by mail-qt1-f198.google.com with SMTP id z13-20020ac86b8d000000b003b322cbac99so1511206qts.8 for ; Fri, 13 Jan 2023 17:37:28 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=VZy8c8fy0bsQa5T6EMyPtDGsQiznRhGW5hoUl+VQVKY=; b=oOGgzIf84+BZt1kMr+QpZNJa0xr4FVBBJ/VIb6wt5S+szKkafUxBDN+C7DigsnLhhU 8EUXyKtTeQZ4LUFWFUj87W1IQ44vLwuHtxUoyuKitzUEimUSI54SjxqQJtNSooIGakRd 2kdfObWX7+W+0eYMaZATfgIAitKlQsIkTTKFDO5NH+L0FN0edOTB6jhDBhYUAp97YK0+ Ci20FUM0xZxm6nsoICn2P3MwATPAx1zaB0BK6d2fiG3DfVDkUucdyPjPr8mvgEXVX1gH RwRjJaayFGy1sEYgdSm+ynsgb3qUB8pvArTP8N1a8aga7M52b0d30jBQ7brx/rDivOkL eCVw== X-Gm-Message-State: AFqh2kolXRDuWcA52tai+33RXbNs7QpgWjzQLnL88+e02S1p5Rvz/o27 65KN8RktLcslLG4dSxXwD3qOVpnVBrG82aKH4RAm690RAi0+wIh8QpycVQItcKeta8Fcuwq6hJu PL9MWD0a1ch04qwj+zbWC72/9 X-Received: by 2002:a05:622a:5a85:b0:3a8:28fb:b076 with SMTP id fz5-20020a05622a5a8500b003a828fbb076mr107846186qtb.31.1673660247672; Fri, 13 Jan 2023 17:37:27 -0800 (PST) X-Received: by 2002:a05:622a:5a85:b0:3a8:28fb:b076 with SMTP id fz5-20020a05622a5a8500b003a828fbb076mr107846169qtb.31.1673660247477; Fri, 13 Jan 2023 17:37:27 -0800 (PST) Received: from dell-per740-01.7a2m.lab.eng.bos.redhat.com (nat-pool-bos-t.redhat.com. [66.187.233.206]) by smtp.gmail.com with ESMTPSA id bp32-20020a05620a45a000b00705b4001fbasm10673981qkb.128.2023.01.13.17.37.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Jan 2023 17:37:27 -0800 (PST) From: Tom Rix To: njavali@marvell.com, jejb@linux.ibm.com, martin.petersen@oracle.com, qutran@marvell.com Cc: GR-QLogic-Storage-Upstream@marvell.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Tom Rix Subject: [PATCH] scsi: qla2xxx: Change qla_trim_buf,__qla_adjust_buf functions to static Date: Fri, 13 Jan 2023 20:37:24 -0500 Message-Id: <20230114013724.3943580-1-trix@redhat.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1754961377436904348?= X-GMAIL-MSGID: =?utf-8?q?1754961377436904348?= Smatch reports drivers/scsi/qla2xxx/qla_mid.c:1189:6: warning: symbol 'qla_trim_buf' was not declared. Should it be static? drivers/scsi/qla2xxx/qla_mid.c:1221:6: warning: symbol '__qla_adjust_buf' was not declared. Should it be static? These functions are only used in qla_mid.c, so they should be static. Fixes: 1f8f9c34127e ("scsi: qla2xxx: edif: Reduce memory usage during low I/O") Signed-off-by: Tom Rix --- drivers/scsi/qla2xxx/qla_mid.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_mid.c b/drivers/scsi/qla2xxx/qla_mid.c index c6ca39b8e23d..bd6bc1a968b2 100644 --- a/drivers/scsi/qla2xxx/qla_mid.c +++ b/drivers/scsi/qla2xxx/qla_mid.c @@ -1186,7 +1186,7 @@ int qla_get_buf(struct scsi_qla_host *vha, struct qla_qpair *qp, struct qla_buf_ return 0; } -void qla_trim_buf(struct qla_qpair *qp, u16 trim) +static void qla_trim_buf(struct qla_qpair *qp, u16 trim) { int i, j; struct qla_hw_data *ha = qp->vha->hw; @@ -1218,7 +1218,7 @@ void qla_trim_buf(struct qla_qpair *qp, u16 trim) qp->id, trim, qp->buf_pool.num_alloc); } -void __qla_adjust_buf(struct qla_qpair *qp) +static void __qla_adjust_buf(struct qla_qpair *qp) { u32 trim;