From patchwork Fri Jan 13 21:53:51 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 43627 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp498737wrt; Fri, 13 Jan 2023 13:55:13 -0800 (PST) X-Google-Smtp-Source: AMrXdXu7lrnTu0EMr1sOPER5Jm3MdDP6boTFI+E7yYJs4MABtRIpg428vV4C//lmkun1B1T1dqAb X-Received: by 2002:a17:90b:3007:b0:225:e88c:33c2 with SMTP id hg7-20020a17090b300700b00225e88c33c2mr13147278pjb.7.1673646913036; Fri, 13 Jan 2023 13:55:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673646913; cv=none; d=google.com; s=arc-20160816; b=rWqEoh0USzgVQeXUET+0A7WRw7YICMYgGE9p7X3cVz0lM6FcFDBFlmmFnXc5FajBLT VYhR/DXBdBxQRZ45aG2Kt0dfDBd2YEW/EI0542nZkt2AXosmLzTkGR2VzIgJwEsS8Ij+ 6NDp5QANSaZUdhH5dCLrmlx9TFfb9CWqb1nhoHkD/xsQ6hpJc3ms+/DHq2309D6Bfcsf w/0eJRRrUFPhuAH8p6Iv/al1kyFRNVqtH3FhkDQEtcSzQTKXJfoal8xWAG/COv41TaGj 3463M/ZmkMjI7ryxGC/WeDukdUNY7m8o7jiVrphSOfHQ1hEhO5VOrvsS8gRifBYPSmmT qdYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=+RnPEjXKtgY06jaXfkZclwy5VHVCyUOIP1myp1Ud4jI=; b=nVqyl6Air04hd+IfUe1ug/RKyxCZmxTKAqwiMUIEP811ftzPmjZteF4z1tNIQEwRHk LUU1dHH80u79oxA5kiry9qmQ/05AOdy54nVkaYPIktk3Bufg2eakiBddDhtOq2U9w3I8 fy/cfXDVS8D2W1gUMWgzjSCm1F+d2QaDRaIwJOoReM5Ds3cgyyfZ+aELOOMaQ3ndEBPK IuaXNEogCLhkjjqWtZaDZcrfIVwNUCvXhHOcid8zKQHy2JjNzoHK5xvd0GlnhcmysI+J aWya/9nbuKNiY3E8xx1jRo1PyYZAQuSTBGNG3wTsOIzMjy2WcpvI7pM0gIzXiwgXdjD6 LX2Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=CajFBfOJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id oj15-20020a17090b4d8f00b002137030b2basi22113437pjb.54.2023.01.13.13.54.59; Fri, 13 Jan 2023 13:55:13 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=CajFBfOJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231304AbjAMVxy (ORCPT + 99 others); Fri, 13 Jan 2023 16:53:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44488 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231238AbjAMVxk (ORCPT ); Fri, 13 Jan 2023 16:53:40 -0500 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2F0FF8A200; Fri, 13 Jan 2023 13:53:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1673646819; x=1705182819; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=Z/1Cne1W4AwpoRsJk54/v3XiqpKeXDprBTs8fqxisP4=; b=CajFBfOJewbuH4eEMbrabrbzrvkQx9IR0lg3S7M6Uv69y4etNILhrNw/ IHkTgjYC3pnTz9lmgHDRTtt7dD5d7nOSS2YMi2MTrYVK6fu4wFfykbWus mGtRMjqCGdJgEYwzZfIsvK1a1WO2rAVOp8lAP6t8E78j/3O/rIt6WPIzM bUpGJih/qh4pX5wuSxSGypA3IcTB5Fk5tK7qeB/synoVRY1otu1SArvHX fMRWjeV0RyVQhvlVD4LaUefhy85+INrKMxOO2uLu7Y64VPUP1e2+fUC0t j18viFjWm1H/t4BWPQbwUnkTEFaU5cuCNBrnWQFR10JR4ZEf1F6zD5mau Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10589"; a="351343122" X-IronPort-AV: E=Sophos;i="5.97,214,1669104000"; d="scan'208";a="351343122" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jan 2023 13:53:37 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10589"; a="766170869" X-IronPort-AV: E=Sophos;i="5.97,215,1669104000"; d="scan'208";a="766170869" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga002.fm.intel.com with ESMTP; 13 Jan 2023 13:53:22 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id 77F46130; Fri, 13 Jan 2023 23:53:56 +0200 (EET) From: Andy Shevchenko To: Bartosz Golaszewski , Dmitry Torokhov , Andy Shevchenko , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org Cc: Linus Walleij , Bartosz Golaszewski , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , Stefan Wahren Subject: [PATCH v3 3/4] pinctrl: bcm2835: Switch to use ->add_pin_ranges() Date: Fri, 13 Jan 2023 23:53:51 +0200 Message-Id: <20230113215352.44272-4-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230113215352.44272-1-andriy.shevchenko@linux.intel.com> References: <20230113215352.44272-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1754945985167420846?= X-GMAIL-MSGID: =?utf-8?q?1754945985167420846?= Yeah, while the ->add_pin_ranges() shouldn't be used by DT drivers, this one requires it to support quite old firmware descriptions that do not have gpio-ranges property. The change allows to clean up GPIO library from OF specifics. There is no functional change intended. Signed-off-by: Andy Shevchenko --- drivers/pinctrl/bcm/pinctrl-bcm2835.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/pinctrl/bcm/pinctrl-bcm2835.c b/drivers/pinctrl/bcm/pinctrl-bcm2835.c index c7cdccdb4332..8e2551a08c37 100644 --- a/drivers/pinctrl/bcm/pinctrl-bcm2835.c +++ b/drivers/pinctrl/bcm/pinctrl-bcm2835.c @@ -358,9 +358,9 @@ static int bcm2835_gpio_direction_output(struct gpio_chip *chip, return 0; } -static int bcm2835_of_gpio_ranges_fallback(struct gpio_chip *gc, - struct device_node *np) +static int bcm2835_add_pin_ranges_fallback(struct gpio_chip *gc) { + struct device_node *np = dev_of_node(gc->parent); struct pinctrl_dev *pctldev = of_pinctrl_get(np); if (!pctldev) @@ -386,7 +386,7 @@ static const struct gpio_chip bcm2835_gpio_chip = { .base = -1, .ngpio = BCM2835_NUM_GPIOS, .can_sleep = false, - .of_gpio_ranges_fallback = bcm2835_of_gpio_ranges_fallback, + .add_pin_ranges = bcm2835_add_pin_ranges_fallback, }; static const struct gpio_chip bcm2711_gpio_chip = { @@ -403,7 +403,7 @@ static const struct gpio_chip bcm2711_gpio_chip = { .base = -1, .ngpio = BCM2711_NUM_GPIOS, .can_sleep = false, - .of_gpio_ranges_fallback = bcm2835_of_gpio_ranges_fallback, + .add_pin_ranges = bcm2835_add_pin_ranges_fallback, }; static void bcm2835_gpio_irq_handle_bank(struct bcm2835_pinctrl *pc,