From patchwork Fri Jan 13 19:30:10 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jim Cromie X-Patchwork-Id: 43559 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp448930wrt; Fri, 13 Jan 2023 11:40:16 -0800 (PST) X-Google-Smtp-Source: AMrXdXu7AcWlcoSvHlwc0S3LSfkt2XrTTH8bxjehJBUxUUzy7ftB7MBn/9x+B0yGKzEWIkcHGVWT X-Received: by 2002:a05:6a20:2a95:b0:b2:52b7:d627 with SMTP id v21-20020a056a202a9500b000b252b7d627mr106396116pzh.35.1673638816510; Fri, 13 Jan 2023 11:40:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673638816; cv=none; d=google.com; s=arc-20160816; b=Ux4syeULYLRtHJuV67YPlfNCT57VaX0Zb5hA0KXqu+EOyifDuooFwnuTOIIP6ym1xO gP1XACOtSj/HzcM2qMZNlIHZ3zDBvK+XNDS/BWUfRLNlz8h3SWOECfTLeP0yPR8RmEVM gEww5LJtg8zJ9XKWEtFVvjCix089ym1yn0gFmGozKzaYIE+w4cBO0H3Bs0Y48GLcPq2x 5qCh866ypRXaii4c3tt//Mc3Prrkj+Rl7GZmyKBEPujApvlYzGSQ74854tQJwSkJanhj +LsevTPBEA1ar1IraEssl74rxCASWHkwyrh07ncELS/7duTXhZ59Uh64sgZdXiB33cas WAPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=aRyUl1j2CeLT2msyDi6y9qIAncSGOoQz3PjuRO1TezA=; b=BB8lEIPjT5uckN8amHzIbG55phCaGgE9NR5+cj95vrq9EP8wPSPbuK9M68Nf9KLuqK MuO8qgNhbb50KGskpWO5r5eQzHuy21VRKOcfJODK8y18nYLM3eY2WtA78CWFriilxqHE reMgmqmgPNB4fiJIkJ9e1bdiELR53vA13QkZqZ0CPPg3E2rlmgH623y7Sye5ZBE7QyNf mwGrFdIAZsJsuvHFPjnuwGOHLx3evg+ZVGezieditoXxKNmerlLkZ+vuEHiPWv35m2lc O1XY9aDqynEEfnSRqueo5NIIHNrAvkFEbCGCQiv5njqsS7+c8N54VmhdcdqnTDWiuvbd 22ig== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=iziQWeBJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h188-20020a636cc5000000b0047881bf9d07si21293655pgc.433.2023.01.13.11.40.02; Fri, 13 Jan 2023 11:40:16 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=iziQWeBJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231124AbjAMTck (ORCPT + 99 others); Fri, 13 Jan 2023 14:32:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47052 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230305AbjAMTbB (ORCPT ); Fri, 13 Jan 2023 14:31:01 -0500 Received: from mail-il1-x12e.google.com (mail-il1-x12e.google.com [IPv6:2607:f8b0:4864:20::12e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 993587CBE9 for ; Fri, 13 Jan 2023 11:30:58 -0800 (PST) Received: by mail-il1-x12e.google.com with SMTP id x6so6615690ill.10 for ; Fri, 13 Jan 2023 11:30:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=aRyUl1j2CeLT2msyDi6y9qIAncSGOoQz3PjuRO1TezA=; b=iziQWeBJgoiaMWnT+DGKeHRFoxOg8Y//x6gVDHTO/o/B4A2YM/jQhz7hOa75kni4T0 mENNP100auhPgXQopX+LQvdAUY+0nOJ/rj9kM64uDIVIOpiPwFwEYZyZagsSNUKXoJoT 8fUlesHV9DvTWZ6X031dT4qAHFMG1Rr80Q/mR9+vzpDC0++MWi6MKKM4zBwpTSNvAuVI 9VUcAIV2UMhcADTgaUB2SqjfobS982vS5b/639ZvSEiS7/aAsWMM38zXDLuV7Yjmndjm q0WFuObgL8VxnpyJ+sHbRJRJXhPMARzB2VyhnINlSLyAwmXDUahnRjHIgV5sebJwH44a euBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aRyUl1j2CeLT2msyDi6y9qIAncSGOoQz3PjuRO1TezA=; b=hazJ/Jl915lbqKYB9WzucLlGM4g2ABX43gsp/Jn0m4t1J9kHYchJid9pwNJxKwZd+4 WOMVTBRvDFaWe+COvObsMbPFLO7hcREGJwQSoWyQKbRdlY+XjC2ySAY5FOwUPPeVWbyR RXg62jESHaI0vK33qCD0ts+FGiO/OYgQdb/Kz0dx+Bo1B0xz7nbRWucTAVtK8AybWrKY iQYIwtb40IRYbOvcTedCGPndwv+rF7lsfia3UC1JUFnbIMjEilX5UzK1c4UjkE0nyvus gS9eM6ePhWcHQxPn4v/2KrEmD/cD3aNOvjleEeFfjTety5J4ZWpvmUpiHK7fnPhn1XOb +Wgg== X-Gm-Message-State: AFqh2koRFkEiMHBMPoiXsHzuEdnQMzm3fBPAoQOBnOke7NjIVAA/scDi RwyswghL4jNmfPxGYRH1BrAkEOoabnj1Cw== X-Received: by 2002:a92:7f03:0:b0:30c:54a1:e5d8 with SMTP id a3-20020a927f03000000b0030c54a1e5d8mr30477229ild.30.1673638257652; Fri, 13 Jan 2023 11:30:57 -0800 (PST) Received: from frodo.. (c-73-78-62-130.hsd1.co.comcast.net. [73.78.62.130]) by smtp.googlemail.com with ESMTPSA id e32-20020a026d60000000b0039e583abceasm6497289jaf.68.2023.01.13.11.30.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Jan 2023 11:30:57 -0800 (PST) From: Jim Cromie To: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org Cc: jani.nikula@intel.com, ville.syrjala@linux.intel.com, daniel.vetter@ffwll.ch, seanpaul@chromium.org, robdclark@gmail.com, jbaron@akamai.com, gregkh@linuxfoundation.org, Jim Cromie Subject: [PATCH v2 14/20] drm_print: fix stale macro-name in comment Date: Fri, 13 Jan 2023 12:30:10 -0700 Message-Id: <20230113193016.749791-15-jim.cromie@gmail.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230113193016.749791-1-jim.cromie@gmail.com> References: <20230113193016.749791-1-jim.cromie@gmail.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1754937495662485047?= X-GMAIL-MSGID: =?utf-8?q?1754937495662485047?= Cited commit uses stale macro name, fix this, and explain better. When DRM_USE_DYNAMIC_DEBUG=y, DYNDBG_CLASSMAP_DEFINE() maps DRM_UT_* onto BITs in drm.debug. This still uses enum drm_debug_category, but it is somewhat indirect, with the ordered set of DRM_UT_* enum-vals. This requires that the macro args: DRM_UT_* list must be kept in sync and in order. Fixes: f158936b60a7 ("drm: POC drm on dyndbg - use in core, 2 helpers, 3 drivers.") Signed-off-by: Jim Cromie --- . emphasize ABI non-change despite enum val change - Jani Nikula . reorder to back of patchset to follow API name changes. --- include/drm/drm_print.h | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/include/drm/drm_print.h b/include/drm/drm_print.h index 6a27e8f26770..7695ba31b3a4 100644 --- a/include/drm/drm_print.h +++ b/include/drm/drm_print.h @@ -276,7 +276,10 @@ static inline struct drm_printer drm_err_printer(const char *prefix) * */ enum drm_debug_category { - /* These names must match those in DYNAMIC_DEBUG_CLASSBITS */ + /* + * Keep DYNDBG_CLASSMAP_DEFINE args in sync with changes here, + * the enum-values define BIT()s in drm.debug, so are ABI. + */ /** * @DRM_UT_CORE: Used in the generic drm code: drm_ioctl.c, drm_mm.c, * drm_memory.c, ...