Message ID | 20230113142718.3038265-9-o.rempel@pengutronix.de |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp303145wrt; Fri, 13 Jan 2023 06:35:31 -0800 (PST) X-Google-Smtp-Source: AMrXdXvCm4aeV0V2xNve0UqKOK8J6E6VHkUi9G++2zHJVsx3HuFp4EpD5kAufHmOTZCMe+8vfZll X-Received: by 2002:a50:d482:0:b0:495:7152:af55 with SMTP id s2-20020a50d482000000b004957152af55mr24279179edi.32.1673620531659; Fri, 13 Jan 2023 06:35:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673620531; cv=none; d=google.com; s=arc-20160816; b=f3F/ZjuR0JXcs7w8Jg2PJz9IqPhp3inlwH0X6ElrSrnqKI6wg6c1nmv44uCUQq1EsR gKDFgqsLrx5tUw2dVcR/3dSOZgYbmzp7QKD3OHee1xGWwPkM1oKcGjzxh+xGjDHo4iUD pxWou39/Emt98zNrqa7AM7bjShaYtt6Eem4PSDN53lQcTYCgGfZ4qM7rpfZu8BPt8XRZ pIZYPHCbz8HR+r0K/Q4i/W77ps76AxncyAWRR5/mvpfAnOUWUbwpDhOUbisECiEu6CvG 14kfsxrXuEUUbswoshUTME6ShJoFT2IyiA3vKxNaqsfGIw9FVOXuNzbqUhr83LSzLGqw Iung== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=1vGWI2ZHRLS9swfFWkuLq4JPjRbBvIfyh01XSrtOTQQ=; b=Oupo3AsK8wkfxPf7Q/0ut0snKJxscG/RT8G8hJdwyF/tzeRonQkMY1ryeHU7kQTEvv nq7ZJULX3IuUeCFat+FOBVfXNgmzxjcuyD3YfFsIvVETuGly8K/UeoEfXT5B7n27Qr2A XS5osAdUFdcBAPOApcTY6YEXUWDc5ZLVMea58tXUwZtiXLUjyfKiMgYGtnr/SKHo/wus sfQj/RnLyy+kEnk7t6AkMnW1JBLmpa/yDi/W7X4si0KFREkA2UXfTDA2woRZYJ6H0GfJ rtAfvAf05oj8FvS8/9zbB5debjg6qw9HEnr2q8sDwSv9xUBYZvSHbjMabauB6QOj15Eo MWQQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id bb2-20020a1709070a0200b008626e197ac3si7054204ejc.692.2023.01.13.06.35.06; Fri, 13 Jan 2023 06:35:31 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229925AbjAMOeg (ORCPT <rfc822;callmefire3@gmail.com> + 99 others); Fri, 13 Jan 2023 09:34:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57158 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229791AbjAMOdS (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Fri, 13 Jan 2023 09:33:18 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 69E8E4917D for <linux-kernel@vger.kernel.org>; Fri, 13 Jan 2023 06:27:48 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from <ore@pengutronix.de>) id 1pGL1f-0006Gi-N4; Fri, 13 Jan 2023 15:27:23 +0100 Received: from [2a0a:edc0:0:1101:1d::ac] (helo=dude04.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from <ore@pengutronix.de>) id 1pGL1e-005mz0-Uj; Fri, 13 Jan 2023 15:27:22 +0100 Received: from ore by dude04.red.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from <ore@pengutronix.de>) id 1pGL1b-00CkQe-Ev; Fri, 13 Jan 2023 15:27:19 +0100 From: Oleksij Rempel <o.rempel@pengutronix.de> To: Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Shawn Guo <shawnguo@kernel.org>, Sascha Hauer <s.hauer@pengutronix.de>, Abel Vesa <abelvesa@kernel.org>, Michael Turquette <mturquette@baylibre.com>, Stephen Boyd <sboyd@kernel.org>, Richard Cochran <richardcochran@gmail.com> Cc: Oleksij Rempel <o.rempel@pengutronix.de>, kernel@pengutronix.de, Fabio Estevam <festevam@gmail.com>, NXP Linux Team <linux-imx@nxp.com>, Lee Jones <lee@kernel.org>, Russell King <linux@armlinux.org.uk>, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH v1 08/20] ARM: dts: imx6dl-plybas: configure ethernet reference clock parent Date: Fri, 13 Jan 2023 15:27:06 +0100 Message-Id: <20230113142718.3038265-9-o.rempel@pengutronix.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230113142718.3038265-1-o.rempel@pengutronix.de> References: <20230113142718.3038265-1-o.rempel@pengutronix.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1754918322267635866?= X-GMAIL-MSGID: =?utf-8?q?1754918322267635866?= |
Series |
ARM: imx: make Ethernet refclock configurable
|
|
Commit Message
Oleksij Rempel
Jan. 13, 2023, 2:27 p.m. UTC
Configure Ethernet reference clock parent in an obvious way instead of
using cryptic ptp way.
Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
arch/arm/boot/dts/imx6dl-plybas.dts | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
Comments
Hi Oleksij, On Fri, Jan 13, 2023 at 11:27 AM Oleksij Rempel <o.rempel@pengutronix.de> wrote: > > Configure Ethernet reference clock parent in an obvious way instead of > using cryptic ptp way. Could you please improve the commit log? The "obvious way" is not obvious for people that don't have the board schematics. I like better the way you described the 20/20 patch: "On this board the PHY is the ref clock provider. So, configure ethernet reference clock as input." Please use this format globally in the series, as it becomes clear who is providing the ref clock. Thanks
diff --git a/arch/arm/boot/dts/imx6dl-plybas.dts b/arch/arm/boot/dts/imx6dl-plybas.dts index c52e6caf3996..e98046eea7a4 100644 --- a/arch/arm/boot/dts/imx6dl-plybas.dts +++ b/arch/arm/boot/dts/imx6dl-plybas.dts @@ -75,6 +75,7 @@ clk50m_phy: phy-clock { compatible = "fixed-clock"; #clock-cells = <0>; clock-frequency = <50000000>; + clock-output-names = "enet_ref_pad"; }; reg_5v0: regulator-5v0 { @@ -99,6 +100,13 @@ &can2 { status = "okay"; }; +&clks { + clocks = <&clk50m_phy>; + clock-names = "enet_ref_pad"; + assigned-clocks = <&clks IMX6QDL_CLK_ENET_REF_SEL>; + assigned-clock-parents = <&clk50m_phy>; +}; + &ecspi1 { cs-gpios = <&gpio3 19 GPIO_ACTIVE_LOW>; pinctrl-names = "default"; @@ -116,10 +124,6 @@ &fec { pinctrl-names = "default"; pinctrl-0 = <&pinctrl_enet>; phy-mode = "rmii"; - clocks = <&clks IMX6QDL_CLK_ENET>, - <&clks IMX6QDL_CLK_ENET>, - <&clk50m_phy>; - clock-names = "ipg", "ahb", "ptp"; phy-handle = <&rgmii_phy>; status = "okay";