Message ID | 20230113103346.29381-6-krzysztof.kozlowski@linaro.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp194383wrt; Fri, 13 Jan 2023 02:35:48 -0800 (PST) X-Google-Smtp-Source: AMrXdXsOZ2Q5Q2MZl/QdfDiFSPeH+6dy+APx7FrAP2p3L84p6Wc659g2Y65tlhr5g5UA3lr/eJ7m X-Received: by 2002:a17:907:d68b:b0:7c1:691a:6d2c with SMTP id wf11-20020a170907d68b00b007c1691a6d2cmr90730763ejc.7.1673606147966; Fri, 13 Jan 2023 02:35:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673606147; cv=none; d=google.com; s=arc-20160816; b=fXRknDa23Ks/G3a+SPYq33iDwg+qMXW9vC8MUon5BjkVd8b5bNI74+QMVR8bvj6MbU mxHLRFBHZCA9SWWC0tGQ0QnBZ5ZpBSXxteSOxS/8+6ov6Hhm/hlCnPkHTJhutKJZvmOB /QNENmy4PZxPMb+UIp75vtkMXMJi9dJvlbfG6K2iE5q/V5/LjwNMSsEV/KTx7UZaRNGg wiFqxWWRCyoV6bwCnExp4XpOftsDYx9AOygC7C/RHP0ZcJNsdxUZRvqbTtlni+kTVQRK byhuxE93esNXLICQqpm0jE4UDogAtGJgEmAd8bENBP/xcH9yyNAgzTR9O8kfcNtW9MsE Fkdg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=67GIFM4w0hAvvXxWdOb9SiBmz/aaBvD0zgwwHWbhAi8=; b=zfFSgpdSWWOxmuf3REt6ftcEk4yB5qi95gnEa/RwoxkMUb6FWhMPvuchn+uF8y7svi al66Mt0c589YmJ9oWFdrbqX58iF2chHJBy5ZW7QActaQmHno9zlQTdUSZV9Kqm8gGQQ3 EsN2elBGJP9lK9Xc82yPD7KR7ANxRLqsIvzATpg2svgeUBzCEFoey6CbLNAe5T/H+bMm GuNONNVXbVzWOWZQP1hKSR2H2+vH4abts9CNKb5Gx4x9/4iS4IUVdqHRF9J+5k61HnOg DwwiaTnbB22K6NmI8HGKyyFS5g/3W/0mSFIUBwZz95T9Dvcmb+cWYqaHt1XN+52lg/iG cXqg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=RFBKBKDC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g13-20020a1709065d0d00b008674de1b5c6si4507652ejt.924.2023.01.13.02.35.23; Fri, 13 Jan 2023 02:35:47 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=RFBKBKDC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241008AbjAMKe3 (ORCPT <rfc822;callmefire3@gmail.com> + 99 others); Fri, 13 Jan 2023 05:34:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37514 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241087AbjAMKeP (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Fri, 13 Jan 2023 05:34:15 -0500 Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com [IPv6:2a00:1450:4864:20::635]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 321F042632 for <linux-kernel@vger.kernel.org>; Fri, 13 Jan 2023 02:34:00 -0800 (PST) Received: by mail-ej1-x635.google.com with SMTP id qk9so51319494ejc.3 for <linux-kernel@vger.kernel.org>; Fri, 13 Jan 2023 02:34:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=67GIFM4w0hAvvXxWdOb9SiBmz/aaBvD0zgwwHWbhAi8=; b=RFBKBKDCxfLFl6eG3A7gTJgZCwDB9oRNIOCDwXHMaKnG2t/sOigSIxc57WJ7zvi8+t PtIjYzAJAU/1hMhqBXyU64gIZnAKeIcpjhqIDccrMHx+jvVwtpdblLOyjNOF2Mt4hxJu oOeC75A71pwfHkmwuI7nUQlWvbHfeu5rGzniUQ+BGmruDQ1PdIWkJLxUblB9raMEV4b1 yGwhKvGlnZx1ftkwze9aoqH/vqaVIle5hEJUJELAbKQvuk+9G7IA3el1M11rXvjudneY PkRjLhH82ThZv5BZpclePn6unU6xf4V613NACXawL+GrvN0L+ORJakRXzRLR38yGZGFz MYtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=67GIFM4w0hAvvXxWdOb9SiBmz/aaBvD0zgwwHWbhAi8=; b=QUWQV4iTx/tTAlmamPU2Mz3gfUARDGyxXRqzhinU0KRiMgIBC7Ruvc3LkG/wCEAkvE mZqPw3Ilncag9GQrO9Q4QsAF9fetj0rQD7hiSaeaICSDU9+IL+WnjV79/+DB3uujPXg5 W3ji+Trfx1SSJ/KXIL2sbZl2p2kN/EXfL85TDJJG84TULA3wnMr7tazrMM+eFCo+J2N+ qL+gDjAHLGN7Zw/w2aqCzXHuOkEnekj9/5PFTkDcb2PbHxERKzDBivw66Z88iQQpp/g7 2bfdkhezFnD2eT14fa4r7VlmxehLEzyzpBWA241rR9X3vy+bwY44QQzQ7jKPcF90j0vw c+qg== X-Gm-Message-State: AFqh2kosVmMrp55zD7+NccnOTOin2axtzkLYB3fGR8oJ0ASH0HA8ZzGE /76Iu6PkcZofOGNTaxvhwVro+Q== X-Received: by 2002:a17:906:eda7:b0:7c4:f402:9769 with SMTP id sa7-20020a170906eda700b007c4f4029769mr85624406ejb.76.1673606039746; Fri, 13 Jan 2023 02:33:59 -0800 (PST) Received: from krzk-bin.. ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id qw25-20020a1709066a1900b007ae1e528390sm8296926ejc.163.2023.01.13.02.33.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Jan 2023 02:33:59 -0800 (PST) From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> To: Andy Gross <agross@kernel.org>, Bjorn Andersson <andersson@kernel.org>, Konrad Dybcio <konrad.dybcio@linaro.org>, Daniel Lezcano <daniel.lezcano@linaro.org>, Thomas Gleixner <tglx@linutronix.de>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Wim Van Sebroeck <wim@linux-watchdog.org>, Guenter Roeck <linux@roeck-us.net>, Prakash Ranjan <saiprakash.ranjan@codeaurora.org>, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-watchdog@vger.kernel.org Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, Rob Herring <robh@kernel.org> Subject: [PATCH v2 5/7] dt-bindings: watchdog: qcom-wdt: allow interrupts Date: Fri, 13 Jan 2023 11:33:44 +0100 Message-Id: <20230113103346.29381-6-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230113103346.29381-1-krzysztof.kozlowski@linaro.org> References: <20230113103346.29381-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1754903240334292265?= X-GMAIL-MSGID: =?utf-8?q?1754903240334292265?= |
Series |
watchdog: dt-bindings: rework/fix qcom-wdt
|
|
Commit Message
Krzysztof Kozlowski
Jan. 13, 2023, 10:33 a.m. UTC
Both of type of watchdogs described in the binding (the KPSS watchdog and APSS WDT timer) have interrupts. Allow interrupts and describe them for KPSS watchdog to fix warnings like: watchdog@17c10000: Unevaluated properties are not allowed ('interrupts' was unexpected) Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Reviewed-by: Rob Herring <robh@kernel.org> --- Changes since v1: 1. Add tag. --- .../bindings/watchdog/qcom-wdt.yaml | 24 ++++++++++++++++--- 1 file changed, 21 insertions(+), 3 deletions(-)
Comments
On Fri, Jan 13, 2023 at 11:33:44AM +0100, Krzysztof Kozlowski wrote: > Both of type of watchdogs described in the binding (the KPSS watchdog > and APSS WDT timer) have interrupts. Allow interrupts and describe them > for KPSS watchdog to fix warnings like: > > watchdog@17c10000: Unevaluated properties are not allowed ('interrupts' was unexpected) > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Reviewed-by: Rob Herring <robh@kernel.org> Reviewed-by: Guenter Roeck <linux@roeck-us.net> > > --- > > Changes since v1: > 1. Add tag. > --- > .../bindings/watchdog/qcom-wdt.yaml | 24 ++++++++++++++++--- > 1 file changed, 21 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml b/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml > index 1828eaf70b3b..b7fc57f4800e 100644 > --- a/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml > +++ b/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml > @@ -9,9 +9,6 @@ title: Qualcomm Krait Processor Sub-system (KPSS) Watchdog timer > maintainers: > - Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org> > > -allOf: > - - $ref: watchdog.yaml# > - > properties: > compatible: > oneOf: > @@ -51,11 +48,31 @@ properties: > clocks: > maxItems: 1 > > + interrupts: > + minItems: 1 > + maxItems: 5 > + > required: > - compatible > - reg > - clocks > > +allOf: > + - $ref: watchdog.yaml# > + > + - if: > + properties: > + compatible: > + contains: > + const: qcom,kpss-wdt > + then: > + properties: > + interrupts: > + minItems: 1 > + items: > + - description: Bark > + - description: Bite > + > unevaluatedProperties: false > > examples: > @@ -66,5 +83,6 @@ examples: > compatible = "qcom,apss-wdt-sm8150", "qcom,kpss-wdt"; > reg = <0x17c10000 0x1000>; > clocks = <&sleep_clk>; > + interrupts = <GIC_SPI 0 IRQ_TYPE_LEVEL_HIGH>; > timeout-sec = <10>; > }; > -- > 2.34.1 >
diff --git a/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml b/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml index 1828eaf70b3b..b7fc57f4800e 100644 --- a/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml +++ b/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml @@ -9,9 +9,6 @@ title: Qualcomm Krait Processor Sub-system (KPSS) Watchdog timer maintainers: - Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org> -allOf: - - $ref: watchdog.yaml# - properties: compatible: oneOf: @@ -51,11 +48,31 @@ properties: clocks: maxItems: 1 + interrupts: + minItems: 1 + maxItems: 5 + required: - compatible - reg - clocks +allOf: + - $ref: watchdog.yaml# + + - if: + properties: + compatible: + contains: + const: qcom,kpss-wdt + then: + properties: + interrupts: + minItems: 1 + items: + - description: Bark + - description: Bite + unevaluatedProperties: false examples: @@ -66,5 +83,6 @@ examples: compatible = "qcom,apss-wdt-sm8150", "qcom,kpss-wdt"; reg = <0x17c10000 0x1000>; clocks = <&sleep_clk>; + interrupts = <GIC_SPI 0 IRQ_TYPE_LEVEL_HIGH>; timeout-sec = <10>; };