From patchwork Fri Jan 13 06:39:09 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Randy Dunlap X-Patchwork-Id: 43007 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp121582wrt; Thu, 12 Jan 2023 22:56:28 -0800 (PST) X-Google-Smtp-Source: AMrXdXsAiTKMZzHBo0ImppzyvZTK/N6kET1XcouJKXBIr29QD5HEZFnCSVvFVMSZ+3hkRPGCN82m X-Received: by 2002:a17:907:3907:b0:840:db38:bf23 with SMTP id so7-20020a170907390700b00840db38bf23mr64142355ejc.26.1673592988767; Thu, 12 Jan 2023 22:56:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673592988; cv=none; d=google.com; s=arc-20160816; b=DjrmkgQMCHkUfwMCMy3C+2/6eq/Re5XRrY28lZElUFDLt2AW27vx0iYZUcOXq5NTlY y4uXVQifm1fOGyDraFOBtXmTNhkuCRbUDjDzp5qRTscp0MCxVlcZ73Yl0eF+oqhoC5KF LDk4QFffbRg9Qs5z4Yhk6WiMUpSQxkmlxEOIHk/uk5wzebmemk0FRH53YU4yIMZxeB6q ayA4yBUzZcukpNJVKG9V/X1/99BFp2Zk6pB8bKMGD5ag8j4F662lvGw8tXErUmlF2J3X 2fk305KuYXrNCG5v2StOkw+ClGe8Tl9a0Vd1dol/+0/aWhiDJENXPGcm/tOnMKD5czIN dbuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=IFdwGnSodtMT979TfMD1yoQI2c7b6/jQ8MRYDII/3hA=; b=ZvmFt26sN9PVxz81biyWn13k5FXaagMtSmZhvkX8l9pJBwNIY0dt8XB2jR1GyzrPR4 3jUdeOce0yDGn/KgtJU6Ia89sePWwVLsSdzKlZcdMogcUBXNkugyPl8qpy2XRSeNzxvo 4A8+Crhrj3NDazPgBviySfIwbviFZNPi/E5JZTKijNUo4WEffoOsZb/ydvx0ycX8l3U4 N0BxX8g18oK9CtAO5r18JQVx/kXQ/6GQC1ueUzfOwI+cBz4ZbhZjzL/l6dlQx4UUnZjk 2g6tpT7GT5oijWGItBAndGYjkfIWcH4bhIYihbxl9TRIhuxgS3E0nwnI3jPJA1dF1aOH ygdg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=Lt436Q2B; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id sc12-20020a1709078a0c00b007aec7f879basi19709322ejc.22.2023.01.12.22.56.05; Thu, 12 Jan 2023 22:56:28 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=Lt436Q2B; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240676AbjAMGzl (ORCPT + 99 others); Fri, 13 Jan 2023 01:55:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56726 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240665AbjAMGyu (ORCPT ); Fri, 13 Jan 2023 01:54:50 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E96866F956 for ; Thu, 12 Jan 2023 22:39:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:In-Reply-To:References; bh=IFdwGnSodtMT979TfMD1yoQI2c7b6/jQ8MRYDII/3hA=; b=Lt436Q2BAmQ8bVisc0xgnbQCp+ eWD0B48NGLCHG8a1S56TqSvnTAZp4FCRze0zgDYiqeTENVDHDEyX18PHlneDgf4PvgijD9suTFYK8 trx5c1eASb6neBPv4DSZUl/nOm0EHfKh4GupWjEkiNZaxxci5ouHwNVvGn/4F/QRhTxTB6FdkeArl xKx+2tV/AlTl6RLU3JB2JoXm+hekWQQcAHapf3wPWxxiMlHyztIZXaVp+9vSMCSUn5VIhwIB7M3qF d7oi+XLYMXYUWL5J8KjLkZLdOm5EJx6vwpM4WS798Xa0lWZ1hAStpY3DrkpVxTBHSiJ8qViFvloAT xFkoSowA==; Received: from [2601:1c2:d80:3110::9307] (helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1pGDiY-000qRn-ET; Fri, 13 Jan 2023 06:39:10 +0000 From: Randy Dunlap To: linux-kernel@vger.kernel.org Cc: Randy Dunlap , Frank Haverkamp , Arnd Bergmann , Greg Kroah-Hartman Subject: [PATCH] misc: genwqe: move intervening macros away from kernel-doc Date: Thu, 12 Jan 2023 22:39:09 -0800 Message-Id: <20230113063909.19694-1-rdunlap@infradead.org> X-Mailer: git-send-email 2.39.0 MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1754889441775180160?= X-GMAIL-MSGID: =?utf-8?q?1754889441775180160?= Don't separate a function's kernel-doc comment and its definition with macros or data; move the macro and data ahead of the function and its comments to prevent a warning: drivers/misc/genwqe/card_utils.c:162: warning: expecting prototype for genwqe_init_crc32(). Prototype was for CRC32_POLYNOMIAL() instead Signed-off-by: Randy Dunlap Cc: Frank Haverkamp Cc: Arnd Bergmann Cc: Greg Kroah-Hartman --- drivers/misc/genwqe/card_utils.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff -- a/drivers/misc/genwqe/card_utils.c b/drivers/misc/genwqe/card_utils.c --- a/drivers/misc/genwqe/card_utils.c +++ b/drivers/misc/genwqe/card_utils.c @@ -151,6 +151,9 @@ int genwqe_read_app_id(struct genwqe_dev return i; } +#define CRC32_POLYNOMIAL 0x20044009 +static u32 crc32_tab[256]; /* crc32 lookup table */ + /** * genwqe_init_crc32() - Prepare a lookup table for fast crc32 calculations * @@ -159,9 +162,6 @@ int genwqe_read_app_id(struct genwqe_dev * * Genwqe's Polynomial = 0x20044009 */ -#define CRC32_POLYNOMIAL 0x20044009 -static u32 crc32_tab[256]; /* crc32 lookup table */ - void genwqe_init_crc32(void) { int i, j;