diff mbox series

[v1,1/1] pinctrl: digicolor: Remove duplicate assignment of of_gpio_n_cells

Message ID 20230112184347.79642-1-andriy.shevchenko@linux.intel.com
State New
Headers
Series [v1,1/1] pinctrl: digicolor: Remove duplicate assignment of of_gpio_n_cells |

Commit Message

Andy Shevchenko Jan. 12, 2023, 6:43 p.m. UTC 
  The of_gpio_n_cells default is 2 when ->of_xlate() callback is
not defined. No need to assign it explicitly in the driver.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/pinctrl/pinctrl-digicolor.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Andy Shevchenko Jan. 13, 2023, 2:32 p.m. UTC | #1 
On Thu, Jan 12, 2023 at 08:43:47PM +0200, Andy Shevchenko wrote:
> The of_gpio_n_cells default is 2 when ->of_xlate() callback is
> not defined. No need to assign it explicitly in the driver.

Ignore this one, it has been (re-)sent as a part of the series which needs
an update, so look forward to the v2 of that one.
diff mbox series

Patch

diff --git a/drivers/pinctrl/pinctrl-digicolor.c b/drivers/pinctrl/pinctrl-digicolor.c
index cc3546fc4610..05213261b8a4 100644
--- a/drivers/pinctrl/pinctrl-digicolor.c
+++ b/drivers/pinctrl/pinctrl-digicolor.c
@@ -248,7 +248,6 @@  static int dc_gpiochip_add(struct dc_pinmap *pmap)
 	chip->set		= dc_gpio_set;
 	chip->base		= -1;
 	chip->ngpio		= PINS_COUNT;
-	chip->of_gpio_n_cells	= 2;
 
 	spin_lock_init(&pmap->lock);