From patchwork Thu Jan 12 17:19:28 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Randy Dunlap X-Patchwork-Id: 42690 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp4023396wrt; Thu, 12 Jan 2023 10:01:05 -0800 (PST) X-Google-Smtp-Source: AMrXdXsAihn1wwiEAOu8FyJ+e5AqmL5uMEk4sfHnsO5dgbHRPxgudpMtk1/C05t3YFtW9ciwzWJh X-Received: by 2002:a05:6a20:94c5:b0:b0:1e9b:e932 with SMTP id ht5-20020a056a2094c500b000b01e9be932mr94715884pzb.40.1673546465232; Thu, 12 Jan 2023 10:01:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673546465; cv=none; d=google.com; s=arc-20160816; b=aKk6ATD3OOiyekdGEgJ3OGiU7TdOtbNmp6k9JGlNSNCPeqg7AoaYSLjRbw8M2PyXgW xfKXwxB4fuiGG4oiPQlpIiCpZLEC2PM36Pfa0l/jTkWJORyhvmrm8bMgYuQkiyT/O2T5 QZJU1NxYBoISiX6c7xgmuPlvRG6YAvv9nKFtIgjE1MJyWuD3IK/vUS9Ror3H103dGoHX y+v30oPyqw9CqRgtnTPF1SeB1g0wOOKGc3HrQWgjxz17T9g7ggCQb3tZhd9xrSsOS2Jw 3sQfdIinvizrtgF8ay0AR1CjEReESXQ2++lH0VfddMRYH9h7xxqHKC4AUn4rBDVHNFbH QtSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=LNFZdqmxri5F07CGFwUu0kpG4HLKkrGeCVzSp+ij6mQ=; b=A0aKKiDM1eNHla5BavGWyEweHlVr6F5eA8rqaPSy7maJ3TQLoN5y/3iODgsOA11WtG VOTDS6flNeUYb9v9KWOkvVNm/mAtL8x8QPDDEqY6CbQWuL830KEZekDjsVO76PQUMZ6C AzyGMz3XhddAXvlRFhdiZt4OPWmfMgjWtdwJZJ7S+tB1pRnKbrgBwHHzK7eSpviXmDXT 3hOS+IbLv2MXWDVEtqe6M+DyqNAXYEWNJY3acbRtshax7V94bj8G/f1gpX6ZJzVPn3aN x0MjLWqAbLIfX+uPV+sm7UW60rCxqlwXVdQzBboiWIOab38uABiu1WpQ8D5pTLcAsWT4 3R+g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=1kvyUBZ8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a186-20020a6390c3000000b004795c10a6c6si6345033pge.665.2023.01.12.10.00.52; Thu, 12 Jan 2023 10:01:05 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=1kvyUBZ8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239941AbjALSA1 (ORCPT + 99 others); Thu, 12 Jan 2023 13:00:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39952 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232194AbjALR7X (ORCPT ); Thu, 12 Jan 2023 12:59:23 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8CBE37DE1D for ; Thu, 12 Jan 2023 09:19:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:In-Reply-To:References; bh=LNFZdqmxri5F07CGFwUu0kpG4HLKkrGeCVzSp+ij6mQ=; b=1kvyUBZ8JMIZJMC9LK+wnH4Lxb h6G9cn4H/Z/gEjQiqKr8ZU4zsW3xrJn0lAj2JkKJFVs9powR1npi/bv5YtY6pSUXZDZxHn50xHH1h jvHg2VCzDhfmesT2ksNcV/QB3fC9nNfvegVrfwEA4nDPdfCiMYgSGDNmMtZ/71UreHWEDQ9qCQ/3O /vcEBYVTo0drU+GhTUivRgRCaznM/RsdyRHNGbzpQ8CiHOjdn21x9rcN6ajMlWuf9EZVKiyR0U+eT Q6lYGvrz5GTQFwUwVtHaoSGvQFbPr8YdhqDRrGn4f4yCb7KBmztSVsUpXR7j8ca8nwUCL8GskUUbg /YCbZayQ==; Received: from [2601:1c2:d80:3110::9307] (helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1pG1Eg-00G06L-47; Thu, 12 Jan 2023 17:19:30 +0000 From: Randy Dunlap To: linux-kernel@vger.kernel.org Cc: Randy Dunlap , kernel test robot , Michael Ellerman , Christophe Leroy , Leo Li , Masahiro Yamada , Nicolas Schier , Qiang Zhao , linuxppc-dev , linux-arm-kernel@lists.infradead.org, Anton Vorontsov , Kumar Gala Subject: [PATCH] soc/fsl/qe: fix usb.c build errors Date: Thu, 12 Jan 2023 09:19:28 -0800 Message-Id: <20230112171928.29653-1-rdunlap@infradead.org> X-Mailer: git-send-email 2.39.0 MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1754840658351455562?= X-GMAIL-MSGID: =?utf-8?q?1754840658351455562?= Fix build errors in soc/fsl/qe/usb.c when QUICC_ENGINE is not set. This happens when PPC_EP88XC is set, which selects CPM1 & CPM. When CPM is set, USB_FSL_QE can be set without QUICC_ENGINE being set. When USB_FSL_QE is set, QE_USB deafults to y, which causes build errors when QUICC_ENGINE is not set. Making QE_USB depend on QUICC_ENGINE prevents QE_USB from defaulting to y. Fixes these build errors: drivers/soc/fsl/qe/usb.o: in function `qe_usb_clock_set': usb.c:(.text+0x1e): undefined reference to `qe_immr' powerpc-linux-ld: usb.c:(.text+0x2a): undefined reference to `qe_immr' powerpc-linux-ld: usb.c:(.text+0xbc): undefined reference to `qe_setbrg' powerpc-linux-ld: usb.c:(.text+0xca): undefined reference to `cmxgcr_lock' powerpc-linux-ld: usb.c:(.text+0xce): undefined reference to `cmxgcr_lock' Fixes: 5e41486c408e ("powerpc/QE: add support for QE USB clocks routing") Signed-off-by: Randy Dunlap Reported-by: kernel test robot Link: https://lore.kernel.org/all/202301101500.pillNv6R-lkp@intel.com/ Suggested-by: Michael Ellerman Cc: Christophe Leroy Cc: Leo Li Cc: Masahiro Yamada Cc: Nicolas Schier Cc: Qiang Zhao Cc: linuxppc-dev Cc: linux-arm-kernel@lists.infradead.org Cc: Anton Vorontsov Cc: Kumar Gala --- drivers/soc/fsl/qe/Kconfig | 1 + 1 file changed, 1 insertion(+) diff -- a/drivers/soc/fsl/qe/Kconfig b/drivers/soc/fsl/qe/Kconfig --- a/drivers/soc/fsl/qe/Kconfig +++ b/drivers/soc/fsl/qe/Kconfig @@ -39,6 +39,7 @@ config QE_TDM config QE_USB bool + depends on QUICC_ENGINE default y if USB_FSL_QE help QE USB Controller support