From patchwork Thu Jan 12 11:28:49 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 42386 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp3832571wrt; Thu, 12 Jan 2023 03:42:04 -0800 (PST) X-Google-Smtp-Source: AMrXdXutFQ6fW5Xdjapk9FUdSWqHFHRXYSsLIFc+t1DHwP36wiEsrvv+C1ooVV/kxc3I+dgohff0 X-Received: by 2002:a05:6402:25cc:b0:45c:835b:9461 with SMTP id x12-20020a05640225cc00b0045c835b9461mr67880227edb.29.1673523724187; Thu, 12 Jan 2023 03:42:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673523724; cv=none; d=google.com; s=arc-20160816; b=oSG032a4l6WGlad3guFbAd6/u4zg7DIidZ2XbtKHdQaNQ+v5LmEELvczWjemUjLVKk o6oxYzQGx9WG+74o3aDwkZru+Kpl21DarKg1fetHrlE57L31xrJVlSfcvrOmWgJ6qwUb Rr5KD6wJbPOCyKOxAjZCjEc383Nn915KE68aJPdoaNqzfzqwCBe1mDs1I+QAOQBCJHHY bScqbZkxOso4bjvNL0q1P57CEp49MxZrOvrFyDy+r9bDz2BFw2HBV9mcw4tx+9oxij4j OvE+ac+Ya+3LDYJJqerVxBlt6dMhNc0lBtkkynbU/BAGV5a/za2462n90c3Ki3fr+VqU 4BgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=god9bqF047Erg7vQUlUT3kAEUUbHphvGViaQd8pEosM=; b=vYpk7t9NZdu7AG7LISte8ZxY8aRe4WQrZkCxfExcEgZQJAZA9D34vCRmcElHG5MKpY GHWusWJG4S6+wxQzmmWt5D1geCmru8WXZSx/Gr07x/nJS/0zl704qIR+DErMC9khdJJy PNORYB7ia4wVi3zqCAv7NgfKNProXhnbH8sjB1fK3nYcuXImJXEJzh98giMAyXUQcFzN XAPWDOSoZVLqbjCcAGlcP+utj1mH168OEEWJ9zVrrIY345sne8tpeF7aHwR6Kx44mWYs T/Ty/g/nObIzdU6/toMjJSTwbSd/UV98NTEqkgKjvG8D3YNZwvDgQ8l1eQuFjcSL6Lh0 gTrg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=STtktRar; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k12-20020a50ce4c000000b00458ff6921e6si18076824edj.79.2023.01.12.03.41.39; Thu, 12 Jan 2023 03:42:04 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=STtktRar; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231582AbjALLhQ (ORCPT + 99 others); Thu, 12 Jan 2023 06:37:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48426 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231655AbjALLgG (ORCPT ); Thu, 12 Jan 2023 06:36:06 -0500 Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9A694FAC8 for ; Thu, 12 Jan 2023 03:28:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1673522911; x=1705058911; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=vjV8y8LbzUXQrt45Puugictbqi3QHzP5bvn2L0BGWt0=; b=STtktRarbQuzNVOUnZPlKjpufgLYeumQxHaNeEGI7sbA/ZdABTh6uZR3 G1agI7ENEq1+0MBbsx43ryAvXWQpKu8gYi6tKwpIvEtjoKgM/UJP2d5Lp Vruv/LC6gUWkahjkrO9sLuManiLWTRp3H2JheP73iM1CQNpWqMbN4U3Ad nKV/YncOediac8+svJWrtMXUTGIPKK6X3RdV9YVJDFfXUNP4QE04AszTk 9eSrgthKa7CVBRMQ4BorgssxMcsIkigQHCngNSk3eilKsa8ahgv7vpon2 akb2WnJwduXGddq4TTu+zylxYEgBYs5ULdLM0BOEUQewPvfr2bbQPK4cI g==; X-IronPort-AV: E=McAfee;i="6500,9779,10586"; a="385994942" X-IronPort-AV: E=Sophos;i="5.96,319,1665471600"; d="scan'208";a="385994942" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jan 2023 03:28:27 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10586"; a="986519423" X-IronPort-AV: E=Sophos;i="5.96,319,1665471600"; d="scan'208";a="986519423" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga005.fm.intel.com with ESMTP; 12 Jan 2023 03:28:22 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id 7C04B14B; Thu, 12 Jan 2023 13:28:56 +0200 (EET) From: Andy Shevchenko To: Mark Brown , Hans de Goede , Pierre-Louis Bossart , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Cc: Cezary Rojewski , Liam Girdwood , Peter Ujfalusi , Bard Liao , Ranjani Sridharan , Kai Vehmanen , Jaroslav Kysela , Takashi Iwai , Andy Shevchenko Subject: [PATCH v2 2/5] ASoC: Intel: bytcr_rt5651: Drop reference count of ACPI device after use Date: Thu, 12 Jan 2023 13:28:49 +0200 Message-Id: <20230112112852.67714-3-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230112112852.67714-1-andriy.shevchenko@linux.intel.com> References: <20230112112852.67714-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1754816812207223739?= X-GMAIL-MSGID: =?utf-8?q?1754816812207223739?= Theoretically the device might gone if its reference count drops to 0. This might be the case when we try to find the first physical node of the ACPI device. We need to keep reference to it until we get a result of the above mentioned call. Refactor the code to drop the reference count at the correct place. While at it, move to acpi_dev_put() as symmetrical call to the acpi_dev_get_first_match_dev(). Fixes: 02c0a3b3047f ("ASoC: Intel: bytcr_rt5651: add MCLK, quirks and cleanups") Signed-off-by: Andy Shevchenko --- sound/soc/intel/boards/bytcr_rt5651.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/intel/boards/bytcr_rt5651.c b/sound/soc/intel/boards/bytcr_rt5651.c index 81ac6eeda2e6..8fca9b82d4d0 100644 --- a/sound/soc/intel/boards/bytcr_rt5651.c +++ b/sound/soc/intel/boards/bytcr_rt5651.c @@ -922,7 +922,6 @@ static int snd_byt_rt5651_mc_probe(struct platform_device *pdev) if (adev) { snprintf(byt_rt5651_codec_name, sizeof(byt_rt5651_codec_name), "i2c-%s", acpi_dev_name(adev)); - put_device(&adev->dev); byt_rt5651_dais[dai_index].codecs->name = byt_rt5651_codec_name; } else { dev_err(dev, "Error cannot find '%s' dev\n", mach->id); @@ -930,6 +929,7 @@ static int snd_byt_rt5651_mc_probe(struct platform_device *pdev) } codec_dev = acpi_get_first_physical_node(adev); + acpi_dev_put(adev); if (!codec_dev) return -EPROBE_DEFER; priv->codec_dev = get_device(codec_dev);