From patchwork Thu Jan 12 11:22:00 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yicong Yang X-Patchwork-Id: 42382 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp3831516wrt; Thu, 12 Jan 2023 03:39:21 -0800 (PST) X-Google-Smtp-Source: AMrXdXuC9cjtJcRixaZVenis2zz8lTLuz8tjkB4ltMknonZekHCU5U9KSJXVCW3Er6G5TuIK/xzu X-Received: by 2002:a17:907:8b93:b0:7c1:1dc7:8837 with SMTP id tb19-20020a1709078b9300b007c11dc78837mr65844408ejc.66.1673523560881; Thu, 12 Jan 2023 03:39:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673523560; cv=none; d=google.com; s=arc-20160816; b=GObjmDfzFcgdRSWBx5m4DTKfDc77rlMWUF4Lp8QPztrvGxe/B3DYF9EZXFcIP/UuKB 0ggiJgD2wY/2fYfSMHiV+1I20MsAwSmvqBUT63yH1AGRpW7z0HckxIY7UNaJCZtwpmtm /ZC32vpJNf7lWDudZb9pzOlmt+2oqfek7iHp0JJedAwSd/1uBS+aSqM82AopcRGO5W1B tb+pbdKx+/7Fg6eVsohEeqOJCBcGOJZr4wtS+0djvTMbIWAOVc7nJsB6Tve90luvA3nT N2H0qXD3GaYC8eeIeiujQThTxhh3VpKf+zFR3jqcQqQN15oa9zmOkhWRsooDUzgjGG/o flwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=9LafidXTdXm2akSyIZnXuxWL4R7IL85w8x8pBIDPGjc=; b=V0rTxJSbHEkBiw6gfGlSUEZIwH4Yk+ifVSXQ/fD1cV2P+njKWOMfX9iNor0/AiGp/s mqbefRhd58/vjlAJRYuvSG6g2JP1IldWHlL3hMljzAzKahakO5vceN/eaTEzBEO1LmK7 rin6CJMdPeqfIFZUv/Y85fGpL0ZZQZZGYMSevUuPCczIILTLx8zgB8vVOJRAq3pBq/ne SSn25SEr90GrTHxC/viGlJEMCOfiO4SZvoLD/d1bRKmnAkzdvC5MSFNbrGgDQ3qZ/qdi FhHpKL3Oul3LTz5O06vKI2AibsbSCDmySxRIsHs76XS/yTo5+LiT0VoEpbGPIGXHCgRm 1eKA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ji6-20020a170907980600b00866bd1c81e9si1984802ejc.419.2023.01.12.03.38.57; Thu, 12 Jan 2023 03:39:20 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231543AbjALLeA (ORCPT + 99 others); Thu, 12 Jan 2023 06:34:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48200 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230124AbjALLdI (ORCPT ); Thu, 12 Jan 2023 06:33:08 -0500 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7F48D4FD47; Thu, 12 Jan 2023 03:22:41 -0800 (PST) Received: from canpemm500009.china.huawei.com (unknown [172.30.72.56]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4Nt2DZ3QwLzJrH1; Thu, 12 Jan 2023 19:21:18 +0800 (CST) Received: from localhost.localdomain (10.50.163.32) by canpemm500009.china.huawei.com (7.192.105.203) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 12 Jan 2023 19:22:37 +0800 From: Yicong Yang To: , , , CC: , , , , , Yicong Yang , Jonathan Cameron Subject: [PATCH v3 1/2] hwtracing: hisi_ptt: Only add the supported devices to the filters list Date: Thu, 12 Jan 2023 19:22:00 +0800 Message-ID: <20230112112201.16283-1-yangyicong@huawei.com> X-Mailer: git-send-email 2.31.0 MIME-Version: 1.0 X-Originating-IP: [10.50.163.32] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To canpemm500009.china.huawei.com (7.192.105.203) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1754816641352858236?= X-GMAIL-MSGID: =?utf-8?q?1754816641352858236?= From: Yicong Yang The PTT device can only support the devices on the same PCIe core, within BDF range [lower_bdf, upper_bdf]. It's not correct to assume the devices on the root bus are from the same PCIe core, there are cases that root ports from different PCIe core are sharing the same bus. So check when initializing the filters list. Fixes: ff0de066b463 ("hwtracing: hisi_ptt: Add trace function support for HiSilicon PCIe Tune and Trace device") Signed-off-by: Yicong Yang Reviewed-by: Jonathan Cameron --- Change since v2: - Refine the commit per Bjorn Link: https://lore.kernel.org/linux-pci/20230110130833.53474-1-yangyicong@huawei.com/ Change since v1: - Add tags from Jonathan Link: https://lore.kernel.org/linux-pci/20221122120209.25682-1-yangyicong@huawei.com/raw drivers/hwtracing/ptt/hisi_ptt.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/drivers/hwtracing/ptt/hisi_ptt.c b/drivers/hwtracing/ptt/hisi_ptt.c index 5d5526aa60c4..30f1525639b5 100644 --- a/drivers/hwtracing/ptt/hisi_ptt.c +++ b/drivers/hwtracing/ptt/hisi_ptt.c @@ -356,8 +356,18 @@ static int hisi_ptt_register_irq(struct hisi_ptt *hisi_ptt) static int hisi_ptt_init_filters(struct pci_dev *pdev, void *data) { + struct pci_dev *root_port = pcie_find_root_port(pdev); struct hisi_ptt_filter_desc *filter; struct hisi_ptt *hisi_ptt = data; + u32 port_devid; + + if (!root_port) + return 0; + + port_devid = PCI_DEVID(root_port->bus->number, root_port->devfn); + if (port_devid < hisi_ptt->lower_bdf || + port_devid > hisi_ptt->upper_bdf) + return 0; /* * We won't fail the probe if filter allocation failed here. The filters