From patchwork Thu Jan 12 07:05:03 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xinghui Li X-Patchwork-Id: 42266 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp3737815wrt; Wed, 11 Jan 2023 23:13:41 -0800 (PST) X-Google-Smtp-Source: AMrXdXuvDXXY2w0Vzals1y6tIo32vpYx1WsgxOsgIRIYhmOUUYH8+R9qZHf0pkiugcT1y/HluroN X-Received: by 2002:a17:906:b10a:b0:84d:c58:f52d with SMTP id u10-20020a170906b10a00b0084d0c58f52dmr20027910ejy.35.1673507620962; Wed, 11 Jan 2023 23:13:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673507620; cv=none; d=google.com; s=arc-20160816; b=xJYg0vGHqtAWtEusL5pTf/t9n4jdX+acdbc2OEy2Kzqm+taXWDTDESck5xHUAXBk7c 3qTqi+7XYaOplMpk9672g1kjRJFnAm357+576ny0gV5ygGYW9D4LTvCqFnVBwaboiFnj Dke1+WBV2xSWldYI4+sTdAKCj1KSqU21Zi6Zz0w5Q/RyK9hCbrlxoEVVYtHzag90EvWb ZrPwY3wemWFrH2fAOz73Gxl4bqQ5Fhp7HYVmtsOT76aMmBLmNwEyF5fhBKRe0yeBNnBS v37mOpBpV+dsfYgUAX5WiAqLnPJzdi3nBSmoZkspeDtLH8spy7ekCw7CzxaVIhuh5SW5 SLEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=FCOp7CGKuJgMZcUzydJ2EeFkj94gRUyaqxOKfxChq2U=; b=gqjBhOcWIvtY3GPaHl07Bn4s/K9q3eRaOLZYJVOgtRY3zVDo786tXBCwgC/8y5BJ1P l/471LxuSiGF1Q17k2hEENwlZizRznXsyX/+y/whq4/IA+5HQ8RtBy6fO7p/t6hOYILl MGdXP/3SeKpn9fsCafxyv/6b1pndYCTk9Da1TqnilNFxIFHQSwciVDi5To3J+aeQRlDD X7q5yrG9B1asHXCQ8N5f1ltAkRBcCktiTsAvS0/nL4n8aXnf5MXX2rznIZn9Oa8pcQ9I cf+yu0sUzyz3o1aIFTTph0tI2Ilms3NWOIVRBaogvMANox1U9COQBjPPnzW2DK5d0xQr GKWQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=ObYQiTjM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id rn5-20020a170906d92500b007c7148d0adcsi13990007ejb.979.2023.01.11.23.13.17; Wed, 11 Jan 2023 23:13:40 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=ObYQiTjM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236035AbjALHFW (ORCPT + 99 others); Thu, 12 Jan 2023 02:05:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45026 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229977AbjALHFU (ORCPT ); Thu, 12 Jan 2023 02:05:20 -0500 Received: from mail-pl1-x642.google.com (mail-pl1-x642.google.com [IPv6:2607:f8b0:4864:20::642]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B5AD64BD79 for ; Wed, 11 Jan 2023 23:05:19 -0800 (PST) Received: by mail-pl1-x642.google.com with SMTP id jl4so19317160plb.8 for ; Wed, 11 Jan 2023 23:05:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=FCOp7CGKuJgMZcUzydJ2EeFkj94gRUyaqxOKfxChq2U=; b=ObYQiTjMQ9zLQ9Y0aV/XuOTFNKjj+rOa3lZzK4STgy6OYXI34kTRdQJ4OkT4Xca/OP nyYAU0jRxfnlRRUVeqsZa1WSNxxop4vjw3iAhcAhjSsFWgjDT8U6X45eUk8C7wH8ZM3U T4+TURds0hddz4PYN9Exy+5IWJPYhFLr6ep2HRBeORiWmvvuQA5d6YPznhISvjDtrL9a ejQ5nMm/E57+K530iqLKxFJClpPjEmXCwQTWsdELmRd3tXiP/53CuCOHEZWerg+4x/vn /O3aYAkPhW7dlrmRbqqaqKUIUhu4JP4A9OgIsbcwMKpqfiHDmnj2NGpi1+09cYx1U7Gl tzaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=FCOp7CGKuJgMZcUzydJ2EeFkj94gRUyaqxOKfxChq2U=; b=fWWl3JW48banJmAjMmya/av1YiSI86zMbWZjNyvQDNfpPIV6HuOXe3DJBEu38N8Vj5 2NdNFmoMVySD5BZ03h9ppYSJCe0Rr2XHy13v23PTcZKXBJ3QcUIEzHi/beUgAzYO71DC UnOM69yvDHDGQqP5H+KDurLvFZGHV4HdJEFD6FaRZCekgxxqEqKcLUk0XhduldemoxpS BSX0NZD7lloxTuKK50VNc+Jqkfl+wXLeuftzjPD2zZ8lem0EX6kkXnJhMdm3AcKtA6Yz MPkCiMr+O7o2SX7GwfVb25/xqcEutoRgEJfv9oRfTC6ahr5ld+xTpiFVC4Vf4Jwwkytp oCaA== X-Gm-Message-State: AFqh2kqaclQW40JDWaupnzGlPdgnS9aZCe6PZM5a7kPhL3icymXFUPLZ qRGh5acv7SrXHlMRXxEkR9J5O6b+pH1hRw== X-Received: by 2002:a17:902:9a06:b0:189:8790:73b1 with SMTP id v6-20020a1709029a0600b00189879073b1mr4927212plp.65.1673507107951; Wed, 11 Jan 2023 23:05:07 -0800 (PST) Received: from localhost.localdomain ([43.132.141.4]) by smtp.gmail.com with ESMTPSA id d11-20020a170902cecb00b001925016e34bsm11459695plg.79.2023.01.11.23.05.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Jan 2023 23:05:07 -0800 (PST) From: korantwork@gmail.com To: ardb@kernel.org, sudeep.holla@arm.com, cristian.marussi@arm.com Cc: linux-kernel@vger.kernel.org, Xinghui Li , loydlv Subject: [PATCH] firmware: fix one UAF issue Date: Thu, 12 Jan 2023 15:05:03 +0800 Message-Id: <20230112070503.817076-1-korantwork@gmail.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1754799927102016337?= X-GMAIL-MSGID: =?utf-8?q?1754799927102016337?= From: Xinghui Li There could be the use after free issue in dmi_sysfs_register_handle. During handling specializations process, the entry->child could be free if the error occurs. However, it will be kobject_put after free. So, we set the entry->child to NULL to avoid above case. Reported-by: loydlv Signed-off-by: Xinghui Li --- drivers/firmware/dmi-sysfs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/firmware/dmi-sysfs.c b/drivers/firmware/dmi-sysfs.c index 66727ad3361b..dd4ff5f7e200 100644 --- a/drivers/firmware/dmi-sysfs.c +++ b/drivers/firmware/dmi-sysfs.c @@ -470,6 +470,7 @@ static int dmi_system_event_log(struct dmi_sysfs_entry *entry) kobject_del(entry->child); out_free: kfree(entry->child); + entry->child = NULL; return ret; }