From patchwork Thu Jan 12 04:21:00 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pin-yen Lin X-Patchwork-Id: 42244 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp3686940wrt; Wed, 11 Jan 2023 20:24:17 -0800 (PST) X-Google-Smtp-Source: AMrXdXufWKiQ5f6jRTbItVyGfisbJHHt3AMAk0bcMh/MYGrf2PHuBnsaUXJEs2reAgYfJj8Kq37S X-Received: by 2002:a17:907:c30c:b0:7c1:337e:5755 with SMTP id tl12-20020a170907c30c00b007c1337e5755mr39369016ejc.26.1673497457217; Wed, 11 Jan 2023 20:24:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673497457; cv=none; d=google.com; s=arc-20160816; b=sBcCLn+GP1dxl3an0Tofr/DDPYioeJlfdAKd0bO7hgw24KFFSMe43pUTtNlRSmrEQE igz79Y6fsCtlQr5VQQWVpJ4g/SoWNOscFzxPVC3cJVgsTf6RIr726hurp/Bd9oTNgqge YrU4mSpkpfx4721LTkeJyg+pgSBeKxY7XxzzsVmo2NNeHevx3cIhsfZ/7TDXKXfnR8fi 8Vsb1CvSVnAdcB79R6+rLldbHhWgXgopxiQ0l5ee/S+7GkdQGbrSF0dgsnDmDwiHgRT5 LcsnrEOPX13mcHLOmkJ2HHXlpzD58k6OJ+haT2cSHGa/hlAbdFoKvsaXJltoXRbX5tRQ IFkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=X4fsKZ8vfmDfUc1Nfjl36ivIzejXzy6Kt8K+gcJWI24=; b=u+3ztrPVG/V+A8KkpHQgI+xc+NCsOpvDeemyhpY3vPYlHi7SS4UDWSAK0TmOxL+9Vc tDsurQrj/RlMCA0lgQXHqzK35X8FWf76daOUPyA/BvRDMDBZX0v7nXkmOqLznMFKels9 qyYBT+mnclw1JcHLdmA3RboWhi/snGJFYZdGHYMQi8TROByY2BCflTrbXa4susVzIq7D VsU1NGrHcXtseP0TNWqTYeXw3EL3o8RSf+sbpnKfQ8hMuXw7gMUCqCZZ5a6mxk2ChbRY obd6UXE24Xr09fXBQypP4xw6GFD6B+O/pV3AqugaffQul0ciFOEWjnYzLu8iyQvTSPHb yr6A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=mkPluvk5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id gb12-20020a170907960c00b007c1633cea0csi18198379ejc.513.2023.01.11.20.23.54; Wed, 11 Jan 2023 20:24:17 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=mkPluvk5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239479AbjALEXE (ORCPT + 99 others); Wed, 11 Jan 2023 23:23:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54804 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236805AbjALEWB (ORCPT ); Wed, 11 Jan 2023 23:22:01 -0500 Received: from mail-pg1-x52f.google.com (mail-pg1-x52f.google.com [IPv6:2607:f8b0:4864:20::52f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CCE7ABE00 for ; Wed, 11 Jan 2023 20:21:47 -0800 (PST) Received: by mail-pg1-x52f.google.com with SMTP id s67so11970412pgs.3 for ; Wed, 11 Jan 2023 20:21:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=X4fsKZ8vfmDfUc1Nfjl36ivIzejXzy6Kt8K+gcJWI24=; b=mkPluvk59KIiAcPlMDzERaNoAA9HeVVqvopt0+jh3JVWYVk5ewNwNrAH9p0jo5Iwws 2CQ86HkEsKNCSwoYJKBDsEcZe8eQR/vO6t/ZPbARJBLEagCttO1T7hJDbm9X73MbQz2h pC/tdKthbblySuECemzkzZQ0F+XgWqAGd7pkE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=X4fsKZ8vfmDfUc1Nfjl36ivIzejXzy6Kt8K+gcJWI24=; b=FLNWr/6kJgPR8ohVSzNYnkcFvs8wQudRgD9v1oXcHcynHy9pKZGG1BNiOecTvM8gL5 wTxsePkv1tTDKJxg9re8gIcPbHMDQOdTuVFet9K1jN/nXL0YNsjrLcCycDBRFRMMMS1k gUvVEVUYwrNt+0yT318EblXK20a0EQqFPxEaZhReGl1HhQHkh5rG9XGRALjOTNCVF/qI vrpavaC9xb2fqI9QCXx17lE2cQ7N1G9q92h1uLEGATWnywJQk7uPpijLoCL+85v3Jjee iLv3wqwNccBfSCdnLrB7RI0ooald05dIy/IJGjtbaptmCRrC1ARBLjkCkN1w0y9VOVTu BXmA== X-Gm-Message-State: AFqh2krXLLddO1shSaB2RgYCXxArrFz9bJN8EynyLiwoJ/Yh0XHzmWzk 10QWrqT2Nu8cnEey3YAG4eh7FQ== X-Received: by 2002:a62:4dc7:0:b0:586:210b:2b67 with SMTP id a190-20020a624dc7000000b00586210b2b67mr17041922pfb.6.1673497307326; Wed, 11 Jan 2023 20:21:47 -0800 (PST) Received: from treapking.tpe.corp.google.com ([2401:fa00:1:10:594f:5484:7591:d074]) by smtp.gmail.com with ESMTPSA id s8-20020aa78bc8000000b00582579cb0e0sm5519478pfd.129.2023.01.11.20.21.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Jan 2023 20:21:47 -0800 (PST) From: Pin-yen Lin To: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , Andy Shevchenko , Daniel Scally , Heikki Krogerus , Sakari Ailus , Greg Kroah-Hartman , "Rafael J . Wysocki" , Prashant Malani , Benson Leung , Guenter Roeck Cc: Stephen Boyd , Pin-yen Lin , =?utf-8?q?N=C3=ADcolas_F_=2E_R_=2E_A_=2E_Prado?= , Marek Vasut , AngeloGioacchino Del Regno , devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, Javier Martinez Canillas , Lyude Paul , chrome-platform@lists.linux.dev, Xin Ji , Thomas Zimmermann , linux-kernel@vger.kernel.org, Allen Chen , linux-acpi@vger.kernel.org, Hsin-Yi Wang , Chen-Yu Tsai , =?utf-8?b?Sm9zw6kgRXhww7NzaXRv?= , =?utf-8?q?Uwe?= =?utf-8?q?_Kleine-K=C3=B6nig?= Subject: [PATCH v10 5/9] drm/bridge: anx7625: Check for Type-C during panel registration Date: Thu, 12 Jan 2023 12:21:00 +0800 Message-Id: <20230112042104.4107253-6-treapking@chromium.org> X-Mailer: git-send-email 2.39.0.314.g84b9a713c41-goog In-Reply-To: <20230112042104.4107253-1-treapking@chromium.org> References: <20230112042104.4107253-1-treapking@chromium.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1754789269860543474?= X-GMAIL-MSGID: =?utf-8?q?1754789269860543474?= The output port endpoints can be connected to USB-C connectors. Running drm_of_find_panel_or_bridge() with such endpoints leads to a continuous return value of -EPROBE_DEFER, even though there is no panel present. To avoid this, check for the existence of a "mode-switch" property in the port endpoint, and skip panel registration completely if so. Signed-off-by: Pin-yen Lin Reviewed-by: Chen-Yu Tsai Tested-by: Chen-Yu Tsai --- Changes in v10: - Collected Reviewed-by and Tested-by tags Changes in v6: - New in v6 drivers/gpu/drm/bridge/analogix/anx7625.c | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c index b375887e655d..1cf242130b91 100644 --- a/drivers/gpu/drm/bridge/analogix/anx7625.c +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c @@ -1649,7 +1649,7 @@ static int anx7625_get_swing_setting(struct device *dev, static int anx7625_parse_dt(struct device *dev, struct anx7625_platform_data *pdata) { - struct device_node *np = dev->of_node, *ep0; + struct device_node *np = dev->of_node, *ep0, *sw; int bus_type, mipi_lanes; anx7625_get_swing_setting(dev, pdata); @@ -1688,6 +1688,17 @@ static int anx7625_parse_dt(struct device *dev, if (of_property_read_bool(np, "analogix,audio-enable")) pdata->audio_en = 1; + /* + * Don't bother finding a panel if a Type-C `mode-switch` property is + * present in one of the endpoints. + */ + for_each_endpoint_of_node(np, sw) { + if (of_property_read_bool(sw, "mode-switch")) { + of_node_put(sw); + return 0; + } + } + pdata->panel_bridge = devm_drm_of_get_bridge(dev, np, 1, 0); if (IS_ERR(pdata->panel_bridge)) { if (PTR_ERR(pdata->panel_bridge) == -ENODEV) {