| Message ID | 20230111114337.24782-5-quic_sibis@quicinc.com |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp3271458wrt;
Wed, 11 Jan 2023 03:47:07 -0800 (PST)
X-Google-Smtp-Source:
AMrXdXsJ3/DIY90VTpmuk5UylU7B/0QXV3CmUZSsf00GE9AaabCjRD1s9NIdmym/iQL6j8K8rMsw
X-Received: by 2002:a17:902:7c0a:b0:192:c809:a1dd with SMTP id
x10-20020a1709027c0a00b00192c809a1ddmr2151438pll.20.1673437627081;
Wed, 11 Jan 2023 03:47:07 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1673437627; cv=none;
d=google.com; s=arc-20160816;
b=CMLZgUH86CJooEjyLMImVoQ5Dw+7yb1ERsYJWa4uiAgefCq6JgwdEGxUgZXYEPamyk
AXQLPrXDLDzg/II1OmMqO2IKBQPVbZxLZSVbtISIRsAOFCQMvZGkmgtvoIHVRCTrSpjf
b9gRm2wENkOW71MUX7QT4+iGWHAqu7JqqiHpf3FKXj+3aCHbrc+WsmY9k/+O+UNNdekw
qnwarZo+S/kwuC1T3bSBPrecLrJo256pOgRns5TgUaHWCmoycFzZucmTa5xZp7OPN89B
ZmKO3A4x2hwX6OzOIKH5g9/cxIe+tZChjrQIWTc9u2gaicEhdvVHZzzJzcWftBtxx+Bt
68FQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:mime-version:references:in-reply-to:message-id
:date:subject:cc:to:from:dkim-signature;
bh=LK51BeKDmJ1w0wa5xttBxkdXdUKlvG/KRCLgmWha3WU=;
b=eEDJKTV7oWW3Cerju6P+sjUMjAlI5xTFFgacq/3ZP1iFuVwQVCKSsoPiSUUhRfQXk8
9seZbIknDPcVuUCSj0B9rpKSuj2y6ghzqNBk02qWqa9HtHwz9zLK8VmdgtBQTAfSCCqG
LwY2iUTxfydg87UTYFEG1NyvMDT9sQMYq8RnZC0s656QITAEo9qcIZWLNOS1yXkjsq19
LbzylRY21ihXjpLdlg/eMDl7MIyt2vknuFHM84KKM9BGl+USZhbtW60XkudWwdt/pH3a
RdoyZqtVFnXjmK/QTeKeYuMM3cxfiflikOIJ4PZtL8T7Q/HYv73nBHsAB+eN2piipTqW
9y+g==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=aH2QVPOy;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
s9-20020a170902ea0900b00189d12c0dd9si14905396plg.555.2023.01.11.03.46.54;
Wed, 11 Jan 2023 03:47:07 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=aH2QVPOy;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S238562AbjAKLqX (ORCPT <rfc822;syz17693488234@gmail.com>
+ 99 others); Wed, 11 Jan 2023 06:46:23 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42462 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S236274AbjAKLpk (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Wed, 11 Jan 2023 06:45:40 -0500
Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com
[205.220.180.131])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 89203D2FA;
Wed, 11 Jan 2023 03:44:29 -0800 (PST)
Received: from pps.filterd (m0279869.ppops.net [127.0.0.1])
by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id
30B90Tsn025992;
Wed, 11 Jan 2023 11:44:17 GMT
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com;
h=from : to : cc :
subject : date : message-id : in-reply-to : references : mime-version :
content-type; s=qcppdkim1;
bh=LK51BeKDmJ1w0wa5xttBxkdXdUKlvG/KRCLgmWha3WU=;
b=aH2QVPOy4Vk5lfu1LCDrq5De9QPdiHeunT5Ky/W/DThDOVv0VOJykukv1izJs4aDnDbD
gTqDhJUlCLR33xCEelIQAgJrPteSapDQ0x4pUlp+pZ/lHooM2yjBbpJE9q/tSlI1A9Hi
t6KgPraTi9ZxmrFMCYO+8xRbfcfuqeeEVbqI7ihJwqbi3eUEIFbqxbar/EcUuWkWAueh
j0ew27ENpMv8aKRoZ5Tor4XUDopVQGCIFZnWhvw8l+WSUj9X4ura7U/6rgbzJxkI6KYH
wjOW/fVT2/rN033fDK8Q9x6A+fwoljZOAPZVlPFYvOVaMm/Tn8axb/4SzXS1Qr4oC0rR aA==
Received: from nalasppmta03.qualcomm.com (Global_NAT1.qualcomm.com
[129.46.96.20])
by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3n1k7qs4kq-1
(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256
verify=NOT);
Wed, 11 Jan 2023 11:44:17 +0000
Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com
[10.47.209.196])
by NALASPPMTA03.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id
30BBiGq8024813
(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256
verify=NOT);
Wed, 11 Jan 2023 11:44:16 GMT
Received: from blr-ubuntu-87.ap.qualcomm.com (10.80.80.8) by
nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
15.2.986.36; Wed, 11 Jan 2023 03:44:11 -0800
From: Sibi Sankar <quic_sibis@quicinc.com>
To: <andersson@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
<manivannan.sadhasivam@linaro.org>
CC: <agross@kernel.org>, <linux-arm-msm@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<robh+dt@kernel.org>, <konrad.dybcio@somainline.org>,
<amit.pundir@linaro.org>, <regressions@leemhuis.info>,
<sumit.semwal@linaro.org>, <will@kernel.org>,
<catalin.marinas@arm.com>, <robin.murphy@arm.com>,
Sibi Sankar <quic_sibis@quicinc.com>
Subject: [PATCH V3 04/10] dt-bindings: remoteproc: qcom,sc7280-mss-pil: Update
memory-region
Date: Wed, 11 Jan 2023 17:13:31 +0530
Message-ID: <20230111114337.24782-5-quic_sibis@quicinc.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20230111114337.24782-1-quic_sibis@quicinc.com>
References: <20230111114337.24782-1-quic_sibis@quicinc.com>
MIME-Version: 1.0
Content-Type: text/plain
X-Originating-IP: [10.80.80.8]
X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To
nalasex01a.na.qualcomm.com (10.47.209.196)
X-QCInternal: smtphost
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800
signatures=585085
X-Proofpoint-GUID: n1ZAwo8YDElHWfyEQtDVnNSh1PMydGC4
X-Proofpoint-ORIG-GUID: n1ZAwo8YDElHWfyEQtDVnNSh1PMydGC4
X-Proofpoint-Virus-Version: vendor=baseguard
engine=ICAP:2.0.219,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1
definitions=2023-01-11_05,2023-01-11_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0
spamscore=0 phishscore=0
suspectscore=0 priorityscore=1501 mlxlogscore=984 lowpriorityscore=0
adultscore=0 malwarescore=0 clxscore=1015 impostorscore=0 mlxscore=0
bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
engine=8.12.0-2212070000 definitions=main-2301110086
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS
autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1754726533454734491?=
X-GMAIL-MSGID: =?utf-8?q?1754726533454734491?=
|
| Series |
Fix XPU violation during modem metadata authentication
|
|
Commit Message
Sibi Sankar
Jan. 11, 2023, 11:43 a.m. UTC
The dynamic memory region used for metadata authentication would still be a part of the kernel mapping and any access to this region by the application processor after assigning it to the remote Q6 will result in a XPU violation. This is fixed by using a no-map carveout instead. Update the bindings to reflect the addition of the new modem metadata carveout on SC7280 SoC. Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Signed-off-by: Sibi Sankar <quic_sibis@quicinc.com> --- v3: * remove double space [Krzysztof] * Pickup R-b v2: * Pad commit message to explain bindings break [Krzysztof] * Split dt/bindings per SoC [Krzysztof] .../devicetree/bindings/remoteproc/qcom,sc7280-mss-pil.yaml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
Comments
On Wed, 11 Jan 2023 17:13:31 +0530, Sibi Sankar wrote: > The dynamic memory region used for metadata authentication would still > be a part of the kernel mapping and any access to this region by the > application processor after assigning it to the remote Q6 will result > in a XPU violation. This is fixed by using a no-map carveout instead. > Update the bindings to reflect the addition of the new modem metadata > carveout on SC7280 SoC. > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Signed-off-by: Sibi Sankar <quic_sibis@quicinc.com> > --- > > v3: > * remove double space [Krzysztof] > * Pickup R-b > > v2: > * Pad commit message to explain bindings break [Krzysztof] > * Split dt/bindings per SoC [Krzysztof] > > .../devicetree/bindings/remoteproc/qcom,sc7280-mss-pil.yaml | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > Running 'make dtbs_check' with the schema in this patch gives the following warnings. Consider if they are expected or the schema is incorrect. These may not be new warnings. Note that it is not yet a requirement to have 0 warnings for dtbs_check. This will change in the future. Full log is available here: https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230111114337.24782-5-quic_sibis@quicinc.com remoteproc@4080000: memory-region: [[226], [227]] is too short arch/arm64/boot/dts/qcom/sc7280-idp.dtb remoteproc@4080000: memory-region: [[231], [232]] is too short arch/arm64/boot/dts/qcom/sc7280-idp2.dtb remoteproc@4080000: memory-region: [[234], [235]] is too short arch/arm64/boot/dts/qcom/sc7280-crd-r3.dtb remoteproc@4080000: memory-region: [[240], [241]] is too short arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r0.dtb remoteproc@4080000: memory-region: [[243], [244]] is too short arch/arm64/boot/dts/qcom/sc7280-herobrine-crd.dtb arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r1-lte.dtb remoteproc@4080000: memory-region: [[248], [249]] is too short arch/arm64/boot/dts/qcom/sc7280-herobrine-zombie-lte.dtb remoteproc@4080000: memory-region: [[251], [252]] is too short arch/arm64/boot/dts/qcom/sc7280-herobrine-herobrine-r1.dtb remoteproc@4080000: memory-region: [[252], [253]] is too short arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker-lte.dtb remoteproc@4080000: qcom,halt-regs:0: [231] is too short arch/arm64/boot/dts/qcom/sc7280-idp.dtb remoteproc@4080000: qcom,halt-regs:0: [236] is too short arch/arm64/boot/dts/qcom/sc7280-idp2.dtb remoteproc@4080000: qcom,halt-regs:0: [239] is too short arch/arm64/boot/dts/qcom/sc7280-crd-r3.dtb remoteproc@4080000: qcom,halt-regs:0: [245] is too short arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r0.dtb remoteproc@4080000: qcom,halt-regs:0: [248] is too short arch/arm64/boot/dts/qcom/sc7280-herobrine-crd.dtb arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r1-lte.dtb remoteproc@4080000: qcom,halt-regs:0: [253] is too short arch/arm64/boot/dts/qcom/sc7280-herobrine-zombie-lte.dtb remoteproc@4080000: qcom,halt-regs:0: [256] is too short arch/arm64/boot/dts/qcom/sc7280-herobrine-herobrine-r1.dtb remoteproc@4080000: qcom,halt-regs:0: [257] is too short arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker-lte.dtb
diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sc7280-mss-pil.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sc7280-mss-pil.yaml index b4de0521a89d..005cb21732af 100644 --- a/Documentation/devicetree/bindings/remoteproc/qcom,sc7280-mss-pil.yaml +++ b/Documentation/devicetree/bindings/remoteproc/qcom,sc7280-mss-pil.yaml @@ -95,6 +95,7 @@ properties: items: - description: MBA reserved region - description: modem reserved region + - description: metadata reserved region firmware-name: $ref: /schemas/types.yaml#/definitions/string-array @@ -240,7 +241,7 @@ examples: <&rpmhpd SC7280_MSS>; power-domain-names = "cx", "mss"; - memory-region = <&mba_mem>, <&mpss_mem>; + memory-region = <&mba_mem>, <&mpss_mem>, <&mdata_mem>; qcom,qmp = <&aoss_qmp>;