From patchwork Wed Jan 11 07:57:59 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shaopeng Tan X-Patchwork-Id: 41807 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp3187440wrt; Wed, 11 Jan 2023 00:02:36 -0800 (PST) X-Google-Smtp-Source: AMrXdXv4EJuqGMpsIl3LI8nGSra1iPXH1Ru7RZ1QcrleGzmGyRwa+zzq36kzDp93HcnstSHlExfw X-Received: by 2002:a05:6402:d9:b0:48e:c83d:a935 with SMTP id i25-20020a05640200d900b0048ec83da935mr25060935edu.29.1673424156301; Wed, 11 Jan 2023 00:02:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673424156; cv=none; d=google.com; s=arc-20160816; b=ab3ifrdgqz/cLtEvzLPAPkcXwsx/W+lVir8+3rLRNBo2GhpbT6PFpdz8K5TqHTd/B3 DjD0XcVOz040MY++Cle8oMBtVer8ph3pHvjcvLuzvk95Yr7+Lj/En22IMMWtT5QvAsW8 zk4TqYF01DoX0mY1uBD4jLCCk+5Gv92qPrghDcJowsWbk4raYompK4tjERmmQJLMqIpM CtTHGX+DnzD7+nwvm9iSwgJFNOr5YBHDIGDfsFVO0iwN070+ykeaTrd+G/28FuQO40Pi EElGH3s1IuNuqjqhbxb/ZnhDcKVkQHUfHqcRwjXWxEtNJrPPK4TM8dwgDzRHMgYdR5vt GBow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=8vB7wSoHkVQdDBEgWvv4iIcFC9Fe76TYmbSGIUh7/DA=; b=cvjOEwOJ500HNuQHwsWgQ6/atAVF45pmYuZxPRIbR9EfnMlDsDpNKWCiV35ckydZpT kDZ42N27C8ub/NoEFnM7sy71cGL81hxVOl9dgnaauQL/RSc1mU7mvR6RPvAVhIWImrN1 tkKO1YGuLTavJoSGbVhi2AkNSfqkzva5rVhm4MqxkcMuL9Inrgb2CkHs4+UGVnzkY8ZO cGlAtcyVnpkl21AmcHehCMJuaHO76Z8Zf3Y0WWLENAb/GyOO9lfoJLxxmskDBkPzXtoH u0jfW1WlNQL4khDEz3i/q7wXGjwf9gNuHbgtq8HGsyJmyDTI6sLz5qMnqTicJX5Y1WZk 3u0Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=fujitsu.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q11-20020aa7d44b000000b004974f256f48si10970054edr.576.2023.01.11.00.02.12; Wed, 11 Jan 2023 00:02:36 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=fujitsu.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231644AbjAKIAq (ORCPT + 99 others); Wed, 11 Jan 2023 03:00:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59466 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231610AbjAKIAe (ORCPT ); Wed, 11 Jan 2023 03:00:34 -0500 Received: from esa1.hc1455-7.c3s2.iphmx.com (esa1.hc1455-7.c3s2.iphmx.com [207.54.90.47]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 46654C74 for ; Wed, 11 Jan 2023 00:00:32 -0800 (PST) X-IronPort-AV: E=McAfee;i="6500,9779,10586"; a="102719473" X-IronPort-AV: E=Sophos;i="5.96,315,1665414000"; d="scan'208";a="102719473" Received: from unknown (HELO yto-r2.gw.nic.fujitsu.com) ([218.44.52.218]) by esa1.hc1455-7.c3s2.iphmx.com with ESMTP; 11 Jan 2023 16:59:27 +0900 Received: from yto-m3.gw.nic.fujitsu.com (yto-nat-yto-m3.gw.nic.fujitsu.com [192.168.83.66]) by yto-r2.gw.nic.fujitsu.com (Postfix) with ESMTP id 8B5A0DE50F; Wed, 11 Jan 2023 16:59:26 +0900 (JST) Received: from yto-om4.fujitsu.com (yto-om4.o.css.fujitsu.com [10.128.89.165]) by yto-m3.gw.nic.fujitsu.com (Postfix) with ESMTP id DD9AD16E22; Wed, 11 Jan 2023 16:59:25 +0900 (JST) Received: from cn-r05-10.example.com (n3235113.np.ts.nmh.cs.fujitsu.co.jp [10.123.235.113]) by yto-om4.fujitsu.com (Postfix) with ESMTP id B36284007B0E8; Wed, 11 Jan 2023 16:59:25 +0900 (JST) From: Shaopeng Tan To: Fenghua Yu , Reinette Chatre , Shuah Khan Cc: linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, tan.shaopeng@jp.fujitsu.com, Shuah Khan Subject: [PATCH v5 2/5] selftests/resctrl: Return MBA check result and make it to output message Date: Wed, 11 Jan 2023 16:57:59 +0900 Message-Id: <20230111075802.3556803-3-tan.shaopeng@jp.fujitsu.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20230111075802.3556803-1-tan.shaopeng@jp.fujitsu.com> References: <20230111075802.3556803-1-tan.shaopeng@jp.fujitsu.com> MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1754712408070808629?= X-GMAIL-MSGID: =?utf-8?q?1754712408070808629?= Since MBA check result is not returned, the MBA test result message is always output as "ok" regardless of whether the MBA check result is true or false. Make output message to be "not ok" if MBA check result is failed. Reviewed-by: Shuah Khan Reviewed-by: Reinette Chatre Signed-off-by: Shaopeng Tan --- tools/testing/selftests/resctrl/mba_test.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/tools/testing/selftests/resctrl/mba_test.c b/tools/testing/selftests/resctrl/mba_test.c index 1a1bdb6180cf..e3a473976d74 100644 --- a/tools/testing/selftests/resctrl/mba_test.c +++ b/tools/testing/selftests/resctrl/mba_test.c @@ -51,10 +51,10 @@ static int mba_setup(int num, ...) return 0; } -static void show_mba_info(unsigned long *bw_imc, unsigned long *bw_resc) +static bool show_mba_info(unsigned long *bw_imc, unsigned long *bw_resc) { int allocation, runs; - bool failed = false; + bool ret = false; ksft_print_msg("Results are displayed in (MB)\n"); /* Memory bandwidth from 100% down to 10% */ @@ -90,13 +90,15 @@ static void show_mba_info(unsigned long *bw_imc, unsigned long *bw_resc) ksft_print_msg("avg_bw_imc: %lu\n", avg_bw_imc); ksft_print_msg("avg_bw_resc: %lu\n", avg_bw_resc); if (avg_diff_per > MAX_DIFF_PERCENT) - failed = true; + ret = true; } ksft_print_msg("%s Check schemata change using MBA\n", - failed ? "Fail:" : "Pass:"); - if (failed) + ret ? "Fail:" : "Pass:"); + if (ret) ksft_print_msg("At least one test failed\n"); + + return ret; } static int check_results(void) @@ -132,9 +134,7 @@ static int check_results(void) fclose(fp); - show_mba_info(bw_imc, bw_resc); - - return 0; + return show_mba_info(bw_imc, bw_resc); } void mba_test_cleanup(void)