From patchwork Tue Jan 10 20:56:25 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Kaiser X-Patchwork-Id: 41651 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp2968847wrt; Tue, 10 Jan 2023 13:05:59 -0800 (PST) X-Google-Smtp-Source: AMrXdXtAcNzj4bGulIR3YjUGfADdiKdaM+omCch0rH1FzdrC0YcCSwpDrdBrKuwGwMfB3mDHtMtc X-Received: by 2002:a17:906:edd6:b0:84d:138a:316 with SMTP id sb22-20020a170906edd600b0084d138a0316mr16860241ejb.36.1673384759040; Tue, 10 Jan 2023 13:05:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673384759; cv=none; d=google.com; s=arc-20160816; b=o7MIPWivA0lAqdwU6k7W9RgD4BI1nxnPEECp6liHZ88s+Wi3mcvpcc7oeFuLNhDxzV /ze9x/kNFdrxtkkt8iXuV7OiWVxb8nn/4ZyYEQ1oRlYao/8XL+gc12iGiPxgzL6Rpe+x PoxIkLb5besRAiZ1jwEOBQk/GovUzl/brR5iqxf11ldC3tD5hZ5A4lP2ww3knfWF1/8u f5UMZt0L8DK040mtqpfbgjSeou4H7c0MyA19vRX6WQaRogXfMLjpBiOPnrFpW5VazEdy LNQOY9eTz5Olcofmv0/XTQO9Si7+x/eJ7SsUoAsaXTk3E6QsxutiNGV49S3gGgHCq3y/ nlLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=duaSGrKtE66rXiV+ofxr8Kmbaffk2hy1kZcv3tEb+G8=; b=mrj2FCy8QOK836SgpxP7Tq/uhPX+48TC9Vm519FyLlAWqmvd7aDgY14/JMKkk9FEsB t8GDSuf8krRt1tvy8VzvKpsOb4DakjeeZS1qYlM6viqkQMC4gHVS6Hkao6U4OWqe+L6T GPTm190HZ2OvyC3ubckem3oaFS8+pT1BcK3tooTbBYhnCB9UGR1ovS0XrJov6LaHx+Na wdXIw1G0ukxjbWBk2urhlD6SV/fuwiP1noa9A/mN4iPt5F5t6evcM6P3pKd9GwkrOhHT ftFtlPasu20is7/vF4U6CZ/cCzOQUW+zf3UbGOSwIE9d9EeN1n1HNWULpAli+tazIFmc 1+GA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u5-20020a170906654500b0084c950a7956si10053761ejn.144.2023.01.10.13.05.35; Tue, 10 Jan 2023 13:05:59 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232025AbjAJU4x (ORCPT + 99 others); Tue, 10 Jan 2023 15:56:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55030 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233700AbjAJU4r (ORCPT ); Tue, 10 Jan 2023 15:56:47 -0500 Received: from viti.kaiser.cx (viti.kaiser.cx [IPv6:2a01:238:43fe:e600:cd0c:bd4a:7a3:8e9f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 231033C3AF for ; Tue, 10 Jan 2023 12:56:45 -0800 (PST) Received: from dslb-178-004-206-224.178.004.pools.vodafone-ip.de ([178.4.206.224] helo=martin-debian-2.paytec.ch) by viti.kaiser.cx with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1pFLfk-0001pw-9H; Tue, 10 Jan 2023 21:56:40 +0100 From: Martin Kaiser To: Greg Kroah-Hartman Cc: Larry Finger , Phillip Potter , Michael Straube , Pavel Skripkin , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Martin Kaiser Subject: [PATCH 3/4] staging: r8188eu: remove unused function parameter Date: Tue, 10 Jan 2023 21:56:25 +0100 Message-Id: <20230110205626.183516-4-martin@kaiser.cx> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230110205626.183516-1-martin@kaiser.cx> References: <20230110205626.183516-1-martin@kaiser.cx> MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1754671097166259504?= X-GMAIL-MSGID: =?utf-8?q?1754671097166259504?= The regs parameter of the usb_write_port_complete function is not used. We can remove it. We can also remove the macro to hide the regs parameter when usb_write_port_complete is used as callback function for an urb transfer. Signed-off-by: Martin Kaiser --- drivers/staging/r8188eu/include/usb_ops_linux.h | 2 -- drivers/staging/r8188eu/os_dep/usb_ops_linux.c | 2 +- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/r8188eu/include/usb_ops_linux.h b/drivers/staging/r8188eu/include/usb_ops_linux.h index 966688eedf66..e406a1fccda7 100644 --- a/drivers/staging/r8188eu/include/usb_ops_linux.h +++ b/drivers/staging/r8188eu/include/usb_ops_linux.h @@ -19,8 +19,6 @@ usb_bulkout_zero_complete(purb) #define usb_write_mem_complete(purb, regs) \ usb_write_mem_complete(purb) -#define usb_write_port_complete(purb, regs) \ - usb_write_port_complete(purb) #define usb_read_port_complete(purb, regs) \ usb_read_port_complete(purb) #define usb_read_interrupt_complete(purb, regs) \ diff --git a/drivers/staging/r8188eu/os_dep/usb_ops_linux.c b/drivers/staging/r8188eu/os_dep/usb_ops_linux.c index 7da13b87d726..3fd080091340 100644 --- a/drivers/staging/r8188eu/os_dep/usb_ops_linux.c +++ b/drivers/staging/r8188eu/os_dep/usb_ops_linux.c @@ -35,7 +35,7 @@ void rtw_read_port_cancel(struct adapter *padapter) } } -static void usb_write_port_complete(struct urb *purb, struct pt_regs *regs) +static void usb_write_port_complete(struct urb *purb) { struct xmit_buf *pxmitbuf = (struct xmit_buf *)purb->context; struct adapter *padapter = pxmitbuf->padapter;