From patchwork Tue Jan 10 18:58:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mingwei Zhang X-Patchwork-Id: 41590 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp2919187wrt; Tue, 10 Jan 2023 11:04:23 -0800 (PST) X-Google-Smtp-Source: AMrXdXv0pffL8BetEXJdgFOq9mmHo5Nmm9b8j1hAzjXV8Bdw2sW6KFtHiqWklX3yOemdSk+VqC61 X-Received: by 2002:a17:90b:716:b0:226:cbb4:1451 with SMTP id s22-20020a17090b071600b00226cbb41451mr18188515pjz.37.1673377463529; Tue, 10 Jan 2023 11:04:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673377463; cv=none; d=google.com; s=arc-20160816; b=tZv5/AfcB2YUqDVEtI/8XaFV+qJd0Xt3uJSdmuwYpZHaJ7jq9TOxyfiEzAB0ogI1la mqTFf84tBpIZHeorApzcLl0F/JAIV0a8NbewjTr6XnmEVp3cSsVrNiBBh0v71ohhJ8z2 l8UxLh7j0E1Dg0qzbtdOVAuFN7U2qUsxLtd7uFKzbSrfyVBlaEGZO7oVGTrXpVZdZzeV syuf4DnbVALzIFCXNUFbFupcTQiLcQ0K1GHXQWShKjVn3y+ji2K8ZEX2sJ6jd4P5u+yN qAecBDIqO5YnoeB3x5IoQRY5ZWQRoS9SVk2J356chOm5nOg0eoBnbkyg51mSH6uMRXkD tv1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:reply-to:dkim-signature; bh=krYhVfxFdN/OVvO7sdngJN4LpQA8BhAq8fwbwKihSS8=; b=liWJLoBBztgkGkJL/C2vGGldEbCNnTHqwlkvrdaDpdmCUjf5bh5a1dffNdaAXCcSNJ va2jre8ci1+aCNYieARkspnnyR9kUc89AqKFwmDd354RGPSA89mWtqplv+WQQCfatTcl kXY0vWCfbgLbbxU6QkbsEQmpKdCuVPifd5dMR6R4etQbWNr2eesnyldeuYjySc1HdZ8m cYmcjd6xJvrOmewH82FvOt1O0Bgk1tKUeVi78DT9WqNdCgAAbBml3qCHspS6q1QLVfO1 mUwqkJEzAlaXa/oTT+p3Xg4+mJeNTyL5yQP4VqXoLz4t1U4uyhtuYBkKvx0IR78vuO7/ +b+g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=O9Itegwg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 17-20020a631251000000b00497a800555csi9382306pgs.284.2023.01.10.11.04.09; Tue, 10 Jan 2023 11:04:23 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=O9Itegwg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239664AbjAJS7i (ORCPT + 99 others); Tue, 10 Jan 2023 13:59:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39194 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239790AbjAJS6i (ORCPT ); Tue, 10 Jan 2023 13:58:38 -0500 Received: from mail-pj1-x1049.google.com (mail-pj1-x1049.google.com [IPv6:2607:f8b0:4864:20::1049]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ED9346418 for ; Tue, 10 Jan 2023 10:58:33 -0800 (PST) Received: by mail-pj1-x1049.google.com with SMTP id d8-20020a17090a7bc800b00226eb4523ceso4564924pjl.7 for ; Tue, 10 Jan 2023 10:58:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:from:to:cc:subject:date:message-id:reply-to; bh=krYhVfxFdN/OVvO7sdngJN4LpQA8BhAq8fwbwKihSS8=; b=O9ItegwgqSdf9S3Iv63GEthUTZhP5FUZI+MT3lb+9NWKW9t6zk8D2GR+Cw5akBAGQx /iHGnhJSx/SKzNfYYeiI3TfWQN2bkIq7eqi/iYr/knX0VFHF9648QoLTNUACE+bfgFc8 YDKwXVbgjfk4keBM+zPZNwelyFjLMIgSTaA/Hlqkd2/+anDe3rtHSfwuGTdVBvpKMijM 2quqNB4PIlkQwBod0JYV9epuLONJF1sCYy6qu4OqOYlggpormasntRD18lHTetmoqV9+ XYORoo+Jswq68VuPP6dko7VH8zHAPO7ZMEKNZVC+L4L9yctXVw0UP2ucoeMPbmZ1f+he r+HA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=krYhVfxFdN/OVvO7sdngJN4LpQA8BhAq8fwbwKihSS8=; b=YUW8NXxsqlioCO/z5eOAnRW4EkZhMXwTzdlluK4fxa3AsmYp45c6c9hrujdi/xcznG tLFiDPktnpfsaRjZYqLP6YmCVtUqCyWFTplVA4i33wVy+9mX5y5hiW9L5jCio75zpuqN GkFZrVilcUnnRIF5yHo1fFIRfBBjEffQgeaHURG/69uZqYOjfw1juP+0AhlnXFo0mkvT CinMMWu4Pxc08chLkbAJbOCIQ8Uch+y2+s/75iHFpL/4rgZq3pThiANcTjBCqfmCUAlP qGrF2OftG6kJpRtxW5W5Kiadxkpvke0lg6rRMWBskFTYzICuK3Z2aYRZPqpxccDfsm0R 9Nlg== X-Gm-Message-State: AFqh2kpd9JPMA2IXD+nzX0uetmIWtj0l8NxwjdHCY3DRa43mZjbDdUaN pZ9LAZJsU2TG/6I9uSdiocA55wbjkqq+ X-Received: from mizhang-super.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:1071]) (user=mizhang job=sendgmr) by 2002:a62:6487:0:b0:587:ca14:26ae with SMTP id y129-20020a626487000000b00587ca1426aemr977638pfb.71.1673377113465; Tue, 10 Jan 2023 10:58:33 -0800 (PST) Reply-To: Mingwei Zhang Date: Tue, 10 Jan 2023 18:58:23 +0000 In-Reply-To: <20230110185823.1856951-1-mizhang@google.com> Mime-Version: 1.0 References: <20230110185823.1856951-1-mizhang@google.com> X-Mailer: git-send-email 2.39.0.314.g84b9a713c41-goog Message-ID: <20230110185823.1856951-5-mizhang@google.com> Subject: [PATCH 4/4] KVM: selftests: x86: Repeat the checking of xheader when IA32_XFD[18] is set in amx_test From: Mingwei Zhang To: kvm@vger.kernel.org Cc: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Jim Mattson , Venkatesh Srinivas , Aaron Lewis , Mingwei Zhang X-Spam-Status: No, score=-9.6 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1754663447197289929?= X-GMAIL-MSGID: =?utf-8?q?1754663447197289929?= Repeat the checking of AMX component in xheader after xsavec when IA32_XFD[18] is set. This check calibrates the functionality scope of IA32_XFD: it does not intercept the XSAVE state management. Regardless of the values in IA32_XFD, AMX component state will still be managed by XSAVE* and XRSTOR* as long as XCR[18:17] are set. Signed-off-by: Mingwei Zhang --- tools/testing/selftests/kvm/x86_64/amx_test.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/tools/testing/selftests/kvm/x86_64/amx_test.c b/tools/testing/selftests/kvm/x86_64/amx_test.c index 18203e399e9d..9a80a59b64e6 100644 --- a/tools/testing/selftests/kvm/x86_64/amx_test.c +++ b/tools/testing/selftests/kvm/x86_64/amx_test.c @@ -235,6 +235,16 @@ static void __attribute__((__flatten__)) guest_code(struct tile_config *amx_cfg, /* xfd=0x40000, disable amx tiledata */ wrmsr(MSR_IA32_XFD, XFEATURE_MASK_XTILEDATA); + + /* + * Bit 18 is cleared in XSTATE_BV but set in XCOMP_BV, this property + * remains the same even when IA32_XFD disables amx tiledata. + */ + set_xstatebv(xsave_data, XFEATURE_MASK_XTILEDATA); + __xsavec(xsave_data, XFEATURE_MASK_XTILEDATA); + GUEST_ASSERT((get_xstatebv(xsave_data) & XFEATURE_MASK_XTILEDATA) == 0); + GUEST_ASSERT((get_xcompbv(xsave_data) & XFEATURE_MASK_XTILEDATA) == XFEATURE_MASK_XTILEDATA); + GUEST_SYNC(6); GUEST_ASSERT(rdmsr(MSR_IA32_XFD) == XFEATURE_MASK_XTILEDATA); set_tilecfg(amx_cfg);