From patchwork Tue Jan 10 18:58:20 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mingwei Zhang X-Patchwork-Id: 41588 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp2918107wrt; Tue, 10 Jan 2023 11:02:39 -0800 (PST) X-Google-Smtp-Source: AMrXdXs/wFuL6jr6Rk18Vww42lYc+byHPOaX49jMNsajd3s5FXQnjAh+XMHxLEbZPhHB2PSggAPt X-Received: by 2002:a17:902:edd1:b0:192:50fe:504a with SMTP id q17-20020a170902edd100b0019250fe504amr64671058plk.16.1673377359017; Tue, 10 Jan 2023 11:02:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673377358; cv=none; d=google.com; s=arc-20160816; b=waAp1u9xfttT4X/4NU3+2AG644JZT2QgsW3kY9npwihcqWR/zVtV5wl7i/yvtd+meX 50+8YrAsstd9z8eJKWO8P9H30YTjaKRkQZySBFSoWxfEogO/n6WTBXQ1VuzwnbVnkOPh 6yDkfYYX1VcnhtYNLuPWTK1F7nD0zvYtCIHx1VReiEt5nJItnSEB3/cxeCDJN9V92A9w ELrye3B0lokGfwwHjR7JTm6SCMpVvVQj2X3v43lwdiyCQrPiLP//7Ow1HxVQgfY4xi5D I4osGlSSyGwdH+cOeHjbgFMyY2Ndd6Yu3VajFbtNomdMJhMGbWmiNoDMLnLYllQoRwqI q7LQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:reply-to:dkim-signature; bh=aZj5nkPmUZ/+3WFmXIOMi6myvBqiEyZ2i8jBeyd2yO4=; b=bFZTQ5z8H3CJMjvdtWBj3lxznW5ZoAdztE1L2KemzUSc/MNkyKcusn03Jo5yHUQOPa By35cAU/UUkNmH6DI6XJbOj2nxuYhGO78h2rd5BcryRC2O3FNJqUz77NsjjGouE1hh9H Ywdc7bOrKqG5tNoCpU/bWIF/b0nc1dI5NNhaQM4KIujRGe+jIV2qtuUnChlQ0FvtJLQ7 qYhcE4hf0LUbixhwou7zVNiV55nBHhRMVQKq0UTG7m/NJEO+9Y8BNoZfJL7eaFJnPIuW uqUbrySphW8cLuGFS8dAZfHIcw2+NE/qH4HAMJMwUyGmSNHVyAUesw8RO74dJirFlVU+ 2Q4Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=kNaE2hOu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j6-20020a170903024600b00192d4c98f87si12697066plh.308.2023.01.10.11.02.24; Tue, 10 Jan 2023 11:02:38 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=kNaE2hOu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239549AbjAJS7Q (ORCPT + 99 others); Tue, 10 Jan 2023 13:59:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42682 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233693AbjAJS6f (ORCPT ); Tue, 10 Jan 2023 13:58:35 -0500 Received: from mail-pf1-x449.google.com (mail-pf1-x449.google.com [IPv6:2607:f8b0:4864:20::449]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9CD4D3896 for ; Tue, 10 Jan 2023 10:58:28 -0800 (PST) Received: by mail-pf1-x449.google.com with SMTP id b196-20020a621bcd000000b0058a63dc105eso1785667pfb.6 for ; Tue, 10 Jan 2023 10:58:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:from:to:cc:subject:date:message-id:reply-to; bh=aZj5nkPmUZ/+3WFmXIOMi6myvBqiEyZ2i8jBeyd2yO4=; b=kNaE2hOuqT1CeKskGFJKoOqj1OzySQvfQXderb/BCwvvYx5sqali1h75XgPDEKkhUn VIT5fTYFceymj4MKly4dsmGYvDWMP8DpxCmir5/1KFrjl5S/fR0WTxv9jfUF+acTIsNv ui49EcL2pMQodBk+nFC4Q3oGR//qesADTZKOUHNq5sKuEFL55iNAMpbVIj25BCy+XAr+ HoVRJR/O1nOBZhHQZbbL9+Cz0f52tZQIgSqWtmjeT4AavJb7pCjzOUo8bUIOktA2HDpu 9SAcCVSZBoVGOcHUMOwpS8hmbKGUgVjMNMFOg2O/zaSSiUG1MbimdKOOqUyOlHXCRVhJ 5hDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=aZj5nkPmUZ/+3WFmXIOMi6myvBqiEyZ2i8jBeyd2yO4=; b=Mnzw/7yhtXB6qoaETtgNaHTfgRHTGkcnixZLLmbbFFG5Dfjs8N6BcujgO2KCP4tw23 fWtyu9T/pDM2bZAr0WVhr7XX+TJbS9MUK1Es94iNSKWYtcy/P/AZVTb5W+3HJv34rTzJ DvyduZZR6ecIR1YW4K13If+4q+/uY1CkBKf7jDzr8SH4vpRjmK1Ly8RFtfuDRKxtyHdP fAMk0IMN1KBzNZ3IeRje1kOieynOJXHNqMwYqcheDEV/BAgyWdrVwfWPj5Z46g5Fr6mt z8zBkrwIrNczKOyW9K3CNSSaFaGxUM6lrwuww/cUaOOej+9h7RgoXJKgf8xi7ZCkvwLo NAWQ== X-Gm-Message-State: AFqh2kr260ZHu1bIQdbgOmUb53jgb5zn60wzQRzWLz0VFZwXIjwKdpSQ ovP7RdLdsUelc8radVmJwSLMozfyjpnQ X-Received: from mizhang-super.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:1071]) (user=mizhang job=sendgmr) by 2002:a17:902:e045:b0:193:1c8f:1835 with SMTP id x5-20020a170902e04500b001931c8f1835mr899892plx.62.1673377108205; Tue, 10 Jan 2023 10:58:28 -0800 (PST) Reply-To: Mingwei Zhang Date: Tue, 10 Jan 2023 18:58:20 +0000 In-Reply-To: <20230110185823.1856951-1-mizhang@google.com> Mime-Version: 1.0 References: <20230110185823.1856951-1-mizhang@google.com> X-Mailer: git-send-email 2.39.0.314.g84b9a713c41-goog Message-ID: <20230110185823.1856951-2-mizhang@google.com> Subject: [PATCH 1/4] KVM: selftests: x86: Fix an error in comment of amx_test From: Mingwei Zhang To: kvm@vger.kernel.org Cc: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Jim Mattson , Venkatesh Srinivas , Aaron Lewis , Mingwei Zhang X-Spam-Status: No, score=-9.6 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1754663337834206882?= X-GMAIL-MSGID: =?utf-8?q?1754663337834206882?= After the execution of __tilerelease(), AMX component will be in INIT state. Therefore, execution of xsavec saving the AMX state into memory will cause the XSTATE_BV[18] cleared in xheader. However, the XCOMP_BV[18] will remain set. Fix the error in comment. Cc: Jim Mattson Cc: Venkatesh Srinivas Cc: Aaron Lewis Signed-off-by: Mingwei Zhang --- tools/testing/selftests/kvm/x86_64/amx_test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/kvm/x86_64/amx_test.c b/tools/testing/selftests/kvm/x86_64/amx_test.c index bd72c6eb3b67..16533949a189 100644 --- a/tools/testing/selftests/kvm/x86_64/amx_test.c +++ b/tools/testing/selftests/kvm/x86_64/amx_test.c @@ -204,7 +204,7 @@ static void __attribute__((__flatten__)) guest_code(struct tile_config *amx_cfg, GUEST_SYNC(4); __tilerelease(); GUEST_SYNC(5); - /* bit 18 not in the XCOMP_BV after xsavec() */ + /* bit 18 not in the XSTATE_BV after xsavec() */ set_xstatebv(xsave_data, XFEATURE_MASK_XTILEDATA); __xsavec(xsave_data, XFEATURE_MASK_XTILEDATA); GUEST_ASSERT((get_xstatebv(xsave_data) & XFEATURE_MASK_XTILEDATA) == 0);