From patchwork Tue Jan 10 18:32:55 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christian Marangi X-Patchwork-Id: 41580 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp2908759wrt; Tue, 10 Jan 2023 10:40:04 -0800 (PST) X-Google-Smtp-Source: AMrXdXudNuOIexhOnHq/57DaIAIeDx5yGbNGBZegu3bthvSHVLokZaIvAzBsVIhACF9+/9AJ61sI X-Received: by 2002:a17:906:298f:b0:7c0:fa2c:fc9b with SMTP id x15-20020a170906298f00b007c0fa2cfc9bmr59894566eje.55.1673376004201; Tue, 10 Jan 2023 10:40:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673376004; cv=none; d=google.com; s=arc-20160816; b=X/MRgrtti7fFy9Vl+y6EPiY7ezSDiHvi7TWQRJsMmqM8sxottWxdWyjqlGbC/l24dG ylRlAVBqipiRGUyNYHzXNfiliYt93Q7jopDKmrvHv8mSM+l6seye5ckWsVIfOkKPwz8b /pFX8iYZ7hHnNyEzgrhxrY+Wf0mc70wkIUr9d1UI2JwAFlPAo2PMzmG18bzin5h0h/N3 TbLRYr6D2PctxCUC+NV47rdxWBo02CZKQYMibtDgwG1zQg8e8ZHwrJS3VGpQ2Xmi/frr VK10VeRDXK9A/9RJMigkhjTfcAeWz8iYm5dqY3qwxaz8em0qxWivWOoNVvr3giwSY9r5 eYjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=5BWNocoJfR7p1fldNOqHQx4uAST9YiXadKL7U15QU9g=; b=Z+h8njwym4qcFJ2ta9XsOrzFStAsU7jHReuq7wATln+gB2cFimRShKJKCJ81h3JMCU hryWnoFAtKs1HiOda0dDoMx+cBbaYLK/j8LiDw3LtKj7YbSCIjhTVEtGEzqqi2z5gq+q tnHlH+W3yPP3jQEMz+Ia2mCQrAZ8USpHEUqH50mdQagUmTom2imGZTROg+CuH1BekvTQ VV+pC/KjrNDSS1CQesMoXsvI70AgosBcMySxA45I3Hf3AT9GDXSL1TQdqbV9zYCY0DF/ rhmIB2yrNhs7pPejUEM5cHskMywh3qocILJ1GMb1/PBq0FjbtZ3kg1bAYyRtXzqwqFVx m0vw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=mJ99eYmi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id xe6-20020a170907318600b00780488c11bbsi12714435ejb.388.2023.01.10.10.39.39; Tue, 10 Jan 2023 10:40:04 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=mJ99eYmi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239528AbjAJSiu (ORCPT + 99 others); Tue, 10 Jan 2023 13:38:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53638 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239548AbjAJShz (ORCPT ); Tue, 10 Jan 2023 13:37:55 -0500 Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [IPv6:2a00:1450:4864:20::330]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8F0549B28B; Tue, 10 Jan 2023 10:33:10 -0800 (PST) Received: by mail-wm1-x330.google.com with SMTP id g10so9476475wmo.1; Tue, 10 Jan 2023 10:33:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=5BWNocoJfR7p1fldNOqHQx4uAST9YiXadKL7U15QU9g=; b=mJ99eYmiSpZsCUC0BnMc6Sxo+oj1FcqHNNOlrKuGyDo+rgvmHimZVrgldvYXhvTtNj suhc4tnHYI/K5ssOx2fyFu52WKWP+ZbkbfRAq/ZWjXlpkS3/GC80XZw4QupUvSR8SfKd mFT5JeuhHfu6CIni8oSBF3fbzbWjDnL3VpV5dEHUyYhry/6mghcGjKJ9IYm1fUZVJ+rp 6Inmbljy1N98lFu1N6viSDwk2pQz5NWEIx2/KWFLrLxVF2jHRW6H8czc4wwp+v5p+z84 qcN/GiwmMVNLsCx5khbQvgMUQrrqwoxMQvBjFuESvVU14v+Da29c+jBWrXL6JtWrtopv B5EA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5BWNocoJfR7p1fldNOqHQx4uAST9YiXadKL7U15QU9g=; b=BtYxMEqYRiNShq1tgOY2o0OfRw3lxSmdNTH8R2x0/h0gpQ/tQ5P2S4/ZvLh/VB12/t BirPk72Cw9SEgYbv/lLYhEfyTzilUEEu1rAulLvJAyh1Z2I1EZOSCILu7P65mPaVMGb4 n+FWc4eVusgednxKNm09yR0QjUQjs/PxYFnPce5nNe/updWxJsV2xGMEJXTdv/CAsdmG sqGfngjajzp+u4F9sxVjv7CzUD7dIacy4XLSLTlUWLI74/bCCkpV69FqvwhFOxbx4i3e OcoZ3lFwFIzLJ00Py+7wkeUcCVTc8bwyw8MTUOCBcxrKe4FRqIG9PAQuf+GuZ4kyg1Lp IjBw== X-Gm-Message-State: AFqh2krnOvS5zYYSkYi0jL+zEIgRyAxE+kvU5QIY34Xalxxn6x2X/uFX zvxpTQdM5qalHvPHTgfbbCM= X-Received: by 2002:a05:600c:220c:b0:3d2:3831:e5c4 with SMTP id z12-20020a05600c220c00b003d23831e5c4mr53934751wml.40.1673375588675; Tue, 10 Jan 2023 10:33:08 -0800 (PST) Received: from localhost.localdomain (93-34-92-88.ip49.fastwebnet.it. [93.34.92.88]) by smtp.googlemail.com with ESMTPSA id r126-20020a1c2b84000000b003d35c845cbbsm19927757wmr.21.2023.01.10.10.33.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Jan 2023 10:33:08 -0800 (PST) From: Christian Marangi To: Rob Herring , Krzysztof Kozlowski , Andy Gross , Bjorn Andersson , Konrad Dybcio , Michael Turquette , Stephen Boyd , Christian Marangi , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org Subject: [PATCH v6 2/6] dt-bindings: arm: msm: Convert and split kpss-acc driver Documentation to yaml Date: Tue, 10 Jan 2023 19:32:55 +0100 Message-Id: <20230110183259.19142-3-ansuelsmth@gmail.com> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20230110183259.19142-1-ansuelsmth@gmail.com> References: <20230110183259.19142-1-ansuelsmth@gmail.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1754661917106619403?= X-GMAIL-MSGID: =?utf-8?q?1754661917106619403?= Convert kpss-acc driver Documentation to yaml. The original Documentation was wrong all along. Fix it while we are converting it. The example was wrong as kpss-acc-v2 should only expose the regs but we don't have any driver that expose additional clocks. The kpss-acc driver is only specific to v1. For this exact reason, split the Documentation to 2 different schema, v1 as clock-controller and v2 for power-controller as per msm-3.10 specification, the exposed regs handle power domains. Signed-off-by: Christian Marangi --- .../bindings/arm/msm/qcom,kpss-acc.txt | 49 ------------- .../bindings/clock/qcom,kpss-acc-v1.yaml | 72 +++++++++++++++++++ .../bindings/power/qcom,kpss-acc-v2.yaml | 47 ++++++++++++ 3 files changed, 119 insertions(+), 49 deletions(-) delete mode 100644 Documentation/devicetree/bindings/arm/msm/qcom,kpss-acc.txt create mode 100644 Documentation/devicetree/bindings/clock/qcom,kpss-acc-v1.yaml create mode 100644 Documentation/devicetree/bindings/power/qcom,kpss-acc-v2.yaml diff --git a/Documentation/devicetree/bindings/arm/msm/qcom,kpss-acc.txt b/Documentation/devicetree/bindings/arm/msm/qcom,kpss-acc.txt deleted file mode 100644 index 7f696362a4a1..000000000000 --- a/Documentation/devicetree/bindings/arm/msm/qcom,kpss-acc.txt +++ /dev/null @@ -1,49 +0,0 @@ -Krait Processor Sub-system (KPSS) Application Clock Controller (ACC) - -The KPSS ACC provides clock, power domain, and reset control to a Krait CPU. -There is one ACC register region per CPU within the KPSS remapped region as -well as an alias register region that remaps accesses to the ACC associated -with the CPU accessing the region. - -PROPERTIES - -- compatible: - Usage: required - Value type: - Definition: should be one of: - "qcom,kpss-acc-v1" - "qcom,kpss-acc-v2" - -- reg: - Usage: required - Value type: - Definition: the first element specifies the base address and size of - the register region. An optional second element specifies - the base address and size of the alias register region. - -- clocks: - Usage: required - Value type: - Definition: reference to the pll parents. - -- clock-names: - Usage: required - Value type: - Definition: must be "pll8_vote", "pxo". - -- clock-output-names: - Usage: optional - Value type: - Definition: Name of the output clock. Typically acpuX_aux where X is a - CPU number starting at 0. - -Example: - - clock-controller@2088000 { - compatible = "qcom,kpss-acc-v2"; - reg = <0x02088000 0x1000>, - <0x02008000 0x1000>; - clocks = <&gcc PLL8_VOTE>, <&gcc PXO_SRC>; - clock-names = "pll8_vote", "pxo"; - clock-output-names = "acpu0_aux"; - }; diff --git a/Documentation/devicetree/bindings/clock/qcom,kpss-acc-v1.yaml b/Documentation/devicetree/bindings/clock/qcom,kpss-acc-v1.yaml new file mode 100644 index 000000000000..a466e4e8aacd --- /dev/null +++ b/Documentation/devicetree/bindings/clock/qcom,kpss-acc-v1.yaml @@ -0,0 +1,72 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/clock/qcom,kpss-acc-v1.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Krait Processor Sub-system (KPSS) Application Clock Controller (ACC) v1 + +maintainers: + - Christian Marangi + +description: + The KPSS ACC provides clock, power domain, and reset control to a Krait CPU. + There is one ACC register region per CPU within the KPSS remapped region as + well as an alias register region that remaps accesses to the ACC associated + with the CPU accessing the region. ACC v1 is currently used as a + clock-controller for enabling the cpu and hanling the aux clocks. + +properties: + compatible: + const: qcom,kpss-acc-v1 + + reg: + items: + - description: Base address and size of the register region + - description: Optional base address and size of the alias register region + minItems: 1 + + clocks: + minItems: 2 + maxItems: 2 + + clock-names: + items: + - const: pll8_vote + - const: pxo + + clock-output-names: + description: Name of the aux clock. Krait can have at most 4 cpu. + enum: + - acpu0_aux + - acpu1_aux + - acpu2_aux + - acpu3_aux + + '#clock-cells': + const: 0 + +required: + - compatible + - reg + - clocks + - clock-names + - clock-output-names + - '#clock-cells' + +additionalProperties: false + +examples: + - | + #include + + clock-controller@2088000 { + compatible = "qcom,kpss-acc-v1"; + reg = <0x02088000 0x1000>, <0x02008000 0x1000>; + clocks = <&gcc PLL8_VOTE>, <&pxo_board>; + clock-names = "pll8_vote", "pxo"; + clock-output-names = "acpu0_aux"; + #clock-cells = <0>; + }; + +... diff --git a/Documentation/devicetree/bindings/power/qcom,kpss-acc-v2.yaml b/Documentation/devicetree/bindings/power/qcom,kpss-acc-v2.yaml new file mode 100644 index 000000000000..91af95569ae6 --- /dev/null +++ b/Documentation/devicetree/bindings/power/qcom,kpss-acc-v2.yaml @@ -0,0 +1,47 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/power/qcom,kpss-acc-v2.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Krait Processor Sub-system (KPSS) Application Clock Controller (ACC) v2 + +maintainers: + - Christian Marangi + +description: + The KPSS ACC provides clock, power domain, and reset control to a Krait CPU. + There is one ACC register region per CPU within the KPSS remapped region as + well as an alias register region that remaps accesses to the ACC associated + with the CPU accessing the region. ACC v2 is currently used as a + power-controller for enabling the cpu. + +properties: + compatible: + const: qcom,kpss-acc-v2 + + reg: + items: + - description: Base address and size of the register region + - description: Optional base address and size of the alias register region + minItems: 1 + + '#power-domain-cells': + const: 0 + +required: + - compatible + - reg + - '#power-domain-cells' + +additionalProperties: false + +examples: + - | + power-controller@f9088000 { + compatible = "qcom,kpss-acc-v2"; + reg = <0xf9088000 0x1000>, + <0xf9008000 0x1000>; + #power-domain-cells = <0>; + }; +...