From patchwork Tue Jan 10 18:21:47 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rob Clark X-Patchwork-Id: 41570 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp2903260wrt; Tue, 10 Jan 2023 10:28:04 -0800 (PST) X-Google-Smtp-Source: AMrXdXsSr9EnnZctnpc6WI944mNak7srLtMxZBeXwG20XBkEolVwg4qj341pVixpfwFUNTcArXqE X-Received: by 2002:a17:906:30d3:b0:838:9b81:1c98 with SMTP id b19-20020a17090630d300b008389b811c98mr56816260ejb.1.1673375284571; Tue, 10 Jan 2023 10:28:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673375284; cv=none; d=google.com; s=arc-20160816; b=NMZy56bxbWIa+Oi4BGZRs0sjiYeFHT4Kh+Kw5kz+rktjhW4NKdfB3RPtzeNhyPwHXa mGe5TDXS11RcfrY26RkTXc2DwFqRmHpqa0er7boqVyy1/QzjbgMwkfGfF0LTqSLUdjEz I2yfKkIKPaq2nHFG8erip8yCpGrBPB650zEJGjf0o2jl9p2k/pPbVNb8Ng7vpmMHKL2P bzwgOn2THi23M7yazKla9UFCvLicmuL1oe5hGmKAd//n6Lvv07OylF54PIEkbGZiOeez gVQPZ8Kgb4ez3CBbYc/VdTe+BKYHsH5ikUU8dfHi+9RyWoQfbKilX9DRXMx+Y1IvY/+3 r8Sg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=xPPp4X1sBM/+EwXKJ1Udyn041rDe4dkPN+gbP+h2Yoc=; b=1JzwNHv+8BtvAhAnJt8us3fNl/MfPlHh4zk5PKqM5VzKG1Zm2Y2RwUIBy370QYklmD TbPP5RYpSDy/BhbAECpubJkO6gTQdlasfQNyk65QytORuYa2/+zHeZkRNEQr4uV1xpfZ Kn9ZVwdv9eTTegP8nkJpAHKIbcPiRuiFwAv4bBMiZmq015SAoraqYsGcUtieCMfmyTJd XLOPjVtiVI44w/wITKs9ofaT7qGe+F0G4EyeQXcoQ5V0/6GK9Js3cXlp7Mua5zJX3pmZ 2+NXVtdr5nRdx0y2zqbIR2qh1x3HyWK/Z95zdxlJlTBigk1bWUFPja2JKKidOa1YyMwu pCPQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=qJBXBpPJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id va17-20020a17090711d100b0081160837b7csi9685316ejb.286.2023.01.10.10.27.40; Tue, 10 Jan 2023 10:28:04 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=qJBXBpPJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239286AbjAJS0g (ORCPT + 99 others); Tue, 10 Jan 2023 13:26:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36792 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239359AbjAJSZb (ORCPT ); Tue, 10 Jan 2023 13:25:31 -0500 Received: from mail-pf1-x431.google.com (mail-pf1-x431.google.com [IPv6:2607:f8b0:4864:20::431]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DE37890856; Tue, 10 Jan 2023 10:22:11 -0800 (PST) Received: by mail-pf1-x431.google.com with SMTP id a184so9508011pfa.9; Tue, 10 Jan 2023 10:22:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xPPp4X1sBM/+EwXKJ1Udyn041rDe4dkPN+gbP+h2Yoc=; b=qJBXBpPJHtuENt0GARPRQKp2a2d2bG2sppM+WZAucEidaZyC+7Wdq7LI5CBoTGxNA3 jTM3LIlOEtS2/aAitqxnZlBmwxljOP+vIOV58uLlCtvqQEQ9Hp5OhT51wWZruY2i1MvY 6kNX/u3a2zanqEN+w3E8Fi5z7VxFwMtMlmKNz3DvJhEiBlnsPXKcLQGyP4QrZjvdFQov NpmA3F4p1EDwLG67Omt8qx9Z7OS9T/RSlw79BOSqJ9MZQA+/GvD7cezqN0I8G58X9fhL aKulhMPWw2ZlC2+GEWtLpHyTGBlhi2bX0OSfOQGJWyDhjoNo0z4KMuNgubZ3g4QCFu+8 RGmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xPPp4X1sBM/+EwXKJ1Udyn041rDe4dkPN+gbP+h2Yoc=; b=qaz2DXcYIt5Q6OSc0+xrH2UEGub+ep82IiIjlzku828JcX+j5a4ZJgRSP7OpTetcCh /MZ8TFcinWrc9F9gwFQUrbeRDY1js905H/tqfoSaf+5Bidx18He3/tk21E4CFrWSpqoZ rPWCim1wKi12EKHnWQOpzIXyrgXDJ/6vZ+vedTl9G7KTfvsFLS1ASzGVraNfjR9Xkgca CNbBqJQdyawOjgqDRK74GxkMYP09WWMqMoPgG/scZxODmqMqLk3vsmYokRZ0N3Ln/MBC RK0WJr9rT8al9uUOdv0Q1AYjes84BLgCAPxNXr087cmBCxtcfQ7ho7najm1sX1GMUZ5p sm2w== X-Gm-Message-State: AFqh2kqiwZFQKBUayWaMQBltUMZ3E32pz0cOTGlxZ02cLDuVZYdrEL+y 9oPzVI0atmcCBKVV76uzsuM= X-Received: by 2002:a05:6a00:4c0a:b0:589:85ed:4119 with SMTP id ea10-20020a056a004c0a00b0058985ed4119mr6884681pfb.32.1673374931439; Tue, 10 Jan 2023 10:22:11 -0800 (PST) Received: from localhost ([2a00:79e1:abd:4a00:2703:3c72:eb1a:cffd]) by smtp.gmail.com with ESMTPSA id p128-20020a622986000000b00581172f7456sm8410169pfp.56.2023.01.10.10.22.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Jan 2023 10:22:11 -0800 (PST) From: Rob Clark To: dri-devel@lists.freedesktop.org Cc: freedreno@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, Rob Clark , Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , David Airlie , Daniel Vetter , linux-kernel@vger.kernel.org (open list) Subject: [PATCH 3/3] drm/msm/gpu: Add default devfreq thresholds Date: Tue, 10 Jan 2023 10:21:47 -0800 Message-Id: <20230110182150.1911031-4-robdclark@gmail.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20230110182150.1911031-1-robdclark@gmail.com> References: <20230110182150.1911031-1-robdclark@gmail.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1754661162052783559?= X-GMAIL-MSGID: =?utf-8?q?1754661162052783559?= From: Rob Clark Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_gpu_devfreq.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/drivers/gpu/drm/msm/msm_gpu_devfreq.c b/drivers/gpu/drm/msm/msm_gpu_devfreq.c index e578d74d402f..1f31e72ca0cf 100644 --- a/drivers/gpu/drm/msm/msm_gpu_devfreq.c +++ b/drivers/gpu/drm/msm/msm_gpu_devfreq.c @@ -145,6 +145,15 @@ void msm_devfreq_init(struct msm_gpu *gpu) if (!gpu->funcs->gpu_busy) return; + /* + * Setup default values for simple_ondemand governor tuning. We + * want to throttle up at 50% load for the double-buffer case, + * where due to stalling waiting for vblank we could get stuck + * at (for ex) 30fps at 50% utilization. + */ + priv->gpu_devfreq_config.upthreshold = 50; + priv->gpu_devfreq_config.downdifferential = 10; + mutex_init(&df->lock); dev_pm_qos_add_request(&gpu->pdev->dev, &df->boost_freq,